Re: Add more rules to checkstyle.xml in fe

2022-04-14 Thread Shuo Wang
In general, I believe that we should do some work to make the code clean and readable. My concern is: 1. We should have an agreement on the code style specification in the community at first. 2. If the many lines of code change after applying the code style rule, we would lose the original changel

Re: [VOTE] Graduate Apache Doris (Incubating) as a TLP

2022-04-07 Thread Shuo Wang
+1. It's a new milestone for Doris! 陈明雨 于2022年4月7日周四 10:57写道: > Hi all, > > > > > Apache Doris (Incubating) has been in development for over 3 years since > it entered the Apache incubator in September 2018. > > During our time in the Incubator, we have learned a lot about open source > software

Re: The new scalable regression testing framework(#8125)

2022-02-21 Thread Shuo Wang
Great job, man! ling miao 于2022年2月21日周一 11:25写道: > First, we need to open source the P0 test set (From Baidu)~ > > Ling Miao > > 924060929 <924060...@qq.com.invalid> 于2022年2月19日周六 18:43写道: > > > Thinks for greate suggestions. > > > > > > The print result function is missing, and can run parallel

Re: Re: [Commit Format] Use a more standardized commit log format

2021-11-24 Thread Shuo Wang
/developer-guide/commit-format-specification.md > > > > > > > > -- > > 此致!Best Regards > 陈明雨 Mingyu Chen > > Email: > chenmin...@apache.org > > > > > > 在 2021-11-25 10:54:41,"Shuo Wang" 写道: > > I think the three below items a

Re: [Commit Format] Use a more standardized commit log format

2021-11-24 Thread Shuo Wang
I think the three below items are ambiguous and misleading: *feat-new: New function New feature or just a new expression function? And is the abbreviation `feat` sort for the word feature? The following ones are all `optimization`, it's sometimes hard to tell the difference. *feat-opt: Optimiza

Re: [VOTE] Release Apache Doris 0.15.0-incubating-rc04

2021-11-17 Thread Shuo Wang
+1 赵伟 于2021年11月17日周三 上午11:49写道: > > > +1 > > > On 11/17/2021 11:43,Xu,Yang(AIDP) wrote: > +1 > > 在 2021/11/16 下午7:10,“陈明雨” 写入: > > Hi all, > > > > > Please review and vote on Apache Doris 0.15.0-incubating-rc04 release. > > > > > The release candidate has been tagged in GitHub as 0.15.0-rc04[1]

Re: [Proposal] Return Optional in Catalog.getDb and Database.getTable

2021-08-03 Thread Shuo Wang
+1 迟成 于2021年8月3日周二 下午6:16写道: > The replay NPE bug has caused many cases that make all FE down. > To avoid this from happening, It’s necessary to check null when get DB and > Table object at any time. > I suggest that returns Optional object when get DB and Table object to > normalize the null ch