[GitHub] kangkaisen commented on issue #549: Add a colocate join meta repair tool

2019-01-16 Thread GitBox
kangkaisen commented on issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549#issuecomment-455071498 > By the way, this issue #540 you may need to know. And we decided to unify the tablet balance operation in this new framework. > Curr

[GitHub] kangkaisen commented on issue #549: Add a colocate join meta repair tool

2019-01-16 Thread GitBox
kangkaisen commented on issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549#issuecomment-455070963 @morningman >There is a serious problem that if the metadata has error, the Frontend instance may not even able to start, so th

[GitHub] kangkaisen commented on issue #549: Add a colocate join meta repair tool

2019-01-16 Thread GitBox
kangkaisen commented on issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549#issuecomment-455069634 OK. I agree with you. I also prefer HTTP. > I think HTTP or SQL is OK. CommandLine need admin to login in the host where service l

[GitHub] morningman merged pull request #550: Fix some bugs of alter table operation

2019-01-16 Thread GitBox
morningman merged pull request #550: Fix some bugs of alter table operation URL: https://github.com/apache/incubator-doris/pull/550 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] kangkaisen commented on a change in pull request #548: Skip balance when colocate group is balancing

2019-01-16 Thread GitBox
kangkaisen commented on a change in pull request #548: Skip balance when colocate group is balancing URL: https://github.com/apache/incubator-doris/pull/548#discussion_r248559121 ## File path: fe/src/main/java/org/apache/doris/clone/ColocateTableBalancer.java ## @@ -587,6

[GitHub] kangkaisen commented on a change in pull request #548: Skip balance when colocate group is balancing

2019-01-16 Thread GitBox
kangkaisen commented on a change in pull request #548: Skip balance when colocate group is balancing URL: https://github.com/apache/incubator-doris/pull/548#discussion_r248559089 ## File path: fe/src/main/java/org/apache/doris/clone/ColocateTableBalancer.java ## @@ -196,6

[GitHub] morningman merged pull request #547: Fix colocate join balance bug

2019-01-16 Thread GitBox
morningman merged pull request #547: Fix colocate join balance bug URL: https://github.com/apache/incubator-doris/pull/547 This is an automated message from the Apache Git Service. To respond to the message, please log on Git

[GitHub] morningman commented on issue #549: Add a colocate join meta repair tool

2019-01-16 Thread GitBox
morningman commented on issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549#issuecomment-455063070 By the way, this issue #540 you may need to know. And we decided to unify the tablet balance operation in this new framework. Currentl

[GitHub] morningman commented on issue #549: Add a colocate join meta repair tool

2019-01-16 Thread GitBox
morningman commented on issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549#issuecomment-455062272 There is a serious problem that if the metadata has error, the Frontend instance may not even able to start, so that both HTTP or SQL way

[GitHub] morningman commented on a change in pull request #548: Skip balance when colocate group is balancing

2019-01-16 Thread GitBox
morningman commented on a change in pull request #548: Skip balance when colocate group is balancing URL: https://github.com/apache/incubator-doris/pull/548#discussion_r248553440 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -4033,6 +4033,8 @@

[GitHub] morningman commented on a change in pull request #548: Skip balance when colocate group is balancing

2019-01-16 Thread GitBox
morningman commented on a change in pull request #548: Skip balance when colocate group is balancing URL: https://github.com/apache/incubator-doris/pull/548#discussion_r248553165 ## File path: fe/src/main/java/org/apache/doris/clone/ColocateTableBalancer.java ## @@ -196,6

[GitHub] morningman commented on a change in pull request #548: Skip balance when colocate group is balancing

2019-01-16 Thread GitBox
morningman commented on a change in pull request #548: Skip balance when colocate group is balancing URL: https://github.com/apache/incubator-doris/pull/548#discussion_r248553368 ## File path: fe/src/main/java/org/apache/doris/clone/ColocateTableBalancer.java ## @@ -587,6

[GitHub] morningman opened a new pull request #550: Fix some bugs of alter table operation

2019-01-16 Thread GitBox
morningman opened a new pull request #550: Fix some bugs of alter table operation URL: https://github.com/apache/incubator-doris/pull/550 1. Fix bug that failed to query restored table after schema change. 2. Fix bug that failed to add rollup to restored table. 3. Optimize the info of

[GitHub] imay merged pull request #539: Add DORIS_THIRDPARTY env in docker image

2019-01-16 Thread GitBox
imay merged pull request #539: Add DORIS_THIRDPARTY env in docker image URL: https://github.com/apache/incubator-doris/pull/539 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] imay commented on issue #549: Add a colocate join meta repair tool

2019-01-16 Thread GitBox
imay commented on issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549#issuecomment-455053722 I think HTTP or SQL is OK. CommandLine need admin to login in the host where service locates on, so it's not convenient. For HTTP and SQ

[GitHub] kangkaisen opened a new issue #549: Add a colocate join meta repair tool

2019-01-16 Thread GitBox
kangkaisen opened a new issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549 refer to https://github.com/apache/incubator-doris/issues/546 If our code has bug, the colocate meta maybe wrong. So we should add more Test and a repair tool

[GitHub] kangkaisen opened a new pull request #548: Skip balance when colocate group is balancing

2019-01-16 Thread GitBox
kangkaisen opened a new pull request #548: Skip balance when colocate group is balancing URL: https://github.com/apache/incubator-doris/pull/548 Fix colocate meta error in [546](https://github.com/apache/incubator-doris/issues/546)

[GitHub] kangkaisen opened a new pull request #547: Fix colocate join balance bug

2019-01-16 Thread GitBox
kangkaisen opened a new pull request #547: Fix colocate join balance bug URL: https://github.com/apache/incubator-doris/pull/547 Fix the colocate join balance bug in [546](https://github.com/apache/incubator-doris/issues/546)

[GitHub] kangkaisen opened a new issue #546: Colocate Join table balance bug

2019-01-16 Thread GitBox
kangkaisen opened a new issue #546: Colocate Join table balance bug URL: https://github.com/apache/incubator-doris/issues/546 **Describe the bug** Yestoday, I expanded 5 BEs to one prod cluster. when colocate table balance, there was a error ``` 2019-01-16 12:44:31,901 INFO 341 [C

[GitHub] imay commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-16 Thread GitBox
imay commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248247101 ## File path: fe/src/main/java/org/apache/doris/qe/StmtExecutor.java ## @@ -537,20 +539,25 @@ private void h

[GitHub] imay merged pull request #531: Add cpu and io indicates to audit log

2019-01-16 Thread GitBox
imay merged pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531 This is an automated message from the Apache Git Service. To respond to the message, please log on G

[GitHub] imay commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-16 Thread GitBox
imay commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248519055 ## File path: be/src/exec/exchange_node.cpp ## @@ -63,16 +64,16 @@ Status ExchangeNode::init(const TPlanNode

[GitHub] imay commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-16 Thread GitBox
imay commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248262654 ## File path: be/src/runtime/query_statistics.cpp ## @@ -0,0 +1,55 @@ +// Licensed to the Apache Software Fo

[GitHub] lenmom opened a new issue #545: surrogate key gerneration requested.

2019-01-16 Thread GitBox
lenmom opened a new issue #545: surrogate key gerneration requested. URL: https://github.com/apache/incubator-doris/issues/545 **scenario description:** supose we have a situation in **dim_sales_person(employee_id int , department int,...)**, and the fact table **fact_sales(order_id int,

[GitHub] morningman merged pull request #541: Fix bug that internal retry of stream load return wrong result

2019-01-16 Thread GitBox
morningman merged pull request #541: Fix bug that internal retry of stream load return wrong result URL: https://github.com/apache/incubator-doris/pull/541 This is an automated message from the Apache Git Service. To respond

[GitHub] imay merged pull request #538: Add counters to OlapScanNode

2019-01-16 Thread GitBox
imay merged pull request #538: Add counters to OlapScanNode URL: https://github.com/apache/incubator-doris/pull/538 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] morningman commented on a change in pull request #541: Fix bug that internal retry of stream load return wrong result

2019-01-16 Thread GitBox
morningman commented on a change in pull request #541: Fix bug that internal retry of stream load return wrong result URL: https://github.com/apache/incubator-doris/pull/541#discussion_r248206255 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java

[GitHub] morningman merged pull request #544: Fix UnixMicros function

2019-01-16 Thread GitBox
morningman merged pull request #544: Fix UnixMicros function URL: https://github.com/apache/incubator-doris/pull/544 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, None T

[GitHub] chaoyli merged pull request #532: Make reader can be compiled

2019-01-16 Thread GitBox
chaoyli merged pull request #532: Make reader can be compiled URL: https://github.com/apache/incubator-doris/pull/532 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, None

[GitHub] lide-reed opened a new pull request #544: Fix UnixMicros function

2019-01-16 Thread GitBox
lide-reed opened a new pull request #544: Fix UnixMicros function URL: https://github.com/apache/incubator-doris/pull/544 This is an automated message from the Apache Git Service. To respond to the message, please log on GitH

[GitHub] kangpinghuang opened a new pull request #543: Fix alpha rowset reader bug

2019-01-16 Thread GitBox
kangpinghuang opened a new pull request #543: Fix alpha rowset reader bug URL: https://github.com/apache/incubator-doris/pull/543 1. add delete handler process 2. fix reader logic 3. add next_block api This is an automat

[GitHub] morningman opened a new issue #542: Failed to auto-recovery replica with version missing

2019-01-16 Thread GitBox
morningman opened a new issue #542: Failed to auto-recovery replica with version missing URL: https://github.com/apache/incubator-doris/issues/542 We should review the 'tablet report' logic This is an automated message from t

[GitHub] imay commented on a change in pull request #541: Fix bug that internal retry of stream load return wrong result

2019-01-16 Thread GitBox
imay commented on a change in pull request #541: Fix bug that internal retry of stream load return wrong result URL: https://github.com/apache/incubator-doris/pull/541#discussion_r248185368 ## File path: fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java #

[GitHub] imay commented on a change in pull request #541: Fix bug that internal retry of stream load return wrong result

2019-01-16 Thread GitBox
imay commented on a change in pull request #541: Fix bug that internal retry of stream load return wrong result URL: https://github.com/apache/incubator-doris/pull/541#discussion_r248185216 ## File path: be/src/http/action/stream_load.cpp ## @@ -400,6 +400,10 @@ Status Str

[GitHub] chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-16 Thread GitBox
chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248184583 ## File path: fe/src/main/java/org/apache/doris/qe/ConnectProcessor.java ## @@ -92,12 +93,16 @@ pr

[GitHub] chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-16 Thread GitBox
chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248181923 ## File path: be/src/runtime/query_statistics.h ## @@ -0,0 +1,117 @@ +// Licensed to the Apache So

[GitHub] chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-16 Thread GitBox
chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248181808 ## File path: be/src/exec/exchange_node.cpp ## @@ -95,6 +96,12 @@ Status ExchangeNode::open(Runtim

[GitHub] chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log

2019-01-16 Thread GitBox
chenhao7253886 commented on a change in pull request #531: Add cpu and io indicates to audit log URL: https://github.com/apache/incubator-doris/pull/531#discussion_r248181848 ## File path: be/src/runtime/query_statistics.h ## @@ -0,0 +1,117 @@ +// Licensed to the Apache So