jmalkin commented on PR #10:
URL:
https://github.com/apache/datasketches-spark/pull/10#issuecomment-2579356246
This built on kll_merge so I guess it has those changes in the PR, too, at
least until that PR is merged.
--
This is an automated message from the Apache Git Service.
To respond
jmalkin opened a new pull request, #10:
URL: https://github.com/apache/datasketches-spark/pull/10
Tried to making member variable naming both consistent in style but also
more readable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jmalkin commented on code in PR #9:
URL: https://github.com/apache/datasketches-spark/pull/9#discussion_r1908068952
##
src/main/scala/org/apache/spark/sql/aggregate/KllMerge.scala:
##
@@ -17,45 +17,70 @@
package org.apache.spark.sql.aggregate
+import org.apache.datasketches
jmalkin commented on code in PR #9:
URL: https://github.com/apache/datasketches-spark/pull/9#discussion_r1908067912
##
src/main/scala/org/apache/spark/sql/aggregate/KllMerge.scala:
##
@@ -17,45 +17,70 @@
package org.apache.spark.sql.aggregate
+import org.apache.datasketches
[VOTE CLOSE & RESULT]
We received three (+1) votes and no other votes.
This vote is now closed, and we proceed on to release.
On Wed, Jan 8, 2025 at 4:38 PM Lee Rhodes wrote:
> +1 (binding)
>
> - GPG & SHA512 are OK
> - NOTICE & LICENSE OK
> - 'mvn clean test' passes
> - I confirmed that Java 17
+1 (binding)
- GPG & SHA512 are OK
- NOTICE & LICENSE OK
- 'mvn clean test' passes
- I confirmed that Java 17 FFM compiled code will not run under Java 21.
This is because the location of the FFM *incubation* code was moved from
*jdk.incubator.foreign* to its final position for *preview* at
*jav
leerho commented on issue #117:
URL:
https://github.com/apache/datasketches-bigquery/issues/117#issuecomment-2578351157
You need to make a request to the Google BQ team to enable that
functionality for your environment.
--
This is an automated message from the Apache Git Service.
To resp
AlexanderSaydakov commented on code in PR #9:
URL: https://github.com/apache/datasketches-spark/pull/9#discussion_r1907620418
##
src/main/scala/org/apache/spark/sql/aggregate/KllMerge.scala:
##
@@ -17,45 +17,70 @@
package org.apache.spark.sql.aggregate
+import org.apache.da
avNietz opened a new issue, #117:
URL: https://github.com/apache/datasketches-bigquery/issues/117
Local build, done using `make install` fails with the following error.
bigquery error: Option js_parameter_encoding_mode is not supported.
Operation failed: avinash_theta_test.cpc_sk
