+1 (binding)
I checked:
- mvn apache-rat:check
- mvn clean test
- mvn clean javadoc:javadoc
- mvn clean install
- checked /dist/dev/datasketches/memory/2.2.1-RC2
- maven/ has 5 jars + pom; all with .asc, .md5, and sha1
- src.zip with .asc and sha512
On Fri, May 31, 2024 at 12:25 PM Alexa
+1
Checked:
- gpg signature
- shasum
- "mvn clean test" with OpenJDK 8 and 11 (switched using jenv)
On Fri, May 31, 2024 at 10:23 AM Jon Malkin wrote:
> +1 (binding)
>
> I checked:
> * checksum and signatures of core files and /maven subdir
> * mvn clean test
> * mvn clean package
>
> The build
+1 (binding)
I checked:
* checksum and signatures of core files and /maven subdir
* mvn clean test
* mvn clean package
The build and tests were successful with both java 8 and 11 with no
additional command line options. It properly refused to build with java 17,
as expected.
jon
On Sun, May 2
