The vote passes with four binding +1 votes. Thanks, everyone. I have
published the release.
On Sat, Dec 7, 2024 at 5:16 AM Andrew Lamb wrote:
> +1 (binding)
>
> I verified on an M3 mac. Thanks everyone.
>
> One thing I noticed is that this is version 43.1.0, not 43.0.0 -- it wasn't
> quite clear
Thank you for sticking with it :pray:
On Thu, Dec 12, 2024 at 2:17 PM L. C. Hsieh wrote:
> Okay. Once commented out the `cargo publish` step, it is okay.
>
> +1 (binding)
>
> Verified on M3 Mac.
>
> Thanks Andrew.
>
> On Thu, Dec 12, 2024 at 11:00 AM Andrew Lamb wrote:
> >
> > Yes, unfortunatel
On Thu, Dec 12, 2024 at 1:49 PM Andy Grove wrote:
> The vote passes with four binding +1 votes. Thanks, everyone. I have
> published the release.
>
> On Sat, Dec 7, 2024 at 5:16 AM Andrew Lamb wrote:
>
>> +1 (binding)
>>
>> I verified on an M3 mac. Thanks everyone.
>>
>> One thing I noticed is t
Okay. Once commented out the `cargo publish` step, it is okay.
+1 (binding)
Verified on M3 Mac.
Thanks Andrew.
On Thu, Dec 12, 2024 at 11:00 AM Andrew Lamb wrote:
>
> Yes, unfortunately that happens due to [1]
>
> I think we just need to adjust the verification script to not run `cargo
> publi
Yes, unfortunately that happens due to [1]
I think we just need to adjust the verification script to not run `cargo
publish`
[1]: https://github.com/apache/datafusion-sqlparser-rs/issues/1596
On Thu, Dec 12, 2024 at 1:10 PM L. C. Hsieh wrote:
> Ah, I didn't notice that this is RC2.
>
> But I g
Ah, I didn't notice that this is RC2.
But I got another issue when running `verify-release-candidate.sh` with RC2:
```
error: failed to prepare local package for uploading
Caused by:
failed to select a version for the requirement `sqlparser_derive = "^0.3.0"`
candidate versions found whi
Thanks L.C. I also saw that problem with RC1 but thought I fixed it in RC2
(the PR[1] is here)
Can you confirm you are seeing this with RC2 as well?
Andrew
[1]: https://github.com/apache/datafusion-sqlparser-rs/pull/1595
On Thu, Dec 12, 2024 at 10:08 AM L. C. Hsieh wrote:
> There are a few fo
There are a few format issues while running `verify-release-candidate.sh`:
```
+ cargo fmt --all -- --check
Diff in
/private/var/folders/26/jr5lms716817rm8_wsr3w7n8gn/T/datafusion-sqlparser-rs-0.53.0.X.JaesmyIQIo/apache-datafusion-sqlparser-rs-0.53.0/derive/src/lib.rs:18:
use proc_ma
Hi,
I would like to propose a release of Apache DataFusion sqlparser-rs version
0.53.0.
Notes:
1. This is RC2 (RC1 hit [6])
2. there is a known, but I don't think blocking, issue with the
verification script[7]
This release candidate is based on commit:
e7d2c852918fe273a4f13288eae3c95cc99dff30 [
