Re: [VOTE] Release DataFusion Python Bindings 42.0.0 RC1

2024-10-08 Thread Michael Ward
+1 (non-binding) On Tue, Oct 8, 2024 at 6:23 AM Andrew Lamb wrote: > +1 (binding) > > This looks like a great release to me. Thanks Tim and Andy for keeping > things moving along. > > Verified on an m3 mac > > Andrew > > On Tue, Oct 8, 2024 at 5:23 AM Tim Saucer wrote: > > > +1 non-binding > >

Re: [PR] Add PostgreSQL specfic "CREATE TYPE t AS ENUM (...)" support. [datafusion-sqlparser-rs]

2024-10-08 Thread via GitHub
iffyio commented on code in PR #1460: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1460#discussion_r1792219167 ## src/dialect/postgresql.rs: ## @@ -138,6 +138,14 @@ impl Dialect for PostgreSqlDialect { fn parse_statement(&self, parser: &mut Parser) -> Option

Re: [PR] Add support for quantified comparison predicates (ALL/ANY/SOME) [datafusion-sqlparser-rs]

2024-10-08 Thread via GitHub
yoavcloud commented on PR #1459: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1459#issuecomment-2400352384 Pushed doc changes as recommended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Add support for quantified comparison predicates (ALL/ANY/SOME) [datafusion-sqlparser-rs]

2024-10-08 Thread via GitHub
iffyio commented on code in PR #1459: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1459#discussion_r1792185691 ## src/ast/mod.rs: ## @@ -646,12 +646,16 @@ pub enum Expr { regexp: bool, }, /// `ANY` operation e.g. `foo > ANY(bar)`, comparison op

Re: [I] `EXPLAIN QUERY PLAN` fails to parse (sqlite) [datafusion-sqlparser-rs]

2024-10-08 Thread via GitHub
alamb closed issue #1455: `EXPLAIN QUERY PLAN` fails to parse (sqlite) URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add support of `EXPLAIN QUERY PLAN` syntax for SQLite dialect [datafusion-sqlparser-rs]

2024-10-08 Thread via GitHub
alamb merged PR #1458: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

Re: [PR] Add support for ASC and DESC in CREATE TABLE column constraints for SQLite. [datafusion-sqlparser-rs]

2024-10-08 Thread via GitHub
alamb merged PR #1462: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

Re: [VOTE] Release DataFusion Python Bindings 42.0.0 RC1

2024-10-08 Thread Andrew Lamb
+1 (binding) This looks like a great release to me. Thanks Tim and Andy for keeping things moving along. Verified on an m3 mac Andrew On Tue, Oct 8, 2024 at 5:23 AM Tim Saucer wrote: > +1 non-binding > > Verified on m2 mac in python 3.10 and 3.12. > > Note: We need to add one line in the upda

Re: [VOTE] Release DataFusion Python Bindings 42.0.0 RC1

2024-10-08 Thread Tim Saucer
+1 non-binding Verified on m2 mac in python 3.10 and 3.12. Note: We need to add one line in the updated verification instructions to do a submodule init and update. On Tue, Oct 8, 2024 at 1:03 AM L. C. Hsieh wrote: > +1 (binding) > > Verified on M3 Mac. > > Thanks Andy. > > On Mon, Oct 7, 202