bmarwell opened a new pull request, #1929:
URL: https://github.com/apache/cxf/pull/1929
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reta commented on PR #1929:
URL: https://github.com/apache/cxf/pull/1929#issuecomment-2176009364
Thanks for the fix, @bmarwell , could you please update
`CodeGenOptionTest::testSuppressGeneratedDatePresentOption` to assert that the
`@Generated` annotation has no date? Thank you.
--
This
reta merged PR #1928:
URL: https://github.com/apache/cxf/pull/1928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For q
reta merged PR #1927:
URL: https://github.com/apache/cxf/pull/1927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For q
reta commented on PR #1929:
URL: https://github.com/apache/cxf/pull/1929#issuecomment-2176256297
```
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:87)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.junit.Assert.assertTrue(Assert.java:53)
bmarwell commented on PR #1929:
URL: https://github.com/apache/cxf/pull/1929#issuecomment-2176348193
Oh it's probably because of matcher.matches which checks for the whole line
to match exactly. I think it should have been .find instead.
Will check at home later
--
This is an auto
reta merged PR #1861:
URL: https://github.com/apache/cxf/pull/1861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For q
reta commented on code in PR #1901:
URL: https://github.com/apache/cxf/pull/1901#discussion_r1645104187
##
core/src/test/java/org/apache/cxf/bus/ManagedBusTest.java:
##
Review Comment:
