[GitHub] [cxf] coheigea commented on a diff in pull request #944: NPE fix in addClaims() method

2022-05-09 Thread GitBox
coheigea commented on code in PR #944: URL: https://github.com/apache/cxf/pull/944#discussion_r867801220 ## rt/ws/security/src/main/java/org/apache/cxf/ws/security/trust/AbstractSTSClient.java: ## @@ -1453,7 +1453,7 @@ protected void addClaims(XMLStreamWriter writer) throws Exc

[GitHub] [cxf] coheigea merged pull request #944: NPE fix in addClaims() method

2022-05-09 Thread GitBox
coheigea merged PR #944: URL: https://github.com/apache/cxf/pull/944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For

[GitHub] [cxf] jgreffe commented on pull request #945: [CXF-8699] Abillity to set sensitive filters on LoggingFeature

2022-05-09 Thread GitBox
jgreffe commented on PR #945: URL: https://github.com/apache/cxf/pull/945#issuecomment-1120878542 @reta , @coheigea , pushed changes, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cxf] reta merged pull request #945: [CXF-8699] Abillity to set sensitive filters on LoggingFeature

2022-05-09 Thread GitBox
reta merged PR #945: URL: https://github.com/apache/cxf/pull/945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For que

[GitHub] [cxf] reta commented on a diff in pull request #947: Cxf 8371

2022-05-09 Thread GitBox
reta commented on code in PR #947: URL: https://github.com/apache/cxf/pull/947#discussion_r867983746 ## parent/pom.xml: ## @@ -247,7 +247,8 @@ 1.2.18_1 1.2.4 3.0.7 -2.0.1 +1.0.0 + 1.0.0 Review Comment: Typo? `activition` ->

[GitHub] [cxf] jimma commented on a diff in pull request #947: Cxf 8371

2022-05-09 Thread GitBox
jimma commented on code in PR #947: URL: https://github.com/apache/cxf/pull/947#discussion_r867989247 ## parent/pom.xml: ## @@ -247,7 +247,8 @@ 1.2.18_1 1.2.4 3.0.7 -2.0.1 +1.0.0 + 1.0.0 Review Comment: Thanks for review @r

[GitHub] [cxf] jimma commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+

2022-05-09 Thread GitBox
jimma commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1121078678 @reta @coheigea Should we update the version to 5.0.0-SNAPSHOT ? If there is no objection,I'll start to update version number tomorrow. -- This is an automated message from the Apache Git Serv

[GitHub] [cxf] reta commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+

2022-05-09 Thread GitBox
reta commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1121084102 > @reta @coheigea Should we update the version to 5.0.0-SNAPSHOT ? If there is no objection,I'll start to update version number tomorrow. @jimma why 5.0.0? As we discussed, 4.0 is Jakarta, t

[GitHub] [cxf] jimma commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+

2022-05-09 Thread GitBox
jimma commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1121160155 > > @reta @coheigea Should we update the version to 5.0.0-SNAPSHOT ? If there is no objection,I'll start to update version number tomorrow. > > @jimma why 5.0.0? As we discussed, 4.0 is Jak

[GitHub] [cxf] reta commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+

2022-05-09 Thread GitBox
reta commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1121176481 > > > @reta @coheigea Should we update the version to 5.0.0-SNAPSHOT ? If there is no objection,I'll start to update version number tomorrow. > > > > > > @jimma why 5.0.0? As we discusse

[GitHub] [cxf] jimma commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+

2022-05-09 Thread GitBox
jimma commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1121181976 @reta If we'll change the master 4.0 to jakarta, I think we can plan some Alpha or milestone release to include the things already work. At least we make the CI work, and community can easily con

[GitHub] [cxf] reta commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+

2022-05-09 Thread GitBox
reta commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1121196246 > @reta If we'll change the master 4.0 to jakarta, I think we can plan some Alpha or milestone release to include the things already work. At least we make the CI work, and community can easily co

[GitHub] [cxf] reta merged pull request #947: Cxf 8371

2022-05-09 Thread GitBox
reta merged PR #947: URL: https://github.com/apache/cxf/pull/947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For que

[GitHub] [cxf] jimma commented on pull request #912: CXF-8371: Support Jakarta EE 9.1+

2022-05-09 Thread GitBox
jimma commented on PR #912: URL: https://github.com/apache/cxf/pull/912#issuecomment-1121825190 @reta I meant when can we merge the CXF-8371 to master ? And we probably need plan some Alpha or Milestone release in the jakarta 4.x CXF and make CI work , then we don 't need to maintain the