[GitHub] jimma commented on issue #414: [CXF-7653]:Add system property to enable/disable check empty response…

2018-05-02 Thread GitBox
jimma commented on issue #414: [CXF-7653]:Add system property to enable/disable check empty response… URL: https://github.com/apache/cxf/pull/414#issuecomment-385891859 @rmannibucau Thanks for review. You are right. I improved the code a bit, please check if it's good now. -

[GitHub] rmannibucau commented on issue #414: [CXF-7653]:Add system property to enable/disable check empty response…

2018-05-02 Thread GitBox
rmannibucau commented on issue #414: [CXF-7653]:Add system property to enable/disable check empty response… URL: https://github.com/apache/cxf/pull/414#issuecomment-385901522 Was more thinking about doing it in the constructor but works for me --

[GitHub] csierra commented on a change in pull request #398: [Draft] SSE implementation using AsyncContext

2018-05-02 Thread GitBox
csierra commented on a change in pull request #398: [Draft] SSE implementation using AsyncContext URL: https://github.com/apache/cxf/pull/398#discussion_r185453386 ## File path: rt/rs/sse/src/main/java/org/apache/cxf/jaxrs/sse/SseEventSinkContextProvider.java ## @@ -16,46

[GitHub] coheigea commented on issue #414: [CXF-7653]:Add system property to enable/disable check empty response…

2018-05-02 Thread GitBox
coheigea commented on issue #414: [CXF-7653]:Add system property to enable/disable check empty response… URL: https://github.com/apache/cxf/pull/414#issuecomment-386031806 The problem with this patch is that the default behaviour is still to throw a NPE in CXF - i.e. remove the change to t

[GitHub] reta opened a new pull request #415: Reimplementing SSE using AsyncContext (Servlet 3.1)

2018-05-02 Thread GitBox
reta opened a new pull request #415: Reimplementing SSE using AsyncContext (Servlet 3.1) URL: https://github.com/apache/cxf/pull/415 The PR is based solely on the contribution by @csierra (https://github.com/apache/cxf/pull/398) and fully passes the test suites CXF has at the moment. It b

[GitHub] reta closed pull request #398: [Draft] SSE implementation using AsyncContext

2018-05-02 Thread GitBox
reta closed pull request #398: [Draft] SSE implementation using AsyncContext URL: https://github.com/apache/cxf/pull/398 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull re

[GitHub] reta commented on issue #398: [Draft] SSE implementation using AsyncContext

2018-05-02 Thread GitBox
reta commented on issue #398: [Draft] SSE implementation using AsyncContext URL: https://github.com/apache/cxf/pull/398#issuecomment-386179479 Closing in favor of https://github.com/apache/cxf/pull/415, as discussed This is an

[GitHub] reta commented on issue #415: Reimplementing SSE using AsyncContext (Servlet 3.1)

2018-05-02 Thread GitBox
reta commented on issue #415: Reimplementing SSE using AsyncContext (Servlet 3.1) URL: https://github.com/apache/cxf/pull/415#issuecomment-386179889 @andymc12 could you by any chance help with verifying the implementation against JAX-RS 2.1 TCK (SSE)?

[GitHub] reta commented on issue #415: Reimplementing SSE using AsyncContext (Servlet 3.1)

2018-05-02 Thread GitBox
reta commented on issue #415: Reimplementing SSE using AsyncContext (Servlet 3.1) URL: https://github.com/apache/cxf/pull/415#issuecomment-386179891 @johnament @rmannibucau could you guys take a look / try it out, this is one of the improvements regarding SSE implementation in CXF we have