Re: FileUtils.getStringFromFile issue when using XML

2011-05-04 Thread Tom Eastmond
Ok, thanks for the feedback. I'll look into the suggestions that you offered. Thanks again, Tom On Wed, May 4, 2011 at 1:17 AM, Aki Yoshida wrote: > Hi Tom, > I think the wrong thing about this method is that it adds an extra > space at the beginning. If the file content is an XML and it starts

Re: FileUtils.getStringFromFile issue when using XML

2011-05-04 Thread Aki Yoshida
Hi Tom, I think the wrong thing about this method is that it adds an extra space at the beginning. If the file content is an XML and it starts with the xml declaration, there will be an extra space in front of the declaration that violates the well-formdness. You can create a jira issue for this p

Re: FileUtils.getStringFromFile issue when using XML

2011-05-03 Thread Tom Eastmond
That would be great to get this fixed - should I create a defect? I'd also love to not have it replace a single space with 2 spaces since that has caught me by surprise in my testing as well. Let me know what you'd like me to do. Thanks again, Tom Eastmond On Tue, May 3, 2011 at 6:19 AM, Aki Yosh

Re: FileUtils.getStringFromFile issue when using XML

2011-05-03 Thread Aki Yoshida
Sorry, I realized this method has actually nothing to do with XML. please ignore my comments on XML normalization. regards, aki 2011/5/3 Aki Yoshida : > Hi, > you are right. The normalizeCRLF() method should not add an extra > space at the begining. We can fix this particular issue. > > But there

Re: FileUtils.getStringFromFile issue when using XML

2011-05-03 Thread Aki Yoshida
Hi, you are right. The normalizeCRLF() method should not add an extra space at the begining. We can fix this particular issue. But there is one open question, as the exact purpose (use case) of this method is not clear to me. Why do we need this normalization method that just removes all the CRs a