Re: CORS: removing allowOrigins from the annotation only

2012-03-14 Thread Sergey Beryozkin
It appears that these 'difficulties' with allowAllOrigins & allowOrigins clearly indicate that the original Benson's idea to get one annotation per every property in [1] did have a lot of sense, however having the explosion of annotations seemed too much to me at the time. That said, I did also

Re: CORS: removing allowOrigins from the annotation only

2012-03-14 Thread Sergey Beryozkin
One thing I forgot to mention from the start that the easy option is simply not to attach CrossOriginResourceSharing to a given resource method, so the filter values will be used instead. I'm only really about making sure that CrossOriginResourceSharing can still be used if preferred while only

Re: CORS: removing allowOrigins from the annotation only

2012-03-14 Thread Sergey Beryozkin
Hi Aki On 14/03/12 11:12, Aki Yoshida wrote: Hi Sergey, I am not familiar with this stuff, so what I am saying may not make sense, though :-) thanks for the comments, they make sense :-) But can you use the different default value so that you can distinguish between the null (i.e., interpreted

Re: CORS: removing allowOrigins from the annotation only

2012-03-14 Thread Aki Yoshida
Hi Sergey, I am not familiar with this stuff, so what I am saying may not make sense, though :-) But can you use the different default value so that you can distinguish between the null (i.e., interpreted as allowAllOrigins=true) and an empty allowOrigins (i.e., allowAllOrigins=false) ? regards,

Re: CORS documentation

2012-01-19 Thread Satheesh Chinthapatla
Thanks for reply. CXF general is fine, Let me go through the link below provided Regards Satish On Thu, Jan 19, 2012 at 5:01 PM, Sergey Beryozkin wrote: > Hi > > > On 19/01/12 20:38, Satheesh Chinthapatla wrote: > >> Hello All, >> >> I would like to contribute some thing into this project but I

Re: CORS documentation

2012-01-19 Thread Sergey Beryozkin
Hi On 19/01/12 20:38, Satheesh Chinthapatla wrote: Hello All, I would like to contribute some thing into this project but I am not sure where to start since I am very new in contributing into open source. About me: I am lead java developer having 12 yrs of experience and currently working in

Re: CORS documentation

2012-01-19 Thread Sergey Beryozkin
On 19/01/12 20:10, Benson Margulies wrote: Sorry, I've been marginally sick and that has stopped me from making it to this task. I did try to write a lot of javadoc. It is all very well documented, thanks... Cheers, Sergey On Thu, Jan 19, 2012 at 1:19 PM, Sergey Beryozkin wrote: On 06/01/

Re: CORS documentation

2012-01-19 Thread Satheesh Chinthapatla
Hello All, I would like to contribute some thing into this project but I am not sure where to start since I am very new in contributing into open source. About me: I am lead java developer having 12 yrs of experience and currently working in NJ. Thanks Satish On Jan 19, 2012, at 3:11 PM, Ben

Re: CORS documentation

2012-01-19 Thread Benson Margulies
Sorry, I've been marginally sick and that has stopped me from making it to this task. I did try to write a lot of javadoc. On Thu, Jan 19, 2012 at 1:19 PM, Sergey Beryozkin wrote: > On 06/01/12 11:50, Sergey Beryozkin wrote: >> >> Hi Benson >> >> I've created a page for documenting the initial CO

Re: CORS documentation

2012-01-19 Thread Sergey Beryozkin
On 06/01/12 11:50, Sergey Beryozkin wrote: Hi Benson I've created a page for documenting the initial CORS support, https://cwiki.apache.org/confluence/display/CXF20DOC/JAX-RS+CORS if you get a chance, fill it in please; I can contribute too but a bit later I started putting some code examples

Re: CORS filter a bit noisy

2011-12-21 Thread Sergey Beryozkin
On 21/12/11 22:23, Sergey Beryozkin wrote: Hi Benson On 21/12/11 18:32, Benson Margulies wrote: It looks to me as if the CORS filter has a bug: it returns headers even when the request is not cross-origin. Sergey, WTYT? I'm sure it's not a tragedy and that I could fix that easily enough. Which

Re: CORS filter a bit noisy

2011-12-21 Thread Sergey Beryozkin
Hi Benson On 21/12/11 18:32, Benson Margulies wrote: It looks to me as if the CORS filter has a bug: it returns headers even when the request is not cross-origin. Sergey, WTYT? I'm sure it's not a tragedy and that I could fix that easily enough. Which headers are you referring to, the ones that a

Re: CORS

2011-12-01 Thread Sergey Beryozkin
On 01/12/11 14:01, Benson Margulies wrote: I've created org.apache.cxf.jaxrs.cors.CrossOriginResourceSharingFilter, which is gradually learning to pass all the tests I'm figuring out to write. It is a complete implementation of the spec AFAICT. Thanks Benson for doing it :-) Cheers, Sergey

Re: CORS

2011-12-01 Thread Benson Margulies
I've created org.apache.cxf.jaxrs.cors.CrossOriginResourceSharingFilter, which is gradually learning to pass all the tests I'm figuring out to write. It is a complete implementation of the spec AFAICT. On Sat, Nov 12, 2011 at 2:35 AM, K Fung wrote: > Hello, > > Are there any plans to expand this

Re: CORS

2011-11-30 Thread Benson Margulies
The code doesn't quite work as you expect. If there is no origin header at all, the input filter gets an empty array, not a null, so it does the wrong thing. On Sat, Nov 12, 2011 at 2:35 AM, K Fung wrote: > Hello, > > Are there any plans to expand this code so that covers both 5.1 and 5.2 of >

Re: CORS

2011-11-26 Thread Benson Margulies
I'd be happy to work on this code, but it *hasn't been contributed to Apache yet.* It's not a patch, it has no Apache license, and isn't attached to a JIRA. On Wed, Nov 23, 2011 at 6:26 AM, Sergey Beryozkin wrote: > I was thinking a bit more about it, we should probably just put it into > org.apa

Re: CORS

2011-11-23 Thread Sergey Beryozkin
I was thinking a bit more about it, we should probably just put it into org.apache.cxf.jaxrs.ext.cors in the jaxrs frontend at the moment, as I think that the creation of cxf-rt-jaxrs-extensions is needed shortly anyway which could keep most of the extensions, we can 'spawn' more specific modul

Re: CORS

2011-11-18 Thread Benson Margulies
OK, but attaching it to a JIRA still gives is clear provenance and we can find it a home later. On Fri, Nov 18, 2011 at 11:48 AM, Sergey Beryozkin wrote: > Hi Benson > On 18/11/11 00:25, Benson Margulies wrote: >> >> Serg, >> >> To contribute code, it's preferred, if possible, to attach it to a J

Re: CORS

2011-11-18 Thread Sergey Beryozkin
Hi Benson On 18/11/11 00:25, Benson Margulies wrote: Serg, To contribute code, it's preferred, if possible, to attach it to a JIRA. I was thinking of simply documenting it for a start as I'm not sure where to add this code to. I guess I'd like it to go to a sep module but at this stage creati

Re: CORS

2011-11-17 Thread Benson Margulies
Serg, To contribute code, it's preferred, if possible, to attach it to a JIRA. --benson On Thu, Nov 17, 2011 at 12:39 PM, sergkorney wrote: > here it is: > > public class JaxrsCorsInputFilter implements RequestHandler { > >        final static String HEADER_ORIGIN = "origin"; > >        @Conte

Re: CORS

2011-11-17 Thread sergkorney
here it is: public class JaxrsCorsInputFilter implements RequestHandler { final static String HEADER_ORIGIN = "origin"; @Context private HttpHeaders headers; private List allowedOrigins; public void setAllowedOrigins(List allowedOrigins) {

Re: CORS

2011-11-13 Thread Sergey Beryozkin
Hi, On 12/11/11 07:35, K Fung wrote: Hello, Are there any plans to expand this code so that covers both 5.1 and 5.2 of the CORS specification (http://www.w3.org/TR/cors?) In particular, - Not blocking the request of it's an OPTIONS request but doesn't contain the Origin header agreed, a JAX

Re: CORS

2011-11-13 Thread Sergey Beryozkin
Very good, thanks, On 11/11/11 19:46, sergkorney wrote: Thank you very much for the hint. I have added initial draft to support handling authenticated CORS requests for GET methods. And it works just fine (with cxf 2.5.0). Here is jaxrs input filter : public class JaxrsCorsInputFilter implement

Re: CORS

2011-11-11 Thread K Fung
Hello, Are there any plans to expand this code so that covers both 5.1 and 5.2 of the CORS specification (http://www.w3.org/TR/cors?) In particular, - Not blocking the request of it's an OPTIONS request but doesn't contain the Origin header - What if the request doesn't contain OPTIONS but does c

Re: CORS

2011-11-11 Thread sergkorney
Thank you very much for the hint. I have added initial draft to support handling authenticated CORS requests for GET methods. And it works just fine (with cxf 2.5.0). Here is jaxrs input filter : public class JaxrsCorsInputFilter implements RequestHandler { final static String HEADER_ORIG

Re: CORS

2011-11-11 Thread Sergey Beryozkin
On 11/11/11 01:30, sergkorney wrote: Let start from adding JAX-RS CORS filter. I think mostly CORS support is really needed for RESTful services. I'm new to CXF but have some experience with using CORS filter mentioned here http://software.dzhuvinov.com/cors-filter.html http://software.dzhuvinov

Re: CORS

2011-11-10 Thread sergkorney
Let start from adding JAX-RS CORS filter. I think mostly CORS support is really needed for RESTful services. I'm new to CXF but have some experience with using CORS filter mentioned here http://software.dzhuvinov.com/cors-filter.html http://software.dzhuvinov.com/cors-filter.html - Could you giv

Re: CORS

2011-11-07 Thread Sergey Beryozkin
On 07/11/11 14:39, Benson Margulies wrote: Why a filter? I guess, the advantage would be that it would work for SOAP and REST both. On the other hand, it's kind of 'over there'. Does JAX-RS have any other way to share out adding a handler for OPTIONS (and access control checking on Origin) that w

Re: CORS

2011-11-07 Thread Benson Margulies
Why a filter? I guess, the advantage would be that it would work for SOAP and REST both. On the other hand, it's kind of 'over there'. Does JAX-RS have any other way to share out adding a handler for OPTIONS (and access control checking on Origin) that would have any advantages? On Mon, Nov 7, 201

Re: CORS

2011-11-07 Thread Sergey Beryozkin
Hi Benson On 07/11/11 04:04, Benson Margulies wrote: Has anyone considered adding CORS (http://www.w3.org/TR/cors/) to CXF REST services? Obviously, it could be coded one service at a time, but it looks handy. Can you look at http://cxf.547215.n5.nabble.com/CORS-Interceptor-Filter-Endpoint-td4