Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-02-26 Thread via GitHub
ffang merged PR #1660: URL: https://github.com/apache/cxf/pull/1660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-02-13 Thread via GitHub
JiriOndrusek commented on code in PR #1660: URL: https://github.com/apache/cxf/pull/1660#discussion_r1488072808 ## rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/custom/DefaultAlgorithmSuiteLoader.java: ## @@ -140,9 +164,116 @@ protected void parseCustomAssertion

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-02-13 Thread via GitHub
ffang commented on PR #1660: URL: https://github.com/apache/cxf/pull/1660#issuecomment-1941778643 > @ffang I removed the null AlgorithmSuiteType from the suite loader. Thanks @JiriOndrusek ! -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-02-13 Thread via GitHub
ffang commented on code in PR #1660: URL: https://github.com/apache/cxf/pull/1660#discussion_r1480553067 ## rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/custom/DefaultAlgorithmSuiteLoader.java: ## @@ -140,9 +164,116 @@ protected void parseCustomAssertion(Assert

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-02-13 Thread via GitHub
JiriOndrusek commented on PR #1660: URL: https://github.com/apache/cxf/pull/1660#issuecomment-1941774951 @ffang I removed the null AlgorithmSuiteType from the suite loader. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-02-13 Thread via GitHub
JiriOndrusek commented on code in PR #1660: URL: https://github.com/apache/cxf/pull/1660#discussion_r1488064493 ## rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/custom/DefaultAlgorithmSuiteLoader.java: ## @@ -53,6 +59,8 @@ public AlgorithmSuite getAlgorithmSuite

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-02-13 Thread via GitHub
JiriOndrusek commented on PR #1660: URL: https://github.com/apache/cxf/pull/1660#issuecomment-1941354036 PR requires update of **wss4j** to **3.0.3** before merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-02-07 Thread via GitHub
JiriOndrusek commented on code in PR #1660: URL: https://github.com/apache/cxf/pull/1660#discussion_r1481431210 ## systests/ws-security/src/test/resources/wsdl_systest_wssec/wssec10/WsSecurity10_policy_customizedAlgorithmSuite.wsdl: ## @@ -0,0 +1,178 @@ + + +http://schemas.xmlso

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-02-07 Thread via GitHub
JiriOndrusek commented on code in PR #1660: URL: https://github.com/apache/cxf/pull/1660#discussion_r1481427972 ## rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/custom/DefaultAlgorithmSuiteLoader.java: ## @@ -53,6 +59,8 @@ public AlgorithmSuite getAlgorithmSuite

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-02-07 Thread via GitHub
ppalaga commented on code in PR #1660: URL: https://github.com/apache/cxf/pull/1660#discussion_r1481121130 ## rt/ws/security/src/main/java/org/apache/cxf/ws/security/policy/custom/DefaultAlgorithmSuiteLoader.java: ## @@ -53,6 +59,8 @@ public AlgorithmSuite getAlgorithmSuite(Bus

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-02-02 Thread via GitHub
ffang commented on PR #1660: URL: https://github.com/apache/cxf/pull/1660#issuecomment-1923890930 > @ffang is current failure related to the PR? I don't see any failed test. I'd say that some threads are hanging during the tests. Yesterday CI execution showed 1 failure because of NPE, which

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-02-02 Thread via GitHub
JiriOndrusek commented on PR #1660: URL: https://github.com/apache/cxf/pull/1660#issuecomment-1923750354 @ffang is current failure related to the PR? I don't see any failed test. I'd say that some threads are hanging during the tests. Yesterday CI execution showed 1 failure because of NPE,

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-02-01 Thread via GitHub
JiriOndrusek commented on PR #1660: URL: https://github.com/apache/cxf/pull/1660#issuecomment-1921487670 I just verified FIPS compliance by running test `WSSecurity10CustomizedAlgorithmSuiteTest` (by execution of `mvn clean test -f systests/ws-security -Dtest=WSSecurity10CustomizedAlgorith

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-02-01 Thread via GitHub
JiriOndrusek commented on PR #1660: URL: https://github.com/apache/cxf/pull/1660#issuecomment-1921459299 I harcoded the version of to 3.0.3-SNAPSHOT to get https://issues.apache.org/jira/browse/WSS-709 PR requires update of wss4f to 3.0.3 before merging -- This is an automated mes

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-02-01 Thread via GitHub
JiriOndrusek commented on PR #1660: URL: https://github.com/apache/cxf/pull/1660#issuecomment-1921423123 @ffang Thanks for the help. The PR is currently prepared to be merged. Here is a small summary: - New algSuite `CustomizedAlgorithmSuite` is registered in `DefaultAlgorithmS

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-01-31 Thread via GitHub
ffang commented on PR #1660: URL: https://github.com/apache/cxf/pull/1660#issuecomment-1919507106 > Hi @ffang , > > I continued with the work on this feature. Work is almost done, I'm stuck on a following problem: > > When I try to customize the alg. suite for he stax server, w

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-01-31 Thread via GitHub
JiriOndrusek commented on PR #1660: URL: https://github.com/apache/cxf/pull/1660#issuecomment-1919158378 Hi @ffang , I continued with the work on this feature. Work is almost done, I'm stuck on a following problem: When I try to customize the alg. suite for he stax server, wss

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-01-25 Thread via GitHub
ffang commented on PR #1660: URL: https://github.com/apache/cxf/pull/1660#issuecomment-1911011441 Thanks for the PR @JiriOndrusek ! FYI, just created https://issues.apache.org/jira/browse/WSS-709 to add more setters for AlgorithmSuite$AlgorithmSuiteType so that the customizedPol

Re: [PR] Introduction of CustomerizedAlgorithmSuite (CXF-8971) [cxf]

2024-01-24 Thread via GitHub
JiriOndrusek commented on PR #1660: URL: https://github.com/apache/cxf/pull/1660#issuecomment-1908114962 @ffang FYI ^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns