Re: svn commit: r1089385 - /cxf/trunk/api/src/main/java/org/apache/cxf/interceptor/Fault.java

2011-04-06 Thread Willem Jiang
I agree we should not leek the security information by default. After digging the code of FaultOutInterceptor, I think we could add a flag check in FaultOutInterceptor to let CXF check the cause of the Fault and change the exception message of Fault. To support the faultStackTraceEnabled flag

Re: [VOTE] Aki Yoshida for CXF committer

2011-04-06 Thread Freeman Fang
+1 of course Freeman On 2011-4-7, at 上午12:03, Daniel Kulp wrote: I'd like to call a vote on adding Aki Yoshida as a committer for CXF. Aki has been active with CXF for almost a year now. In that time, he's submitted patches to 8 JIRA issues, including one that had been logged several ye

Re: [VOTE] Aki Yoshida for CXF committer

2011-04-06 Thread Willem Jiang
+1. Just one more note, Aki also provided some patch for the camel-cxf component. Willem On 4/7/11 12:03 AM, Daniel Kulp wrote: I'd like to call a vote on adding Aki Yoshida as a committer for CXF. Aki has been active with CXF for almost a year now. In that time, he's submitted patches to

Re: [VOTE] Aki Yoshida for CXF committer

2011-04-06 Thread Dennis Sosnoski
+1 - Dennis On 04/07/2011 04:03 AM, Daniel Kulp wrote: > I'd like to call a vote on adding Aki Yoshida as a committer for CXF. > > Aki has been active with CXF for almost a year now. In that time, he's > submitted patches to 8 JIRA issues, including one that had been logged > several > ye

Re: [VOTE] Aki Yoshida for CXF committer

2011-04-06 Thread Benson Margulies
+1 On Wed, Apr 6, 2011 at 12:19 PM, Sergey Beryozkin wrote: > +1 > > Cheers, Sergey > > On Wed, Apr 6, 2011 at 5:03 PM, Daniel Kulp wrote: > >> >> I'd like to call a vote on adding Aki Yoshida as a committer for CXF. >> >> Aki has been active with CXF for almost a year now.   In that time, he's

Re: [VOTE] Aki Yoshida for CXF committer

2011-04-06 Thread Christian Schneider
+1 Christian Am 06.04.2011 18:03, schrieb Daniel Kulp: I'd like to call a vote on adding Aki Yoshida as a committer for CXF. Aki has been active with CXF for almost a year now. In that time, he's submitted patches to 8 JIRA issues, including one that had been logged several years ago. The

Re: [VOTE] Aki Yoshida for CXF committer

2011-04-06 Thread Sergey Beryozkin
+1 Cheers, Sergey On Wed, Apr 6, 2011 at 5:03 PM, Daniel Kulp wrote: > > I'd like to call a vote on adding Aki Yoshida as a committer for CXF. > > Aki has been active with CXF for almost a year now. In that time, he's > submitted patches to 8 JIRA issues, including one that had been logged >

Re: [VOTE] Aki Yoshida for CXF committer

2011-04-06 Thread Alessio Soldano
+1 On 04/06/2011 06:03 PM, Daniel Kulp wrote: I'd like to call a vote on adding Aki Yoshida as a committer for CXF. Aki has been active with CXF for almost a year now. In that time, he's submitted patches to 8 JIRA issues, including one that had been logged several years ago. The two main a

[VOTE] Aki Yoshida for CXF committer

2011-04-06 Thread Daniel Kulp
I'd like to call a vote on adding Aki Yoshida as a committer for CXF. Aki has been active with CXF for almost a year now. In that time, he's submitted patches to 8 JIRA issues, including one that had been logged several years ago. The two main areas he's contributed to are in the Management

Re: svn commit: r1089385 - /cxf/trunk/api/src/main/java/org/apache/cxf/interceptor/Fault.java

2011-04-06 Thread Daniel Kulp
On Wednesday 06 April 2011 9:48:34 AM Christian Schneider wrote: > Hi Dan, > > I think the cause of the exception is very import to diagnose problems > but I also understand that the leakage of security information is a big > problem. > > So how about introducing a config setting that controls if

Re: svn commit: r1089385 - /cxf/trunk/api/src/main/java/org/apache/cxf/interceptor/Fault.java

2011-04-06 Thread Christian Schneider
Hi Dan, I think the cause of the exception is very import to diagnose problems but I also understand that the leakage of security information is a big problem. So how about introducing a config setting that controls if the cause and stacktrace is transmitted. So for development systems the u

Re: svn commit: r1089385 - /cxf/trunk/api/src/main/java/org/apache/cxf/interceptor/Fault.java

2011-04-06 Thread Alessio Soldano
On 04/06/2011 12:35 PM, Daniel Kulp wrote: I think I'm -1 to this change. To me, this looks like it may leak security information and such to the client. Just my 2 cents, I agree with Dan, the default behaviour should not be to provide the "cause" of the exception there. Alessio

Re: svn commit: r1089385 - /cxf/trunk/api/src/main/java/org/apache/cxf/interceptor/Fault.java

2011-04-06 Thread Willem Jiang
Hi Dan, There are some other place which need to know about the cause of soap fault such as In the org.apache.cxf.databinding.source.XMLStreamDataReader, if there are some saop fault is throw from it, we can't know what exactly error from the client side. If the CXF server is put into produ

Re: svn commit: r1089385 - /cxf/trunk/api/src/main/java/org/apache/cxf/interceptor/Fault.java

2011-04-06 Thread Daniel Kulp
I think I'm -1 to this change. To me, this looks like it may leak security information and such to the client. The only message sent back to the client should be the top level message. The "causes" should be logged server side and not reflected back. If there are certain places where we C