Re: SLF4J instead of Log4J at the API level? [EXTERNAL]

2024-07-29 Thread Finan, Sean
Hi Richard, Many, many thanks for doing this. I gave it a pass and don't see anything that looks like it might cause a problem. I will run some tests. My comments on your comments: - The lifecycle plugin in the root POM uses "version" instead of "versionRange" in the main branch - the PR fi

Re: Build cTAKES using GitHub action? [EXTERNAL]

2024-07-29 Thread Finan, Sean
> Btw. how about setting up a GitHub action for building cTAKES? I thought about that when we switched over from svn. I didn't do it myself because I am happy with Jenkins. It also seems like quite the beast to romp around in a GH action. I suppose that we could have build profiles that only

Re: Build cTAKES using GitHub action?

2024-07-29 Thread Richard Eckart de Castilho
> On 29. Jul 2024, at 12:14, Finan, Sean > wrote: > >> Btw. how about setting up a GitHub action for building cTAKES? > > I thought about that when we switched over from svn. I didn't do it myself > because I am happy with Jenkins. Right, I honestly forgot that there's Jenkins. I guess th

Re: SLF4J instead of Log4J at the API level? [EXTERNAL]

2024-07-29 Thread Richard Eckart de Castilho
Hi Gandh, > On 27. Jul 2024, at 14:06, Gandhirajan N wrote: > > However, the versionRange in root POM could > introduce unpredictability in builds if newer versions introduce breaking > changes If that were a version range in a dependency: yes -- but this is a different case. However, this pa

Re: SLF4J instead of Log4J at the API level? [EXTERNAL]

2024-07-29 Thread Richard Eckart de Castilho
Hi, > On 29. Jul 2024, at 12:02, Finan, Sean > wrote: > > - The main branch still uses ContextSingletonBeanFactoryLocator which is not > part of Spring anymore and thus the Eclipse has compiler errors > -- ​I can look for an appropriate replacement. I briefly googled and I'm note sure if ther

Re: SLF4J instead of Log4J at the API level? [EXTERNAL]

2024-07-29 Thread Finan, Sean
> The main branch still uses ContextSingletonBeanFactoryLocator ... It looks like I had made a replacement a while ago for other instances of this problem, but had somehow missed those two tests. Consider it done. > For example in AssertionAnalysisEngine: Oh, those. From the days of yor. Garba

Re: Build cTAKES using GitHub action? [EXTERNAL]

2024-07-29 Thread Finan, Sean
I am pretty sure that nobody would mind ... The great thing about version control is that what has been done can always be undone. From: Richard Eckart de Castilho Sent: Monday, July 29, 2024 3:38 PM To: dev@ctakes.apache.org Subject: Re: Build cTAKES using Git