Re: Git Repository Creation

2014-01-20 Thread Garren Smith
Thanks Paul, For Fauxton we just need everything that is in src/Fauxton. Cheers Garren On 18 Jan 2014, at 3:10 AM, Paul Davis wrote: > I've spent most of the day initializing all of our new repositories > with the source code for each Erlang application. I've taken special > care to make sure

Re: Committer questions

2014-01-20 Thread Nick North
Thanks Dirkjan. To clarify the --no-ff merge option: my understanding is that if this is specified, then git always performs an extra merge commit that makes it clear that a branch has been merged. This applies regardless of rebasing the branch on to master. The diagram here

Re: Committer questions

2014-01-20 Thread Florian Westreicher Bakk.techn.
No ff also preserves the knowledge that a branch was merged. I you can see the difference when running git log --graph. When a fast forward merge is performed it looks like all the merged commits were done directly on the current branch, merging with no ff shows them on another branch. Nick No

Re: Committer questions

2014-01-20 Thread Garren Smith
Hi Nick On 19 Jan 2014, at 3:57 PM, Nick North wrote: > After reading Andy Wenk's really helpful Committer First > Stepsguide, I > feel pretty well informed on submitting code CouchDb code, but I > have just a few questions on commit etique

we need more reviews

2014-01-20 Thread Benoit Chesneau
Hi All, Over the last few months, we have had a pretty good track in commits -- which is great! However I think we can do better working as a team on this. I am sure others also feel the same way. For example: - Some code is still landing in master with little or absence of review in JIRA nor t

[jira] [Commented] (COUCHDB-2031) Paths ending in '/' rewrite query string params incorrectly

2014-01-20 Thread Benoit Chesneau (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876394#comment-13876394 ] Benoit Chesneau commented on COUCHDB-2031: -- [~kocolosk] I will have a look on t

Re: we need more reviews

2014-01-20 Thread Dale Harvey
I fully agree, its something I mentioned at the couchdb conf in vancouver, a review first system encourages contributions and has multiple benefits * At least 2 people look at the code, less likely to push silly mistakes * Can codify and practice review rules * Its much easier to view the curre

Re: we need more reviews

2014-01-20 Thread Andy Wenk
On 20 January 2014 13:26, Dale Harvey wrote: > I fully agree, its something I mentioned at the couchdb conf in vancouver, > a review first system encourages contributions and has multiple benefits > > * At least 2 people look at the code, less likely to push silly mistakes > * Can codify and pr

Re: we need more reviews

2014-01-20 Thread Benoit Chesneau
On Mon, Jan 20, 2014 at 1:26 PM, Dale Harvey wrote: > > > But I think the most important thing is that it removes the burden of > responsibility from the committer to the project as a whole, also hugely > beneficial is that it makes it particularly obvious when a patch has reach > a stalemate and

Re: we need more reviews

2014-01-20 Thread Benoit Chesneau
On Mon, Jan 20, 2014 at 1:46 PM, Andy Wenk wrote: > > > awesome to start this discussion. It was just some hours ago, that Hank > Knight exactly asked these questions. I am +1 on defining guidelines to > describe the process. It would not be the biggest problem to install gerrit > (https://code.g

Re: we need more reviews

2014-01-20 Thread Andy Wenk
On 20 January 2014 14:11, Benoit Chesneau wrote: > On Mon, Jan 20, 2014 at 1:46 PM, Andy Wenk wrote: > >> awesome to start this discussion. It was just some hours ago, that Hank >> Knight exactly asked these questions. I am +1 on defining guidelines to >> describe the process. It would not be t

[jira] [Commented] (COUCHDB-1835) Navbar layout refactor

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876465#comment-13876465 ] Garren Smith commented on COUCHDB-1835: --- This only happens in Dev because we fetch

[jira] [Resolved] (COUCHDB-1835) Navbar layout refactor

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1835. --- Resolution: Not A Problem > Navbar layout refactor > -- > >

Re: we need more reviews

2014-01-20 Thread Nick North
On 20 January 2014 12:26, Dale Harvey wrote: > I fully agree, its something I mentioned at the couchdb conf in vancouver, > a review first system encourages contributions and has multiple benefits > > * At least 2 people look at the code, less likely to push silly mistakes > * Can codify and pr

[jira] [Assigned] (COUCHDB-1873) Issue w/ navigating to pages where permission is denied

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith reassigned COUCHDB-1873: - Assignee: Garren Smith > Issue w/ navigating to pages where permission is denied >

[jira] [Resolved] (COUCHDB-1872) Footer: What's it supposed to look like?

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1872. --- Resolution: Fixed > Footer: What's it supposed to look like? > ---

[jira] [Updated] (COUCHDB-1870) New View: Add language option

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith updated COUCHDB-1870: -- Assignee: Benjamin Young > New View: Add language option > - > >

[jira] [Resolved] (COUCHDB-1966) user management

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1966. --- Resolution: Fixed > user management > --- > > Key: COUCHDB-1966

[jira] [Resolved] (COUCHDB-1889) Create a centralized list for all Documentation URLs that get referenced in the templates

2014-01-20 Thread Sue Lockwood (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sue Lockwood resolved COUCHDB-1889. --- Resolution: Fixed > Create a centralized list for all Documentation URLs that get reference

[jira] [Resolved] (COUCHDB-1967) View options

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1967. --- Resolution: Fixed > View options > > > Key: COUCHDB-1967 >

[jira] [Resolved] (COUCHDB-1968) View editor

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1968. --- Resolution: Fixed > View editor > --- > > Key: COUCHDB-1968 >

[jira] [Resolved] (COUCHDB-1971) New view button

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1971. --- Resolution: Fixed > New view button > --- > > Key: COUCHDB-1971

[jira] [Resolved] (COUCHDB-1970) New db as modal

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1970. --- Resolution: Fixed > New db as modal > --- > > Key: COUCHDB-1970

[jira] [Resolved] (COUCHDB-1984) Restore unfiltered data in logs UI

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1984. --- Resolution: Fixed > Restore unfiltered data in logs UI > --

[jira] [Resolved] (COUCHDB-1969) Visual view builder

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1969. --- Resolution: Fixed > Visual view builder > --- > > Key: COUC

[jira] [Resolved] (COUCHDB-1981) Replicate UI

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1981. --- Resolution: Fixed > Replicate UI > > > Key: COUCHDB-1981 >

[jira] [Resolved] (COUCHDB-1973) Fix delete doc button UI bug

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1973. --- Resolution: Fixed > Fix delete doc button UI bug > > >

[jira] [Resolved] (COUCHDB-1983) Filter logs by method

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1983. --- Resolution: Fixed > Filter logs by method > - > > Key:

[jira] [Resolved] (COUCHDB-1972) Show design docs only

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1972. --- Resolution: Fixed > Show design docs only > - > > Key:

[jira] [Resolved] (COUCHDB-1974) Delete multiple docs via _bulk_docs

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1974. --- Resolution: Fixed > Delete multiple docs via _bulk_docs > -

[jira] [Resolved] (COUCHDB-1975) PouchDB addon

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1975. --- Resolution: Fixed > PouchDB addon > - > > Key: COUCHDB-1975 >

[jira] [Resolved] (COUCHDB-1976) Bespoke bootstrap style

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1976. --- Resolution: Fixed > Bespoke bootstrap style > --- > > K

[jira] [Resolved] (COUCHDB-1977) Responsive interface

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1977. --- Resolution: Fixed > Responsive interface > > > Key: CO

[jira] [Resolved] (COUCHDB-1979) "show me" button in API bar doesn't

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1979. --- Resolution: Fixed > "show me" button in API bar doesn't > -

[jira] [Resolved] (COUCHDB-1982) Format log entry better

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1982. --- Resolution: Fixed > Format log entry better > --- > > K

[jira] [Resolved] (COUCHDB-1980) Edit index button doesn't

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1980. --- Resolution: Fixed > Edit index button doesn't > - > >

[jira] [Resolved] (COUCHDB-1978) Sticky subnav for some UI components on _all_docs

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1978. --- Resolution: Fixed > Sticky subnav for some UI components on _all_docs > ---

[jira] [Resolved] (COUCHDB-1935) Fauxton should show API URLs

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1935. --- Resolution: Fixed > Fauxton should show API URLs > > >

[jira] [Closed] (COUCHDB-1932) Incorrect link in Fauxton docs

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith closed COUCHDB-1932. - Resolution: Not A Problem > Incorrect link in Fauxton docs > -- > >

[jira] [Resolved] (COUCHDB-1958) /_utils/fauxton opens all databases on dashboard

2014-01-20 Thread Sue Lockwood (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sue Lockwood resolved COUCHDB-1958. --- Resolution: Fixed > /_utils/fauxton opens all databases on dashboard >

[jira] [Updated] (COUCHDB-2024) fauxton favicon should be the couchdb one

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith updated COUCHDB-2024: -- Assignee: Sue Lockwood > fauxton favicon should be the couchdb one >

[jira] [Resolved] (COUCHDB-1929) Fauxton databases list

2014-01-20 Thread Sue Lockwood (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sue Lockwood resolved COUCHDB-1929. --- Resolution: Fixed > Fauxton databases list > -- > > Key

[jira] [Resolved] (COUCHDB-1710) Update NOTICE file with various license info from fauxton dependencies

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1710. --- Resolution: Fixed > Update NOTICE file with various license info from fauxton dependencies

[jira] [Resolved] (COUCHDB-1921) Fauxton - Document edit mode on doubleclick

2014-01-20 Thread Garren Smith (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Garren Smith resolved COUCHDB-1921. --- Resolution: Fixed > Fauxton - Document edit mode on doubleclick > -

[jira] [Created] (COUCHDB-2033) refactoring api.js to framework

2014-01-20 Thread Garren Smith (JIRA)
Garren Smith created COUCHDB-2033: - Summary: refactoring api.js to framework Key: COUCHDB-2033 URL: https://issues.apache.org/jira/browse/COUCHDB-2033 Project: CouchDB Issue Type: Improvement

Re: [jira] [Resolved] (COUCHDB-1974) Delete multiple docs via _bulk_docs

2014-01-20 Thread Sneha Nathani
Unsubscribe On 20 Jan 2014, at 14:41, "Garren Smith (JIRA)" wrote: > > [ > https://issues.apache.org/jira/browse/COUCHDB-1974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Garren Smith resolved COUCHDB-1974. > --- > >Resolut

[REVIEW] refactoring api.js to framework

2014-01-20 Thread Garren Smith
Hi All, For Fauxton, I've been working on separating out the JS framework we have built on top of Backbone from Fauxton the web UI for CouchDB. Its sitting in the branch fauxton-file-reorder. See Github link for a nice visual diff (https://github.com/apache/couchdb/commits/fauxton-file-reorder)

Re: [REVIEW] refactoring api.js to framework

2014-01-20 Thread Adam Kocoloski
Where do you want comments? Is there a JIRA for the refactor? Adam On Jan 20, 2014, at 10:44 AM, Garren Smith wrote: > Hi All, > > For Fauxton, I've been working on separating out the JS framework we have > built on top of Backbone from Fauxton the web UI for CouchDB. Its sitting in > the br

Re: [REVIEW] refactoring api.js to framework

2014-01-20 Thread Garren Smith
Hi Adam, Sorry forgot to add jira ticket link. Here it is https://issues.apache.org/jira/browse/COUCHDB-2033 On 20 Jan 2014, at 5:57 PM, Adam Kocoloski wrote: > Where do you want comments? Is there a JIRA for the refactor? > > Adam > > On Jan 20, 2014, at 10:44 AM, Garren Smith wrote: > >

Re: [REVIEW] refactoring api.js to framework

2014-01-20 Thread Simon Metson
Jira is COUCHDB-2033 On Monday, 20 January 2014 at 15:57, Adam Kocoloski wrote: > Where do you want comments? Is there a JIRA for the refactor? > > Adam > > On Jan 20, 2014, at 10:44 AM, Garren Smith wrote: > > > Hi All, > > > > For Fauxton, I've been working on separating out the JS frame

Re: [REVIEW] refactoring api.js to framework

2014-01-20 Thread Alexander Shorin
On Mon, Jan 20, 2014 at 7:44 PM, Garren Smith wrote: > See Github link for a nice visual diff > (https://github.com/apache/couchdb/commits/fauxton-file-reorder) This one much better: https://github.com/apache/couchdb/compare/fauxton-file-reorder (; May be send github PR to let people leave comm

[jira] [Closed] (COUCHDB-1691) Topbar Addon

2014-01-20 Thread Ryan Ramage (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Ramage closed COUCHDB-1691. Resolution: Won't Fix Closing now as the garden plugins I was working towards should be replaced

Re: [REVIEW] refactoring api.js to framework

2014-01-20 Thread Alexander Shorin
On Mon, Jan 20, 2014 at 8:04 PM, Alexander Shorin wrote: > On Mon, Jan 20, 2014 at 7:44 PM, Garren Smith wrote: >> See Github link for a nice visual diff >> (https://github.com/apache/couchdb/commits/fauxton-file-reorder) > > This one much better: > https://github.com/apache/couchdb/compare/faux

couchdb pull request: ignoring index.css in concat:index_css

2014-01-20 Thread BigBlueHat
Github user BigBlueHat closed the pull request at: https://github.com/apache/couchdb/pull/135

Re: [REVIEW] refactoring api.js to framework

2014-01-20 Thread Garren Smith
Ok here is a PR https://github.com/apache/couchdb/pull/136 On 20 Jan 2014, at 6:04 PM, Alexander Shorin wrote: > On Mon, Jan 20, 2014 at 7:44 PM, Garren Smith wrote: >> See Github link for a nice visual diff >> (https://github.com/apache/couchdb/commits/fauxton-file-reorder) > > This one muc

couchdb pull request: Fauxton file reorder

2014-01-20 Thread garrensmith
GitHub user garrensmith opened a pull request: https://github.com/apache/couchdb/pull/136 Fauxton file reorder You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/couchdb fauxton-file-reorder Alternatively you can review and

Re: [REVIEW] refactoring api.js to framework

2014-01-20 Thread Garren Smith
On 20 Jan 2014, at 6:06 PM, Alexander Shorin wrote: > On Mon, Jan 20, 2014 at 8:04 PM, Alexander Shorin wrote: >> On Mon, Jan 20, 2014 at 7:44 PM, Garren Smith wrote: >>> See Github link for a nice visual diff >>> (https://github.com/apache/couchdb/commits/fauxton-file-reorder) >> >> This on

[jira] [Created] (COUCHDB-2034) authentication_handlers does not accept complex arguments

2014-01-20 Thread Daniel Moore (JIRA)
Daniel Moore created COUCHDB-2034: - Summary: authentication_handlers does not accept complex arguments Key: COUCHDB-2034 URL: https://issues.apache.org/jira/browse/COUCHDB-2034 Project: CouchDB