Re: [REVIEW] refactoring api.js to framework

2014-01-20 Thread Garren Smith
On 20 Jan 2014, at 6:06 PM, Alexander Shorin wrote: > On Mon, Jan 20, 2014 at 8:04 PM, Alexander Shorin wrote: >> On Mon, Jan 20, 2014 at 7:44 PM, Garren Smith wrote: >>> See Github link for a nice visual diff >>> (https://github.com/apache/couchdb/commits/fauxton-file-reorder) >> >> This on

Re: [REVIEW] refactoring api.js to framework

2014-01-20 Thread Garren Smith
Ok here is a PR https://github.com/apache/couchdb/pull/136 On 20 Jan 2014, at 6:04 PM, Alexander Shorin wrote: > On Mon, Jan 20, 2014 at 7:44 PM, Garren Smith wrote: >> See Github link for a nice visual diff >> (https://github.com/apache/couchdb/commits/fauxton-file-reorder) > > This one muc

Re: [REVIEW] refactoring api.js to framework

2014-01-20 Thread Alexander Shorin
On Mon, Jan 20, 2014 at 8:04 PM, Alexander Shorin wrote: > On Mon, Jan 20, 2014 at 7:44 PM, Garren Smith wrote: >> See Github link for a nice visual diff >> (https://github.com/apache/couchdb/commits/fauxton-file-reorder) > > This one much better: > https://github.com/apache/couchdb/compare/faux

Re: [REVIEW] refactoring api.js to framework

2014-01-20 Thread Alexander Shorin
On Mon, Jan 20, 2014 at 7:44 PM, Garren Smith wrote: > See Github link for a nice visual diff > (https://github.com/apache/couchdb/commits/fauxton-file-reorder) This one much better: https://github.com/apache/couchdb/compare/fauxton-file-reorder (; May be send github PR to let people leave comm

Re: [REVIEW] refactoring api.js to framework

2014-01-20 Thread Simon Metson
Jira is COUCHDB-2033 On Monday, 20 January 2014 at 15:57, Adam Kocoloski wrote: > Where do you want comments? Is there a JIRA for the refactor? > > Adam > > On Jan 20, 2014, at 10:44 AM, Garren Smith wrote: > > > Hi All, > > > > For Fauxton, I've been working on separating out the JS frame

Re: [REVIEW] refactoring api.js to framework

2014-01-20 Thread Garren Smith
Hi Adam, Sorry forgot to add jira ticket link. Here it is https://issues.apache.org/jira/browse/COUCHDB-2033 On 20 Jan 2014, at 5:57 PM, Adam Kocoloski wrote: > Where do you want comments? Is there a JIRA for the refactor? > > Adam > > On Jan 20, 2014, at 10:44 AM, Garren Smith wrote: > >

Re: [REVIEW] refactoring api.js to framework

2014-01-20 Thread Adam Kocoloski
Where do you want comments? Is there a JIRA for the refactor? Adam On Jan 20, 2014, at 10:44 AM, Garren Smith wrote: > Hi All, > > For Fauxton, I've been working on separating out the JS framework we have > built on top of Backbone from Fauxton the web UI for CouchDB. Its sitting in > the br