[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2015-04-21 Thread nolanlawson
Github user nolanlawson commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-94822123 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2015-04-21 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-94816845 @nolanlawson Thanks for the input. Ok, seems things getting simpler now, since I was confused different implementations. Good, I'll stay with Couchbase implementatio

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2015-04-21 Thread nolanlawson
Github user nolanlawson commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-94812766 > If I make /_bulk_get compatible with PouchDB As @dholth said, his implementation is a *PouchDB plugin*. PouchDB does not depend on it. > A to

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2015-04-21 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-94810216 @dholth About the errors...how do you feel with https://github.com/couchbase/sync_gateway/wiki/Bulk-GET ? Specifically: ``` If there's an error getti

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2015-04-21 Thread dholth
Github user dholth commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-94807050 The principle behind my _bulk_get is that it is *exactly* lots of GET returned in an array, the first implementation was even written as a lua intermediary bet

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2015-04-21 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-94792422 > However assuming RCouch has users why not do their json. Double check to see what arguments PouchDB _bulk_get actually uses. Well, I'm fine to break compat

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2015-04-21 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-94789582 > I may be the only pouchdb bulk get user. A top level array is a little better for streaming. Agree about streaming. > Does get return json for 4

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2015-04-21 Thread dholth
Github user dholth commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-94788972 However assuming RCouch has users why not do their json. Double check to see what arguments PouchDB _bulk_get actually uses. On Tue, Apr 21, 2015, at

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2015-04-21 Thread dholth
Github user dholth commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-94787191 I may be the only pouchdb bulk get user. A top level array is a little better for streaming. Does get return json for 404? That is what bulk get should do.

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2015-04-21 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-94781101 Hi there, short update. I'd started porting this PR over 2.0. First note that in current state it doesn't works and breaks any document update, so don't try

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2014-12-18 Thread dholth
Github user dholth commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-67570751 To add _bulk_get support to PouchDB you'd want to copy my version of replicate.js into PouchDB itself. It has a couple of extra require() calls that Pouch

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2014-12-18 Thread benoitc
Github user benoitc commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-67550634 @nolanlawson it also works for `Accept: Application/json`: https://github.com/rcouch/couchdb-couch-httpd/blob/master/src/couch_httpd_bulk_get.erl#L42 I

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2014-12-18 Thread nolanlawson
Github user nolanlawson commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-67548998 @benoitc One worry: it looks like your spec only returns type `multipart/related`, even if the client only says `Accept: application/json` – is that right? I as

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2014-12-18 Thread nolanlawson
Github user nolanlawson commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-67548296 @rnewson OK, but do we all agree that @benoitc's spec is the one to go with? It seems like it meets all the requirements we discussed in COUCHDB-2310. U

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2014-12-18 Thread rnewson
Github user rnewson commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-67546111 any change to the http layer unfortunately has to be done twice to be acceptable for inclusion. once here, and again in `https://github.com/apache/couchdb-chttpd`.

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2014-12-18 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-67540573 @nolanlawson `compatible with couchdb 1.6` is about rcouch codebase itself I believe. There is no `bulk_get` in any of CouchDB version, but we can make it in 1.7. Fo

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2014-12-18 Thread nolanlawson
Github user nolanlawson commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-67534359 @benoitc This is news to me; I don't think anyone even mentioned it in COUCHDB-2310. If there's an existing standard that CBLite and rcouch are using, t

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2014-12-18 Thread benoitc
Github user benoitc commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-67520435 Just to say that rcouch include a bulk_get api actully compatible with couchbase lite: http://docs.rcouch.org/en/latest/api/database/bulk-api.html#post--db

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2014-12-18 Thread nolanlawson
Github user nolanlawson commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-67519653 @dholth This is awesome. So I take it [this](https://github.com/dholth/pouchdb-bulk-get/blob/master/replicate.js.patch) is the patch to PouchDB so that

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2014-12-03 Thread jo
Github user jo commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-65390642 Thanks for this work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2014-12-03 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/18#issuecomment-65367017 You made it! However, while for 1.x it will work fine, for 2.0 your patch is need in a bit more work since you'd add node level HTTP handler, not the cluster

[GitHub] couchdb-couch pull request: rebased _bulk_get patch

2014-12-02 Thread dholth
GitHub user dholth opened a pull request: https://github.com/apache/couchdb-couch/pull/18 rebased _bulk_get patch This is a rebase for https://issues.apache.org/jira/browse/COUCHDB-2310 against post-1.6.x CouchDB. The idea is that when it is finished *every* GET option shou