Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/192#issuecomment-66851709
This seems to work well. Nice work, Michelle! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/202#issuecomment-66850728
Thanks - this'll now work for me when I have a `fauxton-selenium-tests2` db.
Just one super minor thing: I believe we do spaces around the `+` chars and
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/202#discussion_r21776189
--- Diff: app/addons/databases/tests/nightwatch/deletesDatabase.js ---
@@ -30,8 +30,8 @@ module.exports = {
.url(baseUrl+'/_all_dbs')
[
https://issues.apache.org/jira/browse/COUCHDB-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Keen closed COUCHDB-2502.
-
Resolution: Fixed
> Footer nav ("< >") shouldn't appear on Metadata page
> -
[
https://issues.apache.org/jira/browse/COUCHDB-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244821#comment-14244821
]
Ben Keen commented on COUCHDB-2508:
---
I was unable to reproduce #2 for some reason. But
[
https://issues.apache.org/jira/browse/COUCHDB-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244817#comment-14244817
]
ASF GitHub Bot commented on COUCHDB-2508:
-
GitHub user benkeen opened a pull req
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/203
Add auto focus to Delete DB modal
This ticket:
- Updates ModalView to default to focus on the first visible text field
by default.
- Updates the error message when the user fails
GitHub user michellephung opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/202
Make deleteDatabase test in Nightwatch more specific
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michellephung/couchdb-fauxto
[
https://issues.apache.org/jira/browse/COUCHDB-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on COUCHDB-2508 started by Ben Keen.
-
> Delete database modal tweaks
>
>
> Key
[
https://issues.apache.org/jira/browse/COUCHDB-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Keen updated COUCHDB-2512:
--
Summary: Provide semantic way to get "<" into Breadcrumbs (was: Provide
prefab way to get "<" into Br
[
https://issues.apache.org/jira/browse/COUCHDB-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on COUCHDB-2512 started by Ben Keen.
-
> Provide prefab way to get "<" into Breadcrumbs
> --
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/201#issuecomment-66836378
To test, we just need to confirm that the "<" item on the documents page
has a line separator after it like before.
---
If your project is set up for it, you ca
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/201
Add prefab way to get "<" in breadcrumbs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton
2512-prefab-back-brea
[
https://issues.apache.org/jira/browse/COUCHDB-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Keen updated COUCHDB-2512:
--
Description:
The way we're getting the "<" image to appear in the Breadcrumbs section is by
specifyin
[
https://issues.apache.org/jira/browse/COUCHDB-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Keen closed COUCHDB-2479.
-
Resolution: Fixed
This is actually already possible, just not terribly intuitive. If you
double-click t
[
https://issues.apache.org/jira/browse/COUCHDB-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Keen updated COUCHDB-2514:
--
Attachment: Screen Shot 2014-12-12 at 12.57.31 PM.png
> Content cut off at top of Accounts page
>
Ben Keen created COUCHDB-2514:
-
Summary: Content cut off at top of Accounts page
Key: COUCHDB-2514
URL: https://issues.apache.org/jira/browse/COUCHDB-2514
Project: CouchDB
Issue Type: Bug
S
Brian Mitchell created COUCHDB-2513:
---
Summary: Improve CouchDB rebar build scripts
Key: COUCHDB-2513
URL: https://issues.apache.org/jira/browse/COUCHDB-2513
Project: CouchDB
Issue Type: Imp
[
https://issues.apache.org/jira/browse/COUCHDB-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Keen updated COUCHDB-2512:
--
Description:
The way we're getting the "<" image to appear in the Breadcrumbs section is by
specifyin
[
https://issues.apache.org/jira/browse/COUCHDB-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Keen reassigned COUCHDB-2512:
-
Assignee: Ben Keen
> Provide prefab way to get "<" into Breadcrumbs
> -
Ben Keen created COUCHDB-2512:
-
Summary: Provide prefab way to get "<" into Breadcrumbs
Key: COUCHDB-2512
URL: https://issues.apache.org/jira/browse/COUCHDB-2512
Project: CouchDB
Issue Type: Impr
[
https://issues.apache.org/jira/browse/COUCHDB-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Keen updated COUCHDB-2512:
--
Description:
The way we're getting the "<" image to appear in the Breadcrumbs section is by
specifyin
Github user davisp commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/14#issuecomment-66832337
This needs a new branch name as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user davisp commented on the pull request:
https://github.com/apache/couchdb-fabric/pull/5#issuecomment-66831827
Just noticed that the branch name is wrong. Can you push a new PR with the
proper naming scheme please?
---
If your project is set up for it, you can reply to this
Github user davisp commented on the pull request:
https://github.com/apache/couchdb-fabric/pull/5#issuecomment-66831488
+1 Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
[
https://issues.apache.org/jira/browse/COUCHDB-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244745#comment-14244745
]
ASF subversion and git services commented on COUCHDB-2510:
--
Com
[
https://issues.apache.org/jira/browse/COUCHDB-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244746#comment-14244746
]
ASF GitHub Bot commented on COUCHDB-2510:
-
Github user asfgit closed the pull re
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fabric/pull/6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-chttpd/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
[
https://issues.apache.org/jira/browse/COUCHDB-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244741#comment-14244741
]
ASF subversion and git services commented on COUCHDB-2491:
--
Com
[
https://issues.apache.org/jira/browse/COUCHDB-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244742#comment-14244742
]
ASF GitHub Bot commented on COUCHDB-2491:
-
Github user asfgit closed the pull re
[
https://issues.apache.org/jira/browse/COUCHDB-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Joseph Davis resolved COUCHDB-2491.
Resolution: Fixed
Merged
> Refactor couch_httpd_auth's use of AuthModule
> --
GitHub user davisp opened a pull request:
https://github.com/apache/couchdb-couch/pull/23
Add IS_OLD_RECORD macro
This can be used in guards to detect if a state variable needs to be
upgraded. An example of it's use might be:
handle_call(Msg, From, St) when ?IS_OLD_R
[
https://issues.apache.org/jira/browse/COUCHDB-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244738#comment-14244738
]
ASF GitHub Bot commented on COUCHDB-2511:
-
GitHub user davisp opened a pull requ
[
https://issues.apache.org/jira/browse/COUCHDB-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244726#comment-14244726
]
ASF subversion and git services commented on COUCHDB-2511:
--
Com
[
https://issues.apache.org/jira/browse/COUCHDB-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244720#comment-14244720
]
ASF subversion and git services commented on COUCHDB-2491:
--
Com
[
https://issues.apache.org/jira/browse/COUCHDB-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244722#comment-14244722
]
ASF GitHub Bot commented on COUCHDB-2491:
-
Github user asfgit closed the pull re
[
https://issues.apache.org/jira/browse/COUCHDB-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244721#comment-14244721
]
ASF subversion and git services commented on COUCHDB-2491:
--
Com
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Paul Joseph Davis created COUCHDB-2511:
--
Summary: Add IS_OLD_RECORD macro to couch_db.hrl
Key: COUCHDB-2511
URL: https://issues.apache.org/jira/browse/COUCHDB-2511
Project: CouchDB
Issue
[
https://issues.apache.org/jira/browse/COUCHDB-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Keen resolved COUCHDB-2445.
---
Resolution: Fixed
> Create Confirmation modal to replace window.confirm()'s
> --
[
https://issues.apache.org/jira/browse/COUCHDB-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244677#comment-14244677
]
ASF GitHub Bot commented on COUCHDB-2445:
-
Github user benkeen closed the pull r
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/199#issuecomment-66824159
Merged as 47b2fec
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
[
https://issues.apache.org/jira/browse/COUCHDB-2445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244676#comment-14244676
]
ASF subversion and git services commented on COUCHDB-2445:
--
Com
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/199
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user michellephung commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/192#discussion_r21767491
--- Diff: app/addons/documents/views-index.js ---
@@ -454,7 +444,11 @@ function(app, FauxtonAPI, Components, Documents,
Databases, pouchdb, Que
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/192#issuecomment-66818349
I think this is ready to go
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user davisp commented on the pull request:
https://github.com/apache/couchdb-fabric/pull/6#issuecomment-66816904
Yeah, the is_replicator_db and is_users_db should probably be in
couch_replicator and couch_users_db but I figured we can clean that up later if
need be.
As
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/200#issuecomment-66811986
@robertkowalski fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/200#issuecomment-66811035
Agreed, that code is a bit fishy. Will fix up shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user ocelotpotpie commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66810990
+1 here! This is a heck of a PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66810445
+1 :) nice job @robertkowalski
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/200#issuecomment-66808904
The code for that behaviour is at
https://github.com/apache/couchdb-fauxton/blob/3d2180f6d6cb8a5913aaa2881e235efe8d5af87c/app/addons/documents/views-docedi
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/199#issuecomment-66807606
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66805822
Looks really good Robert. Just that one super minor thing, other than that
zero problems. +1
---
If your project is set up for it, you can reply to this email a
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66805393
One super small thing: the Add Option header link is 2px too high. Could
the CSS be changed to `#add-section-button { padding: 12px 14px; }` (formerly
`10px 14px
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66803880
thank you all for your testing and reviews! i fixed the issues and would be
happy if you could take a second look.
---
If your project is set up for it,
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/192#discussion_r21758367
--- Diff: app/addons/documents/views-index.js ---
@@ -454,7 +444,11 @@ function(app, FauxtonAPI, Components, Documents,
Databases, pouchdb, QueryOpti
[
https://issues.apache.org/jira/browse/COUCHDB-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244466#comment-14244466
]
ASF GitHub Bot commented on COUCHDB-2392:
-
Github user benkeen commented on a di
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/192#discussion_r21756794
--- Diff: test/nightwatch_tests/custom-commands/clickWhenReady.js ---
@@ -0,0 +1,12 @@
+exports.command = function (element, waitTime) {
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/192#discussion_r21756201
--- Diff: app/addons/documents/tests/nightwatch/editDocumentsFromView.js ---
@@ -0,0 +1,55 @@
+// Licensed under the Apache License, Versio
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/192#discussion_r21754046
--- Diff: test/nightwatch_tests/custom-commands/clickWhenReady.js ---
@@ -0,0 +1,12 @@
+exports.command = function (element, waitTime) {
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/192#discussion_r21752020
--- Diff: app/addons/documents/views-index.js ---
@@ -454,7 +444,11 @@ function(app, FauxtonAPI, Components, Documents,
Databases, pouchdb, Qu
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/192#discussion_r21751727
--- Diff: app/addons/documents/templates/all_docs_item.html ---
@@ -20,15 +20,18 @@
-<%- doc.isEditable() ? 'id' :
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/192#discussion_r21751681
--- Diff: app/addons/documents/templates/all_docs_item.html ---
@@ -20,15 +20,18 @@
-<%- doc.isEditable() ? 'id' :
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/192#issuecomment-66789179
Can y
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66785119
yay i finally fixed the typeahead!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66766269
The typeahead is a real problem... our container has to be overflow:hidden
but it cuts of the typeahead which is a child of the input which is placed in
t
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-fabric/pull/6#issuecomment-66760612
+1, pulling this up seems the obvious way to avoid the conflicts/branching
from doing it at the shards. Don't we also want to inhibit these handlers
firing again fo
Github user rnewson commented on a diff in the pull request:
https://github.com/apache/couchdb-fabric/pull/6#discussion_r21738688
--- Diff: src/fabric_doc_update.erl ---
@@ -97,6 +98,28 @@ handle_message({not_found, no_db_file} = X, Worker,
Acc0) ->
handle_message({bad_request
[
https://issues.apache.org/jira/browse/COUCHDB-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243923#comment-14243923
]
Garren Smith commented on COUCHDB-2507:
---
this looks awesome Ben, looking forward t
71 matches
Mail list logo
