Re: Process for code submissions?

2012-08-06 Thread Bob Dionne
Nick, You can ignore this given Bob Newson picked it up. I guess the mailing list took some time off, I sent this out yesterday at 11:30 am. Cheers, Bob On Aug 5, 2012, at 11:22 AM, Bob Dionne wrote: > Hi Nick, > > Sorry this is my fault for dropping the ball on this. It looks like we batte

Re: Process for code submissions?

2012-08-06 Thread Bob Dionne
Hi Nick, Sorry this is my fault for dropping the ball on this. It looks like we batted this around a bit, you made good progress refactoring, enhancing, etc.. and then we all forgot about it. I'll review the patch again in the next couple of days with respect to the current code and either get

[jira] [Commented] (COUCHDB-1177) function_clause error in write_streamed_attachment

2012-08-06 Thread Jens Alfke (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429302#comment-13429302 ] Jens Alfke commented on COUCHDB-1177: - This same exception has been reported against

Re: Process for code submissions?

2012-08-06 Thread Nick North
This looks great - thank you, and apologies for the broken test. I've closed the pull request, so I think everything is done. Nick On 6 August 2012 13:02, Robert Newson wrote: > Hi Nick, > > I've merged your new feature to couchdb master, thanks very much! > > You'll notice a few tweaks from me;

couchdb pull request: utc_id_suffix UUID algorithm

2012-08-06 Thread NorthNick
Github user NorthNick closed the pull request at: https://github.com/apache/couchdb/pull/28

[jira] [Resolved] (COUCHDB-1373) Time-order​ed document ids including the database identity

2012-08-06 Thread Robert Newson (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Newson resolved COUCHDB-1373. Resolution: Fixed Fix Version/s: 1.3 > Time-order​ed document ids including th

Re: Process for code submissions?

2012-08-06 Thread Robert Newson
Hi Nick, I've merged your new feature to couchdb master, thanks very much! You'll notice a few tweaks from me; 1) I removed you from THANKS, given that it's now auto-generated (slipped my mind) 2) I fixed the broken etap test (sometimes get_suffix receives a binary, sometimes a list) 3) The al

Re: Process for code submissions?

2012-08-06 Thread Nick North
I've updated the pull request with these changes and updates to the NEWS and CHANGES files. The note at the bottom of the THANKS file implied that maybe I did not need to add my name, but I did it just in case. I'm slightly wary of the git processes involved in all this, but the GitHub diff looks g