GitHub user swbradshaw opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/197
CB-4078: correctOrientation not working on camera.getPicture for
PHOTOLIBRARY
This fixes the orientation bug for Android 4.4+ devices when choosing a
picture from the photo
Github user swbradshaw commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-200913136
I personally saw the issue on on LG G2(5.0.2) and LG V10 (5.1).
I believe it affects all devices running Android 4.4 and newer because the
Github user swbradshaw commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-201534121
@riknoll - Can you clarify?
Are you referring to the apps that have implement the DocumentsProvider
interface that show up on the unified UI
Github user swbradshaw commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-201565769
`ouputModifiedBitmap()` is not fixed in master.
`getRealPathFromURI_API19()` in FileHelper returns an empty string and thus the
fileName cannot be
Github user swbradshaw commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-201567303
Should I go ahead and fix `ouputModifiedBitmap()` for this pull request?
The reality is now that orientation is fixed, this is going to cause that
Github user swbradshaw commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-201611674
@riknoll - I found the changes you were talking about. The changes in
CB-10460 will make the `ouputModifiedBitmap()` function correctly because the
Github user swbradshaw commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-203883218
@unbeatableDeepak Grab the changes in CB-10460 as well and that should fix
your issue. Please verify.
---
If your project is set up for it, you can
Github user swbradshaw commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-203886789
@unbeatableDeepak please see this pull request:
https://github.com/apache/cordova-plugin-camera/pull/194
Can you please provide the code
Github user swbradshaw commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-203919964
@unbeatableDeepak Thanks. I was referring to your JS code. I would like to
reproduce what you are seeing on my side with the same options you are
Github user swbradshaw commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-203968527
@unbeatableDeepak I was able to reproduce your issues. I'll take a look to
see how I can fix this.
---
If your project is set up for it, yo
Github user swbradshaw commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-205285417
@unbeatableDeepak I have a solution coded, but I haven't had a chance to
test it yet.
---
If your project is set up for it, you can reply to
Github user swbradshaw commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-215287391
@unbeatableDeepak My changes have been committed. I did a rebase from the
master since I was weeks behind. Since this is my first PR, I'm not su
Github user swbradshaw closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/197
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user swbradshaw reopened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/197
CB-4078: correctOrientation not working on camera.getPicture for
PHOTOLIBRARY
This fixes the orientation bug for Android 4.4+ devices when choosing a
picture from the photo
Github user swbradshaw commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-215290093
Re-opening with cleaned up fork.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user swbradshaw commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/158#issuecomment-215291931
@morioma - Take a look at #197 again. I completely rewrote the
implementation.
---
If your project is set up for it, you can reply to this email
Github user swbradshaw commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-218847324
@JEGardner Well, that's embarrassing. Check it out now and it should work
for you.
---
If your project is set up for it, you can reply to
Github user swbradshaw commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-218930850
@riknoll I just removed a big chunk of the whitespace changes that were
done by Android Studio. I find myself having to manually copy changes from my
Github user swbradshaw commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
@riknoll Have you had a chance to test these changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swbradshaw commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/170
Someone needs to take a look at all the open camera PR. There are many
problems with this getRealPath and it has been discussed in a few places. It
seems like this PR helps out a
Github user swbradshaw commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
@stevengill ill take a look this weekend. This is my first PR/rebase so
I've got some homework to do
---
If your project is set up for it, you can reply to this email and
Github user swbradshaw commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
@stevengill - I think this is good to go. My first PR/rebase, hopefully
didn't messed it up!
-Rebased from master
-Verified rotation is working correctly after
Github user swbradshaw commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/197
@stevengill Man, I'm such an amateur. Removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
23 matches
Mail list logo
