Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-cli/pull/104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-cli/pull/140
CB-6256 Windows8. Apply start page uri from config.xml
https://issues.apache.org/jira/browse/CB-6256
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-cli/pull/141
CB-6266 Windows8. Add Whitelisting rules support from config file
https://issues.apache.org/jira/browse/CB-6266
You can merge this pull request into a Git repository by running:
$ git
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-cli/pull/142
CB-6267 Windows8. Apply BackgroundColor from config.xml
https://issues.apache.org/jira/browse/CB-6267
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-wp8/pull/29
CB-6268 WP8. Apply BackgroundColor from config.xml
https://issues.apache.org/jira/browse/CB-6268
You can merge this pull request into a Git repository by running:
$ git pull https
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-wp8/pull/29#issuecomment-37720571
Jesse, fully agree w/ your comments. Will update the code today. Thx!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-wp8/pull/29#issuecomment-37722422
@purplecabbage, updated the code + force pushed. Pls review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-cli/pull/126#issuecomment-37723271
@AxelNennker, could you please rebase your code on top of the apache
master? I don't see, for example, config_parser.js anymore. It was renamed plus
there ar
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-cli/pull/144
CB-6308 WP8. Add Splash Screen img support via config.xml preference
https://issues.apache.org/jira/browse/CB-6308
Adds support of 'SplashScreen' preferen
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-cli/pull/145
Splash screen support via config.xml for WP8 and Windows8
https://issues.apache.org/jira/browse/CB-6308
https://issues.apache.org/jira/browse/CB-6309
Adds support of 'SplashS
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-cli/pull/144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-cli/pull/144#issuecomment-38037852
Created single pull request for both WP8 and Windows8
https://github.com/apache/cordova-cli/pull/145
---
If your project is set up for it, you can reply to
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/32
default windows.open functionality fallback on Ripple
Ripple emulator does not support InAppBrowser functionality. Added fallback
to standard window.open that works.
You can
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-cli/pull/145#issuecomment-38566101
I'm not sure it could be resolved in runtime since the app will show
default splash screen before we can change anything. So there are three options
here:
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/33#issuecomment-39089517
I believe we have ID_CAP_NETWORKING by default
https://github.com/apache/cordova-wp8/blob/master/wp8/template/Properties/WMAppManifest.xml#L11
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-docs/pull/201
CB-2606 Documented icon usage
1. iOS, Andoroid, FirefoxOS, Windows8, WP8
2. Related PR with support https://github.com/apache/cordova-cli/pull/126
You can merge this pull request into a
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/201#discussion_r11249330
--- Diff: docs/en/edge/config_ref/images.md ---
@@ -26,45 +26,76 @@ SDK tools (detailed in the Platform Guides).
## Configuring Icons in the
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-windows/pull/20
CB-6397 [windows8] Use the latest version of MSBuild Tools installed
https://issues.apache.org/jira/browse/CB-6397
You can merge this pull request into a Git repository by running
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugman/pull/70
CB-6178 Plugman does not cache downloaded plugins
https://issues.apache.org/jira/browse/CB-6178
You can merge this pull request into a Git repository by running:
$ git pull https
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-cli/pull/126#issuecomment-39694176
Something goes wrong with this branch and the pull request. Our commits
must be on top of apache/master head. Right now there is unrelated work here.
As
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-cli/pull/140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-cli/pull/141
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-cli/pull/141#issuecomment-39746136
Better fix is here: https://github.com/apache/cordova-windows/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-cli/pull/140#issuecomment-39746169
Better fix is here: https://github.com/apache/cordova-windows/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/24#issuecomment-39879128
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-cli/pull/160
CB-6432 pre_package hook does not populate %CORDOVA_PLATFORMS%
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-cli CB
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/161#discussion_r11501013
--- Diff: src/superspawn.js ---
@@ -67,11 +69,11 @@ exports.spawn = function(cmd, args, opts) {
var spawnOpts = {};
var d = Q.defer
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/161#discussion_r11502884
--- Diff: src/superspawn.js ---
@@ -67,11 +69,11 @@ exports.spawn = function(cmd, args, opts) {
var spawnOpts = {};
var d = Q.defer
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/161#discussion_r11523476
--- Diff: src/superspawn.js ---
@@ -24,6 +24,8 @@ var _ = require('underscore');
var Q = require('q');
var shel
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/161#discussion_r11523494
--- Diff: src/superspawn.js ---
@@ -24,6 +24,8 @@ var _ = require('underscore');
var Q = require('q');
var shel
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/161#discussion_r11533344
--- Diff: src/superspawn.js ---
@@ -24,6 +24,8 @@ var _ = require('underscore');
var Q = require('q');
var shel
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/161#discussion_r11559369
--- Diff: src/superspawn.js ---
@@ -67,14 +68,18 @@ exports.spawn = function(cmd, args, opts) {
var spawnOpts = {};
var d = Q.defer
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-cli/pull/161#issuecomment-40355369
LGTM + Tested.
I think we should accept the changes and then look on the following
improvements:
1. The line below is very complex to read
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-cli/pull/161#issuecomment-40365473
@bryanhiggins thx!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-cli/pull/166
CB-2606 Icons support for iOS, Android, BB10, WP8, Win8, FxOS
Based on original version and PR made by @AxelNennker:
https://github.com/apache/cordova-cli/pull/126
The following
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-cli/pull/126#issuecomment-40769236
Hi @AxelNennker, I'm just trying to get this merged ASAP so I've opened a
separate PR which constants the same changes but re-based and could be merged.
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-windows/pull/27
CB-6266 Windows8. Add Whitelisting rules support from config file
Removes default template setting which always allows everything.
https://issues.apache.org/jira/browse/CB-6266
You can
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugman/pull/74
adds plugin level hooks support
1.Support of **js script files only** (nodejs is used to run script file)
2.Support of the following **hook types**
* beforeinstall
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/40
CB-6474 InAppBrowser. Add data urls support to WP8
https://issues.apache.org/jira/browse/CB-6474
You can merge this pull request into a Git repository by running:
$ git
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugman/pull/74#issuecomment-40968416
Created issue CB-6481 to cover this work.
Switched to nodejs module loader.
Sample hook file implementation with async functionality:
```
var
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/41
CB-6482 InAppBrowser calls incorrect callback on WP8
https://issues.apache.org/jira/browse/CB-6482
You can merge this pull request into a Git repository by running:
$ git
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/18
CB-6483 Use splash screen image from manifest on Windows8
https://issues.apache.org/jira/browse/CB-6483
You can merge this pull request into a Git repository by running
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-41175017
Seems we are good now. @purplecabbage, @shazron is there anything else
required before we can merge this?
---
If your project is set up for it, you
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-41418136
I've added minor update to WP8 code to populate 'photos' fields. This
functionality was missing.
---
If your project is set up for it
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-cli/pull/166#issuecomment-41706403
Merged here, closing..
https://github.com/apache/cordova-cli/commit/bc86dc6d9d308b09a2161bc8e3629020c79bb1ed
---
If your project is set up for it, you can
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-cli/pull/166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugman/pull/74#issuecomment-41850345
Switched to single parameter called context
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugman/pull/74#issuecomment-41967514
@agrieve, thx for review; updated the code. Also did rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12257679
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,148 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12257681
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,148 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12257686
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,148 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugman/pull/74#issuecomment-42234483
Totally agree, will do as soon as cordova-lib work is stabilized so I can
move the code to appropriate repo and perform final tests. @ligaz, thx for
review
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-windows/pull/29
CB-6660 "[Windows] Remove windows7 template"
https://issues.apache.org/jira/browse/CB-6660
You can merge this pull request into a Git repository by running:
$ git
GitHub user sgrebnov opened a pull request:
https://github.com/apache/incubator-cordova-weinre/pull/12
Windows phone support (core functionality)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sgrebnov/incubator-cordova-weinre
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-wp8/pull/33
CB-6685 [3.5.0rc][WP8] Build error: Command failed with exit code 2
https://issues.apache.org/jira/browse/CB-6685
You can merge this pull request into a Git repository by running:
$ git
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-windows/pull/30
CB-6684 [3.5.0rc][Windows8] Splash screen setting breaks the build
https://issues.apache.org/jira/browse/CB-6684
1. Copies image instead of changing reference - this is correct way
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/27#issuecomment-43029614
Actually it looks strange, that we always have access origin=* on windows8
and wp8, for example, if I change main config.xml and replace * with some real
domain
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-plugin-device-orientation/pull/6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-windows/pull/31
CB-6686 [3.5.0rc][Windows8] Build error if path contains whitespaces
https://issues.apache.org/jira/browse/CB-6686
You can merge this pull request into a Git repository by running
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/27#issuecomment-43030700
Agree, default configuration is correct so closing this... But still think
that something is broken in prepare step since we shouldn't get redundant
valu
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-wp8/pull/34
CB-6341 Remove windows requirement to have MSBuild in the %PATH%
https://issues.apache.org/jira/browse/CB-6341
You can merge this pull request into a Git repository by running:
$ git pull
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-windows/pull/27
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-docs/pull/201
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-plugman/pull/74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugman/pull/74#issuecomment-43280272
Moved to appropriate repo, closing...
https://github.com/apache/cordova-lib/pull/12
---
If your project is set up for it, you can reply to this email and
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-wp8/pull/36
CB-6732 [WP8] Fix "MSBuild 64 bit is not supported" build error
https://issues.apache.org/jira/browse/CB-6732
Added fix based on process bitness check and exciting appropr
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-44281909
Is there any work left here before we can merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-44455699
Thx @purplecabbage . I've tested merged version and confirm it works
correct on Android, iOS, WP8, Windows8,
---
If your project is set up for it
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-cli/pull/126#issuecomment-46151067
Pls take a look
[here](https://github.com/apache/cordova-plugin-splashscreen/blob/master/doc/index.md#android-quirks_)
and
[here](http://docs.phonegap.com/en
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46158371
The usage LGTM. But does current implementation remove all default cordova
splash screen images if there is no splash element defined?
Also, on Android icons and
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46166927
@AxelNennker, thx for the clarification!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-lib/pull/31
CB-6954 Share events.js between cordova and plugman
https://issues.apache.org/jira/browse/CB-6954
You can merge this pull request into a Git repository by running:
$ git pull https
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-medic/pull/11#issuecomment-46406000
+1, LGTM, tested on Windows and OS slaves
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-lib/pull/32
CB-6970 Share win project files manipulation code between cordova and
plugman
https://issues.apache.org/jira/browse/CB-6970
1. Shared csproj and jsproj classes
2. Updated code to
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/20#issuecomment-46532850
+1 and thx! @nadyaA could you pls update your fix by adding the same change
to show() method as well.
---
If your project is set up for it, you
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/20#issuecomment-46556623
Merged, thx for the fix. Pls close PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/30#issuecomment-46646255
Could we also incorporate the following PR to this one before merge? It
adds splash images support for iOS, WP8 and Windows8.
https://github.com/AxelNennker
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-cli/pull/180
CB-6728 Support chip architecture
https://issues.apache.org/jira/browse/CB-6728
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-windows/pull/35
CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP 8.1)
https://issues.apache.org/jira/browse/CB-6976
* Renamed windows8 platform to windows.
* Windows
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-lib/pull/39
CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP 8.1)
https://issues.apache.org/jira/browse/CB-6976
* Added new windows platform
* New platform can detect and
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-cli/pull/181
CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP 8.1)
https://issues.apache.org/jira/browse/CB-6976
* Allow using new windows alias to work with old windows8
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/181#discussion_r14055705
--- Diff: src/cli.js ---
@@ -165,6 +165,20 @@ function cli(inputArgs) {
throw new CordovaError(msg
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-cli/pull/181#issuecomment-46787820
@kamrik, @purplecabbage thx for review and notes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/39#discussion_r14055722
--- Diff: cordova-lib/src/cordova/lazy_load.js ---
@@ -75,6 +75,10 @@ function cordova_git(platform) {
}
var url = platforms
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/39#discussion_r14055725
--- Diff: cordova-lib/src/cordova/platforms.js ---
@@ -69,10 +69,17 @@ module.exports = {
},
'windows8':{
hostos
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/39#discussion_r14055726
--- Diff: cordova-lib/src/cordova/platforms.js ---
@@ -69,10 +69,17 @@ module.exports = {
},
'windows8':{
hostos
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-lib/pull/41
disables CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP
8.1)
We should not include this functionality until new Windows platform is
released. It is better to enable this
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-cli/pull/182
disables CB-6976 Add support for Windows Universal apps (Windows 8.1 and WP
8.1)
We should not include this functionality until new Windows platform is
released. It is better to enable this
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-lib/pull/41
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-cli/pull/182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-lib/pull/43
Reverts CB-6976 Add support for Windows Universal apps
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib master
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-cli/pull/183
Reverts CB-6976 Add support for Windows Universal apps
Requires to not break upcoming CLI and LIB release. This will be added back
and released along with of 3.6.0.
You can merge this pull
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/32
fixes CB-7003 navigator.contacts.pickContact picks wrong contact on Android
4.3 and 4.4.3 versions
https://issues.apache.org/jira/browse/CB-7003
pickContact: added logic
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-lib/pull/12#issuecomment-47623059
New plugin hooks implementation is coming...closing this one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-lib/pull/12
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-wp8/pull/43
CB-7060 WP8. Fix large project build performance issue
https://issues.apache.org/jira/browse/CB-7060
You can merge this pull request into a Git repository by running:
$ git pull https
Github user sgrebnov closed the pull request at:
https://github.com/apache/cordova-plugin-contacts/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/32#issuecomment-47791107
Verified merged version, works correct, closing..
---
If your project is set up for it, you can reply to this email and have your
reply appear on
1 - 100 of 483 matches
Mail list logo
