GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-browser/pull/6
CB-8206: Browser platform: Add support for update
This change add supports for updating the browser platform. I ended up
deleting a couple of log messages from create as there is no way to
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22905021
--- Diff: bin/lib/create.js ---
@@ -26,14 +26,11 @@ var fs = require('fs'),
ROOT= path.join(__dirname, '..', '
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22905187
--- Diff: bin/lib/update.js ---
@@ -0,0 +1,59 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22911133
--- Diff: node_modules/.bin/shjs ---
@@ -1 +1,15 @@
-../shelljs/bin/shjs
--- End diff --
This is done automagically by node on
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r22961441
--- Diff: node_modules/.bin/shjs ---
@@ -1 +1,15 @@
-../shelljs/bin/shjs
--- End diff --
Good question @mmocny and you're no
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-browser/pull/6#issuecomment-70004026
@jsoref Thanks for reviewing this and the instructions for doing the git
magic. It was useful. I have made the changes that you requested.
---
If your project
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-wp8/pull/70
CB-8310: Fix to cordova run wp8 to attempt to deploy to device before it...
This change makes the cordova run wp8 behavior similar to Android. It
attempts to deploy to device before trying the
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-browser/pull/8
CB-8224: Add support to launch a specified browser using --target switch...
With this change there is support for multiple browsers on Windows, Mac and
Linux. I have tried my best to keep
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-browser/pull/6#issuecomment-71106847
Looking for anyone who can review this and commit it? It's quite a simple
change.
---
If your project is set up for it, you can reply to this email and
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r23417160
--- Diff: bin/lib/create.js ---
@@ -75,7 +69,7 @@ exports.createProject =
function(project_path,package_name,project_name){
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/6#discussion_r23417228
--- Diff: bin/update ---
@@ -0,0 +1,33 @@
+#!/usr/bin/env node
+
+/*
+ Licensed to the Apache Software Foundation (ASF) under
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-browser/pull/6#issuecomment-71115226
@jsoref Your comments have been addressed.
I will wait for someone else to review this. A checklist would be great -
looks like there is a doc here
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-browser/pull/6#issuecomment-71228160
@jsoref Updated the commit message. Please review and help merge to master.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-browser/pull/8#issuecomment-71756729
I rebased and updated this change. I would love someone to review this.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-browser/pull/8#issuecomment-72233705
@stevengill I noticed you have made some changes in this area. Wondering
if you can help review this?
---
If your project is set up for it, you can reply to
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/9
CB-8388 Prevent Windows app from crashing on test failure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/10#discussion_r24058292
--- Diff: www/medic.js ---
@@ -35,30 +35,27 @@ exports.log = function() {
};
exports.load = function (callback
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/10#issuecomment-72810379
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/44
CB-8428 Fix multiple `done()` calls in media plugin test
This shows up as an issue on Windows when audio device is not configured
correctly and an exception happens.
You can merge
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/30#issuecomment-72979743
@purplecabbage - Can you please commit this? This is breaking our medic
setup.
---
If your project is set up for it, you can reply to this email and
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/30
Fixes a syntax error introduced in 1a13ee0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-device
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-medic/pull/26
Re-direct output of removing working directory task
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-medic redirect
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-medic/pull/27
Re-direct output of removing working directory task
I had a bug in my previous commit for this that I had updated on my local
git but forgot to push. The issue is that rm.txt is getting
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-medic/pull/28
Fix Windows suspension issue and print summary of failing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-medic
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-coho/pull/62#issuecomment-73772237
@sgrebnov Can you please help review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-android/pull/155
CB-8500 Change gradle siging property names to be the same as Ant
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-docs/pull/267
CB-8500 Documentation update for singing property name change
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs CB
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/155#issuecomment-74747690
@agrieve @clelland Can you please take a look at this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/155#issuecomment-74758224
@jsoref Fixed - good catch!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-android/pull/159
CB 8520 - Simple fix for extra args being added twice for build command
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/59#issuecomment-75305927
This looks good! @sgrebnov Can you please help merge this one? It will be
good to have this in the next cordova-windows release.
---
If your project is set up
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-wp8/pull/76#discussion_r25098154
--- Diff: template/cordova/lib/build.js ---
@@ -68,6 +70,40 @@ module.exports.run = function (argv) {
}
return
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/170#discussion_r25184230
--- Diff: cordova-lib/src/cordova/platform_metadata.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/34#discussion_r25405334
--- Diff: src/utils/createMedicJson.js ---
@@ -0,0 +1,16 @@
+// /usr/bin/env node
+/*jshint node: true*/
+
+var fs = require
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r25831848
--- Diff: cordova-lib/src/cordova/project_metadata.js ---
@@ -0,0 +1,60 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r25831932
--- Diff: cordova-lib/src/cordova/project_metadata.js ---
@@ -0,0 +1,60 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/177#issuecomment-77288127
Looks like your new tests are timing out and you might need to increase the
timeout value.
---
If your project is set up for it, you can reply to this email and
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r25840412
--- Diff: cordova-lib/src/cordova/project_metadata.js ---
@@ -0,0 +1,60 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-medic/pull/36#issuecomment-77603929
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26008103
--- Diff: bin/checkout.js ---
@@ -0,0 +1,53 @@
+#!/usr/bin/env node
+
+// node dependencies
+var fs = require(&#x
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26008134
--- Diff: bin/checkout.js ---
@@ -0,0 +1,53 @@
+#!/usr/bin/env node
+
+// node dependencies
+var fs = require(&#x
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26008194
--- Diff: bin/prepareapp.js ---
@@ -0,0 +1,267 @@
+#!/usr/bin/env node
+
--- End diff --
Where is this file being used? Is it
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26008224
--- Diff: buildbot-conf/cordova-repos.json ---
@@ -0,0 +1,452 @@
+{
+"mobile-chrome-apps": {
+"code
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26008228
--- Diff: buildbot-conf/cordova-repos.json ---
@@ -0,0 +1,452 @@
+{
+"mobile-chrome-apps": {
+"code
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26008292
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,326 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26008317
--- Diff: cordova-plugin-medic/www/jasmine-jsreporter.js ---
@@ -1,214 +0,0 @@
-/*
- This file is part of the Jasmine JSReporter project from
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-medic/pull/37#issuecomment-0557
Some minor comments - mostly looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/179#issuecomment-77905654
Can we add tests for this scenario? This looks like a regression and there
is not test coverage for this scenario.
---
If your project is set up for it, you can
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26058485
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -134,7 +135,7 @@ module.exports = function plugin(command, targets,
opts
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26082685
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -284,6 +284,11 @@ module.exports = function plugin(command, targets,
opts
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/177#issuecomment-78115338
I noticed that the plugin metadata that is exposed is the id and version
number. What if the source is a git URL - how is that exposed?
---
If your project is set
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r26150341
--- Diff: cordova-lib/spec-cordova/project-metadata-apis.spec.js ---
@@ -0,0 +1,85 @@
+/**
+Licensed to the Apache Software Foundation (ASF
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r26152050
--- Diff: cordova-lib/src/cordova/project_metadata.js ---
@@ -0,0 +1,64 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/177#discussion_r26152048
--- Diff: cordova-lib/src/cordova/project_metadata.js ---
@@ -0,0 +1,64 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/181#issuecomment-78145771
Please close this PR if #182 supersedes this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/69#discussion_r26153526
--- Diff: tests/tests.js ---
@@ -305,7 +306,17 @@ exports.defineAutoTests = function () {
// - 'htt
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/184#issuecomment-78815446
@vladimir-kotikov Can you please help review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-wp8/pull/72#issuecomment-79535726
@brodybits - We'll start a new release soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/35#issuecomment-82107826
@vladimir-kotikov Can you please review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/123#issuecomment-82486029
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-android/pull/164
CB-8484: Adds support creating signed archives for Android
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-android
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-js/pull/104#issuecomment-82634302
Do you know why appveyor tests are failing? It does not look related to
your change.
---
If your project is set up for it, you can reply to this email and have
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-js/pull/104#issuecomment-82635278
Looks like they have not been passing for a while? Is there a JIRA for
this? Failing tests are noise.
---
If your project is set up for it, you can reply to this
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-js/pull/106#issuecomment-83307408
Thanks for fixing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/commit/fc5bc7a18d1b733c5c72a38e65357fdb2050c6fd#commitcomment-10349511
In cordova-lib/spec-cordova/Projects/ProjectMetadata/config.xml:
In cordova-lib/spec-cordova/Projects/ProjectMetadata
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/commit/fc5bc7a18d1b733c5c72a38e65357fdb2050c6fd#commitcomment-10349697
In cordova-lib/src/cordova/project_metadata.js:
In cordova-lib/src/cordova/project_metadata.js on line 36:
Promise
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/commit/fc5bc7a18d1b733c5c72a38e65357fdb2050c6fd#commitcomment-10349739
In cordova-lib/spec-cordova/project-metadata-apis.spec.js:
In cordova-lib/spec-cordova/project-metadata-apis.spec.js on
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/commit/fc5bc7a18d1b733c5c72a38e65357fdb2050c6fd#commitcomment-10349744
In cordova-lib/spec-cordova/project-metadata-apis.spec.js:
In cordova-lib/spec-cordova/project-metadata-apis.spec.js on
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/177#issuecomment-86228108
This PR needs to be closed as it is a dup of #191.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27259466
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +477,15 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27267568
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -530,8 +589,60 @@ module.exports.findBestApkForArchitecture =
function(buildResults, arch
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27267702
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -542,5 +653,12 @@ module.exports.help = function() {
console.log('\'--v
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/177#issuecomment-86994521
Yes, #191 subsumes this PR. I believe @omefire is on vacation and he will
be able to close this when he's back.
---
If your project is set up for it, yo
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/187#issuecomment-86999644
@purplecabbage. Yes, this one's ready to go! Please help commit this one
and close this PR! :bow:
---
If your project is set up for it, you can reply to
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/187#issuecomment-87097870
Thanks, @purplecabbage ! There is a corresponding update to docs here that
needs someone to commit it: https://github.com/apache/cordova-docs/pull/270
---
If your
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#issuecomment-87098082
@vladimir-kotikov @sgrebnov Can you please review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27418136
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -409,7 +442,29 @@ function parseOpts(options, resolvedTarget) {
console.warn
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27431999
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +477,15 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-87853461
@agrieve I have finished addressing your code review feedback. Can you
please take another look?
---
If your project is set up for it, you can reply to this
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27445900
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -402,6 +440,16 @@ function parseOpts(options, resolvedTarget) {
case
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446318
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -297,6 +320,14 @@ var builders = {
var distributionUrl =
'distributi
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446661
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -409,7 +457,31 @@ function parseOpts(options, resolvedTarget) {
console.warn
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446655
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -409,7 +457,31 @@ function parseOpts(options, resolvedTarget) {
console.warn
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446698
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -530,8 +609,54 @@ module.exports.findBestApkForArchitecture =
function(buildResults, arch
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446835
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -372,6 +409,7 @@ function parseOpts(options, resolvedTarget) {
if
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-88241394
@agrieve I have resolved all the code review comments. Let me know if this
is ready - I can rebase this to make it ready for merge.
---
If your project is set
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27588457
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -402,6 +440,16 @@ function parseOpts(options, resolvedTarget) {
case
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27589905
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -360,9 +391,15 @@ function parseOpts(options, resolvedTarget) {
var multiValueArgs
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27590209
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -402,6 +440,16 @@ function parseOpts(options, resolvedTarget) {
case
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27590810
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +500,18 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27592776
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +500,18 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-88589573
@agrieve Fixed last set of issues & rebased! This should be ready for a
merge.
---
If your project is set up for it, you can reply to this email and have
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-88634066
@agrieve Good catch - totally missed this one. Fixed now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-docs/pull/276
Document iOS specific callback for orientaion
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs iOS-Orientation
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/70#issuecomment-88651609
Can you please file a JIRA for this here - https://issues.apache.org/jira/
describing the scenario that fails?
---
If your project is set up for
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/276#issuecomment-88660515
This callback is *required* even if you do not want programmatic control.
By default, the webview will not cause a rotation as the iOS code expects a
callback to
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-88669613
Thanks, @agrieve ! :clap:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/276#issuecomment-88674908
config.xml does not support plist values to be set to landscape & portrait:
https://github.com/apache/cordova-lib/blob/8de97feba2fa883298eb9c99be0c425c7396
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/276#issuecomment-88679255
Thanks, @purplecabbage, Made the update to the docs commit and created a
JIRA to track the bug: https://issues.apache.org/jira/browse/CB-8783.
---
If your
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-docs/pull/277
CB-8484 Add documentation for signing apps for Android
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs
1 - 100 of 949 matches
Mail list logo
