GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-android/pull/139
--list support for android
For more details please check the dev mailing list and the [JIRA
issue](https://issues.apache.org/jira/browse/CB-8168)
You can merge this pull request into a
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-ios/pull/122
--list feature for iOS
For more details please check the dev mailing list and the [JIRA
issue](https://issues.apache.org/jira/browse/CB-8168)
You can merge this pull request into a Git
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-cli/pull/199
added --list support
For more details please check the dev mailing list and the [JIRA
issue](https://issues.apache.org/jira/browse/CB-8168)
You can merge this pull request into a Git
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-lib/pull/133
CB-8114 specify a cache-min-time
Currently there's no caching for plugins while platforms are cached for 1
day. The idea here is to match platform capabilities by setting min-cache
pro
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-cli/pull/205
CB-8168 --list support for CLI
Add list support back after the discussion on the dev mail list
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-lib/pull/145
CB-8168 --list support for cordova-lib
Add list support back after the discussion on the dev mail list
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-android/pull/147
CB-4914 Fix build whitespace issue
On Windows, when attempted to use the CLI to build an android project, if
the path contains spaces then the command fails. This currently only happens in
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/145#discussion_r22883426
--- Diff: cordova-lib/src/cordova/targets.js ---
@@ -0,0 +1,65 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-cli/pull/205#issuecomment-70330630
@jsoref please take a look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-lib/pull/153
CB-6973 Improving JSHint for src folder
Enforcing better JSHint coverage for src\* :
- Move base rules to src\.jshintrc
- Fix previously un-jshinted files
- Remove base rules from
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-lib/pull/154
CB-6973 enable JSHint for spec-cordova
This change enables jshint for spec-cordova meaning that `npm run jshint`
will not only check `src` folder but `spec-cordova` too. I've also fixe
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-lib/pull/154#issuecomment-71513921
Should be good to to go once tests are all green
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-coho/pull/62
CB-8375 Improve windows support for for-each
This improvement makes coho for-each work on Windows without issues.
You can merge this pull request into a Git repository by running:
$ git
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-lib/pull/157
CB-6973 Add spec-plugman to jshint
-Added the base rules for spec-plugman
-Fixed all the existing issues
-Make automation include spec-plugman
You can merge this pull request into a
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-windows/pull/57
CB-8400 enable jshint for windows platform
- Created a `npm run jshint` command & integrate into `npm run test`
- Created jshint rules files for spec and rest of the repo
- A
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-android/pull/153
CB-8410 enable jshint for Android platform
- Created a npm run jshint command & integrate into npm run test
- Created jshint rules files for spec and rest of the repo
- Fixed
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-wp8/pull/75
CB-8412
- Created a `npm run jshint` command & integrate into `npm run test`
- Created jshint rules files for spec and rest of the repo
- Added node_module jshint to repo
- F
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-wp8/pull/75#issuecomment-72776758
We were previously using sync exec with shelljs. Looks like it was causing
a time out as noted
[here](http://documentup.com/arturadib/shelljs#command-reference/exec
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-medic/pull/28#issuecomment-73110592
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-ios/pull/129
CB-8412 enable jshint for iOS platform
- Created a npm run jshint command & integrate into npm run test
- Created jshint rules files for spec and rest of the repo
- Fixed all js
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-wp8/pull/75#issuecomment-73194673
Turns out the build errors are unrelated. I'm seeing the following error on
Appveyor console:
`C:\Program Files
(x86)\MSBuild\Microsoft\WindowsPhone
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-wp8/pull/75#issuecomment-73196289
Hmm, who owns the test machine? I thought it was owned by infra, I couldn't
find a way to configure it. It currently doesnt have Silverlight installed but
looks
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-wp8/pull/75#issuecomment-73209662
On build 103 you can see this error message:
https://ci.appveyor.com/project/Humbedooh/cordova-wp8/build/1.0.103
In order to see the failure, you have to pipe
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-wp8/pull/75#issuecomment-73285130
Ahh, finally we're all green on AppVeyor :rocket:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-ios/pull/129#issuecomment-73285875
`node node_modules/jshint/bin/jshint bin && node
node_modules/jshint/bin/jshint tests` is passing. Failing tests are not related
to this PR
---
If your pr
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-ios/pull/129#issuecomment-73293570
Seems like an artifact. The original design changed and that checkin was
supposed to be reverted. I'll take a look
---
If your project is set up for it, yo
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-android/pull/154
testing travis please ignore
testing travis
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/muratsu/cordova-android patch-1
Github user muratsu closed the pull request at:
https://github.com/apache/cordova-android/pull/154
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-ios/pull/129#issuecomment-74336804
The issue is finally resolved - we can go forward with this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-ios/pull/129#issuecomment-74351002
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user muratsu closed the pull request at:
https://github.com/apache/cordova-ios/pull/129
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-android/pull/157
fix jshint errors
Looks like previous change
(https://github.com/apache/cordova-android/commit/db18e1480ee26f47c6cbb6763627d60b735c0167)
had some jshint issues..
You can merge this
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-windows/pull/59
CB-8515 Support DefaultLanguage selection for Windows
Cordova should set the appropriate project file attributes for Windows 8.0,
8.1, and Windows Phone 8.1 using the W3C widget spec
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-wp8/pull/76
CB-8516 Support DefaultLanguage selection for WP8
Cordova should set the appropriate project file attributes for WP 8.0 using
the W3C widget spec "defaultlocale" attribute.
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-windows/pull/59#issuecomment-75235633
if no locale is not found it uses the current default language which is
en-us. Since that is already hardcoded in proj files I'm not re-setting it.
rem
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-windows/pull/59#issuecomment-75298546
I'll fix the default locale to en-US. When a defaultlocale is not present
we should set it to en-US. Good catch!
---
If your project is set up for it, yo
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-wp8/pull/76#issuecomment-75305949
We actually don't want to merge this right now. Let's hold on until I
review how winpho8 locale works.
---
If your project is set up for it, you can rep
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/72
CB-8599 fix threading issue with cameraPicker
Fixes the issue where cameraPicker is trying to modify the main thread UI
from a background thread.
You can merge this pull request into
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/69#discussion_r26139904
--- Diff: tests/tests.js ---
@@ -305,7 +306,17 @@ exports.defineAutoTests = function () {
// - 'htt
Github user muratsu closed the pull request at:
https://github.com/apache/cordova-wp8/pull/76
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/48
CB-8686 - remove musicLibrary capability
Media plugin by default requests musicLibrary capability but it's not using
it. It should be removed since, it's not required.
You
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/35
CB-8687 consolidate manifest targets
Target manifests are listed for phone, windows and windows80 separately.
Consolidate them and use a single package.appxmanifest target
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/78
CB-8706, CB-8707 saveToPhotoAlbum improvements and some refactoring
- On Windows we should use filePicker instead of programmatically accessing
user libs. This way the app doesnt have
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-lib/pull/201
CB-8791 Recognize UAP as a valid TargetPlatformIdentifier
On jsprojManager.js we currently don't have UAP as
TargetPlatformIdentifier. We should have UAP as a TargetPlatformIdentifie
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744001
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744649
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744642
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744665
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744681
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744671
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744687
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#discussion_r27744691
--- Diff: src/windows/CameraProxy.js ---
@@ -43,399 +43,468 @@ module.exports = {
// 11 cameraDirection:0
takePicture
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/81#issuecomment-90293689
LGTM.
This also potentially fixes perf issues we have with
[CB-8542](https://issues.apache.org/jira/browse/CB-8542).
@shazron thoughts
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/78#issuecomment-90293828
@vladimir-kotikov @sgrebnov ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-ios/pull/137#issuecomment-93073824
:+1: :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-docs/pull/278
typo fix tools.md
small typo :lipstick:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/muratsu/cordova-docs patch-1
Alternatively you
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/86
CB-8054 Support taking pictures from file for WP8
Add missing take picture from file capability for WP8
You can merge this pull request into a Git repository by running:
$ git
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/86#issuecomment-93788932
The docs didn't mention this as a quirk, so no doc updates.
I've also updated the phone video codec list.
---
If your project is set up f
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/87
CB-8405 Use z-index instead of z-order
There's no css property such as z-order, use z-index instead.
You can merge this pull request into a Git repository by running:
$ git
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/88
CB-8404 Rotate camera feed with device orientation
Fixed 2 bugs in windows where we have trouble rotating the image on preview
and saving
You can merge this pull request into a Git
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/86#issuecomment-94503319
This one is ready to be merged. Would be glad if someone can merge this in.
---
If your project is set up for it, you can reply to this email and have
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/88#issuecomment-94889877
Rebased and squashed - ready to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/89
typo fix cameraproxy.js
There was a missing comma on cameraproxy
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/muratsu/cordova
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/127
CB-8927 Add media to cspMeta and Windows as plat
Fixes CSP errors on media test.
Addes CSPs for Windows platform
You can merge this pull request into a Git repository by running
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/47#discussion_r29369904
--- Diff: bin/lib/couchdb.js ---
@@ -0,0 +1,151 @@
+
+/*
+Copyright (c) 2012 Adobe Systems Incorporated. All rights reserved
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/47#discussion_r29369965
--- Diff: bin/lib/couchdb.js ---
@@ -0,0 +1,151 @@
+
+/*
+Copyright (c) 2012 Adobe Systems Incorporated. All rights reserved
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/47#discussion_r29370417
--- Diff: bin/lib/testcheck.js ---
@@ -0,0 +1,77 @@
+var http = require('http'),
+url = require('url'),
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-coho/pull/73
CB-8949 Update request module
Updated the request module we're using
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/co
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-coho/pull/74
CB-8950 Add NSP to travis
-Enable travis
-Add nsp to travis
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-coho CB
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-windows/pull/75
CB-8486 Support for signing and build.json for Windows
Related JIRA item:
https://issues.apache.org/jira/browse/CB-8483
Details of the design and scenario here:
https
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-coho/pull/77
Update setting-up-gpg.md
Add --keyserver for gnupg
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/muratsu/cordova-coho patch-1
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/92
CB-8943 fix PickAndContinue issue on Win10Phone
-fix PickAndContinue issue on WindowsPhone 10
-fix emulator not correctly taking pictures WindowsPhone 8.1
-change default save
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/73#issuecomment-99581264
Most of this functionality is in Camera now. I think you can close this PR.
---
If your project is set up for it, you can reply to this email and have
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-docs/pull/288
CB-8486 docs for windows packaging
Documentation for Windows packaging.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/94
CB-8879 fix stripe issue with correct aspect ratio
This fixes the stripe issue we had on windows phone 8+.
The fix was to set up resolutions with a common aspect ratio. Default
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/94#discussion_r30262108
--- Diff: src/windows/CameraProxy.js ---
@@ -337,28 +336,48 @@ function takePictureFromCameraWP(successCallback,
errorCallback, args
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/94#discussion_r30262317
--- Diff: src/windows/CameraProxy.js ---
@@ -438,6 +457,61 @@ function takePictureFromCameraWP(successCallback,
errorCallback, args
Github user muratsu closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/94
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/95
CB-8883 fix picture rotation issue
Improved the logic for camera/sensor rotation and adressed the camera
issues.
You can merge this pull request into a Git repository by running
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-docs/pull/290
CB-8486 improve packaging docs
Improved the docs for windows packaging by giving some example
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-windows/pull/78
CB-9045 Create a new solution for Win10/Dev15
Currently in dev12 solution we're using shared project. The shared project
has some logic that doesn't work with windows10 projects
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-windows/pull/78#issuecomment-103681444
UAP and SharedProj dont play nice on VisualStudio13. My understanding is,
in order to have backwards compat we need to split UAP from SharedProj. This
provides
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-windows/pull/78#issuecomment-103709357
Hmm you're right on seperation of concerns. Having a new solution file
isn't really a good solution to this problem. I think I have a workaround that
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/78#discussion_r30723083
--- Diff: template/CordovaApp.Windows10.jsproj ---
@@ -86,12 +93,11 @@
-
-
+
--- End
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/96#discussion_r30757436
--- Diff: src/windows/CameraProxy.js ---
@@ -546,20 +575,31 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, args
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/96#discussion_r30757496
--- Diff: src/windows/CameraProxy.js ---
@@ -111,8 +127,8 @@ function resizeImage(successCallback, errorCallback,
file, targetWidth, targetHe
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/96#discussion_r30757483
--- Diff: src/windows/CameraProxy.js ---
@@ -69,11 +83,13 @@ function resizeImage(successCallback, errorCallback,
file, targetWidth, targetHe
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/96#issuecomment-104064883
:shipit: looks awesome thanks for doing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-windows/pull/82
CB-9059 removed targetingWin10 logic from prepare
Removes isTargetingWin10 logic and fails silently in case system does not
have UAP tools installed.
You can merge this pull request into a
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-lib/pull/225#issuecomment-104789786
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/86#issuecomment-105584955
Yes, this is resolved for windows phone universal.
What problem are you running into with winphone8? You can always open a
[jira](https
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/86#issuecomment-105598275
Make sure you've version 1.1.0 (May 06, 2015). You can check installed
plugin version by executing `cordova plugin` on your project root.
---
If
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/86#issuecomment-105603159
You can get the latest (edge) from
[github](https://github.com/apache/cordova-plugin-camera.git) however I suggest
you clone the github repo and checkout
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/86#issuecomment-105752108
That just got fixed today. Please update :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/100
Update docs
Update docs to enhance reading experience
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/84#issuecomment-106874924
@antonellopasella if you can edit your text I can merge it, thanks
---
If your project is set up for it, you can reply to this email and have your
reply
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/77#issuecomment-106875324
@biodiv can you please squash and rebase it? There have been many changes
on the Windows side, I would love to get this checked.
---
If your project is
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/82#discussion_r31345599
--- Diff: src/list-pulls.js ---
@@ -23,7 +23,9 @@ var apputil = require('./apputil');
var flagutil = require('./flagutil'
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-windows/pull/89
CB-9097 fail with a more descriptive error if run as admin
`cordova run` will fail for windows if invoked from admin prompt. Currently
we will wait until ActivateApplication stage and fail
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-coho/pull/82#issuecomment-106893231
LGTM :shipit:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
1 - 100 of 154 matches
Mail list logo
