[GitHub] cordova-plugin-wkwebview-engine pull request #11: CB-9888: (iOS) check & rel...

2016-06-13 Thread mccraigmccraig
GitHub user mccraigmccraig opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11 CB-9888: (iOS) check & reload WKWebView PR as discussed on JIRA @shazron ### Platforms affected iOS 9 ### What does this P

[GitHub] cordova-plugin-wkwebview-engine issue #11: CB-9888: (iOS) check & reload WKW...

2016-06-14 Thread mccraigmccraig
Github user mccraigmccraig commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11 like this ? do you need a new PR with squashed commits ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-wkwebview-engine issue #11: CB-9888: (iOS) check & reload WKW...

2016-07-11 Thread mccraigmccraig
Github user mccraigmccraig commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11 @pwbs you are presumably seeing crashes setting the title to `""` ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-wkwebview-engine issue #11: CB-9888: (iOS) check & reload WKW...

2016-07-11 Thread mccraigmccraig
Github user mccraigmccraig commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11 definitely it is weird - the test exists because the `webViewContentProcessDidTerminate` delegate function sometimes doesn't get called, which is presumably a b

[GitHub] cordova-plugin-wkwebview-engine issue #11: CB-9888: (iOS) check & reload WKW...

2016-07-11 Thread mccraigmccraig
Github user mccraigmccraig commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/11 yw, also, since absence of evidence is not evidence of absence :) , perhaps keep an eye out for WSOD recoveries matching your `==nil` test - there's the obvious r

[GitHub] cordova-plugin-wkwebview-engine issue #16: CB-11554 - too 'brutal' app reloa...

2016-08-30 Thread mccraigmccraig
Github user mccraigmccraig commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/16 that all looks reasonable - i'll start testing it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cordova-plugin-wkwebview-engine issue #16: CB-11554 - too 'brutal' app reloa...

2016-11-22 Thread mccraigmccraig
Github user mccraigmccraig commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/16 @pwbs i think i saw this once too - though i have never been able to reproduce it in an inspectable environment my first hypothesis would be that the WKWebView

[GitHub] cordova-plugin-wkwebview-engine issue #16: CB-11554 - too 'brutal' app reloa...

2016-11-23 Thread mccraigmccraig
Github user mccraigmccraig commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/16 hmm - that would seem to indicate that it is a different bug, or that the WSOD has some other URL than `about:blank` ? --- If your project is set up for it, you can

[GitHub] cordova-plugin-wkwebview-engine issue #16: CB-11554 - too 'brutal' app reloa...

2016-11-23 Thread mccraigmccraig
Github user mccraigmccraig commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/16 if it is `about:blank` that would mean one of 1. the `onAppWillEnterForeground` callback isn't firing 2. there is a bug in the `onAppWillEnterForeg

[GitHub] cordova-plugin-wkwebview-engine issue #16: CB-11554 - too 'brutal' app reloa...

2016-12-22 Thread mccraigmccraig
Github user mccraigmccraig commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/16 so that's pretty occasional then, which will make it hard to track down (i haven't seen WSOD at all recently) my approach when i first worked on t