GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/50
fix for CB-6872
This Pull Request fix CB-6872
the free space available wasn't returning the right value, so when you
request the file system with a high value it fails
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/17#issuecomment-58073188
line 46 should be
Obtiene la versión de cordova en el dispositivo.
---
If your project is set up for it, you can reply to this email and
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39
Fix CB-7734. Changed plugin to use UIAlertController on iOS 8
Changed plugin to use UIAlertController on iOS 8 and greater instead of
the UIAlertView as UIAlertView is
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-63144935
[UIAlertController class] doesn't crash on iOS 7 devices if you compile it
on xcode 6 using iOS 8 SDK.
I'm making the changes f
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-63145889
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/73#issuecomment-72804585
I think you can install it with:
cordova plugin add https://github.com/tgalal/cordova-plugin-inappbrowser.git
---
If your project is set up
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-86389973
I can't understand what this changes try to achieve. Looking at the code it
launchs an intent to open an external app if the url is defin
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91790210
That line fixes the too many words issue, but if it crashes on iOS 8.3 I'll
try to find another fix
---
If your project is set up for it, yo
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91824100
@shazron iOS 8.3 already fix the too many words issue, so, not sure how to
proceed here. Should we just expect everybody update their device and mark
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91827499
I've just found that the fix isn't working on iPhone/iPod touch when the
device is in landscape, I'm going to update the code again
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-93894696
No, I've just tried and doesn't work if I do it that way
(alertController.view.frame = [self invertFrameIfNeeded:[UIScreen
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94087108
You mean without all the code on my pull request or with the code on my
pull request removing this line:
alertController.view.frame = [[UIScreen
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94105276
I'm testing on Xcode 6.3 too, that's strange, can you test on a real device
with 8.1 or 8.2? can you test on a 8.1 simulator?
can yo
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94154670
If been looking into your test project and the last commented line should
be alertController.view.frame = alertFrame; not alertController.view.frame
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94396822
Don't merge it yet, I've just noticed that I'm comparing [[UIApplication
sharedApplication] statusBarOrientation] with UIDeviceOrie
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94505096
I've just added the changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-lib/pull/214#issuecomment-101019674
the discusion already started on the mail list
http://markmail.org/message/yx3pvydgyxpssgas
But it didnt get any conclusion
I still don'
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/36#issuecomment-103808749
Android geolocation plugin code doesn't exist anymore, it just uses the
HTML 5 geolocation API, so nothing has to be copied to the pla
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-111018380
using [[UIDevice currentDevice] orientation] is not reliable
maybe you can try with
[[UIApplication sharedApplication
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-113429801
Yeah, on iOS the user agent change applies to all the webviews, maybe it
should be restored after closing the inappbrowser
---
If your
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/108
CB-6190 - iOS camera plugin ignores quality parameter
CB-6190 - iOS camera plugin ignores quality parameter in some
circunstances
Added a check to not downscale if
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54
CB-9347 - fix to allow to stack multiple UIAlertControllers
Now you can stack multiple UIAlertControllers
I had to add a 0.5s delay in case the user tries to present a
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122194054
First of all, an issue is needed before merging this, create a new one here
http://issues.cordova.io/ and use the identifier you get on this pull
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/36#issuecomment-122512809
I think you should add to the readme that users with the app installed will
get the previous stored UUID instead of the identifierForVendor
---
If
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/29#issuecomment-122859132
can you please close this? You have opened a pull request
If you have problem using the plugin ask on stackoverflow or the phonegap
google
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126205747
Hi, I told you on the JIRA page that I could reproduce the preference being
duplicated, but I couldn't reproduce your problem, in my tes
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126208513
Ok, I'll take a look, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126413242
It happens even without adding a plugin, if you put one of the default
preferences with another value, both will show (see CB-9264)
---
If your
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126475712
Sorry, I proposed this change because I didn't know the reason for the
default preferences. I'm closing CB-9076 now.
Plea
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126487866
BTW, I checked what you commented about the default value not being the
first one, and it isn't the first one when you add the platform, b
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/127#issuecomment-126644090
I agree with @macdonst that setting the "AndroidPersistentFileLocation"
preference to "Compatibility" should be enough if the dev
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/55#issuecomment-127889230
Tested on iOS, seems good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/commit/07b55b752960e66ca4d0ba33b9c49d41b7241b43#commitcomment-12853928
And there is already an issue for that bug and has been fixed, but the last
plugin release was in june
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/117#issuecomment-135329615
I think, everything you put after [self.pickerController
dismissViewControllerAnimated:NO completion:nil]; should be on the completion
block
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/57#issuecomment-138215304
There is already a pull request for other issue that fixes this problem too
https://github.com/apache/cordova-plugin-dialogs/pull/54
---
If
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-ios/pull/157#issuecomment-138280386
shouldn't the ```- (NSUInteger)application:(UIApplication*)application
supportedInterfaceOrientationsForWindow:(UIWindow*)window``` still be needed
for
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/114#issuecomment-139915054
Please, close this, you have created a pull request.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/57#issuecomment-141407647
If you are in a hurry you can use my fork installing from the git url
---
If your project is set up for it, you can reply to this email and have
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-ios/pull/132#issuecomment-141517225
Latest cordova (lib) version is 5.3.1, there is no cordova ios 4.3.0,
latest is 3.9.1
---
If your project is set up for it, you can reply to this email and
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-ios/pull/132#issuecomment-141524412
The problem is fixed, you have to update, you should read about cordova cli
and platform versions, cordova iOS 3.9.1 shouldn't break any plugin, cordova
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/35
CB-9250 Fix iOS warnings in Statusbar plugin
Changed UIDeviceOrientationIsLandscape(orientation) to
UIInterfaceOrientationIsLandscape([[UIApplication sharedApplication
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-142068241
Another pull request with all the iOS 7 warnings has been merged, this can
be closed
---
If your project is set up for it, you can reply to this
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/117#issuecomment-146120130
Please, close this, you created a pull request, pull requests are for
providing fixes, not for asking questions.
You can'
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/103#issuecomment-146336013
"If you are using iOS9 or have upgraded to Xcode7" should be "If you are
using iOS9 and have upgraded to Xcode7", ther
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/12#issuecomment-148635350
Read the quirks
Android Quirks
Android also uses the Crop Activity for allowEdit, even though crop should
work and actually pass the
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-149005887
-1 to adding new quirks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/57#issuecomment-149445535
should be fixed by https://github.com/apache/cordova-plugin-dialogs/pull/54
---
If your project is set up for it, you can reply to this email and
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-ios/pull/164#issuecomment-150188723
+1 for preference
BTW, I'm not able to reproduce the magnifier glass issue on iOS 9.1, maybe
apple fixed it?
---
If your project is set up f
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-docs/pull/400#issuecomment-150544323
I think you did something wrong
Files changed 19,185
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-ios/pull/164#issuecomment-150869787
I've tried on iPad 4, iPod touch 5 and iPhone 6 and the bug is gone on 9.1.
On the iPad and iPod tested the same app before updating (magnifying
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/38
Fixes CB-4712, CB-5439 statusbar issues
Fixes CB-4712, CB-5439 and hopefully all the statusbar issues related
to the size or resize of the cordova webview when the status
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/39#issuecomment-153362067
You are probably using an old version of cordova CLI that doesn't support
NPM
---
If your project is set up for it, you can reply to
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-153756910
I think we should discuss this change before merging, it's a big change and
add an ios "quirk". We recently rejected another pull r
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/38#issuecomment-154726855
I hope I did well, it was my first rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-156130089
When I say we I mean everybody, it's open source ;)
Start by sending an email to dev@cordova.apache.org proposing this new
featur
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-158220443
you updated from the github url? or just with a cordova plugin add
cordova-plugin-statusbar?
I suppose you did the latest, because the
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-158222576
Oh, sorry, I'm talking about iOS 7 deprecated warnings, not iOS 8 warnings
Anyway, I already told that [[UIDevice currentD
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/39
CB-10047 fix iOS 8 deprecated warnings
Removed all references to self.viewController.interfaceOrientation,
they werenât really used on invertFrameIfNeeded and are
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/40
CB-10047 fix iOS 8 deprecated warnings
Removed all references to self.viewController.interfaceOrientation,
they werenât really used on invertFrameIfNeeded and are
Github user jcesarmobile closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-158506196
I've sent the new pull request
https://github.com/apache/cordova-plugin-statusbar/pull/40
In fact, in the latest version on g
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/125#issuecomment-158564977
tested and working fine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-cli/pull/228#issuecomment-160755800
it should work since cordova cli 5.4.0, if something isn't working, please,
file an issue on issues.cordova.io
---
If your project is set up for it, yo
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/128#issuecomment-163585240
is it a pull request or you are just telling that you can not open link
with vertical bar(|)?
if it's a pull request, sync befo
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/125#issuecomment-163762500
@sgrebnov I assigned the issue to you as you did all the work, you have
merge permissions, right?
---
If your project is set up for it, you
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/41
CB-10047 fix iOS 8 deprecated warnings and CB-10102 wrong removeObserver
CB-10047
Removed all references to self.viewController.interfaceOrientation,
they werenât
Github user jcesarmobile closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/40
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/69#discussion_r48450551
--- Diff: src/ios/CDVSplashScreen.m ---
@@ -187,7 +187,35 @@ -
(NSString*)getImageName:(UIInterfaceOrientation)currentOrientation
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/69#discussion_r48450615
--- Diff: src/ios/CDVSplashScreen.m ---
@@ -187,7 +187,35 @@ -
(NSString*)getImageName:(UIInterfaceOrientation)currentOrientation
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/69#discussion_r48450641
--- Diff: src/ios/CDVSplashScreen.m ---
@@ -187,7 +187,35 @@ -
(NSString*)getImageName:(UIInterfaceOrientation)currentOrientation
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/69#issuecomment-167371442
Where do these prefixes come from? is that documented? I've found this
http://stackoverflow.com/questions/19107543/xcode-5-asset-catalog-h
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/69#issuecomment-167555343
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/134#issuecomment-171895107
That's what toolbar option makes on iOS
toolbar: set to yes or no to turn the toolbar on or off for the
InAppBrowser (defaults t
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/137
Fix for CB-10305
There are really 3 issues here.
1. When the inAppBrowser is started in portrait and rotates, the
background of the status bar doesnât fill the
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/45
Fix for CB-10102
The removeObserver code was wrong and it might crash on plugin
deallocation
You can merge this pull request into a Git repository by running:
$ git
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/136#issuecomment-173940439
@falkobuttler it has been reported
https://issues.apache.org/jira/browse/CB-10407
For now you can keep using the old version of the plugin
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/157#issuecomment-174537581
Is this a mistake? it seems that it only removes the L from License
---
If your project is set up for it, you can reply to this email and have your
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/42#issuecomment-176161967
Please, close this, you created a pull request.
This is not the place to ask questions
---
If your project is set up for it, you can reply to
Github user jcesarmobile closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/41
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-docs/pull/486#issuecomment-179853679
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-179891115
check the jira issue
https://issues.apache.org/jira/browse/CB-10269
Commit faa9d877045d8baf8afdfd0d8689389ec240e2e4 in
cordova
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/137#issuecomment-179898101
It fix 2 other things that affect iOS 8-9 too.
And don't we have to maintain support for 6 months after deprecating? (not
sure if
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/3#issuecomment-180077007
It's not on NPM yet, plugin releases take time.
Anybody using cordova can install from github, they don't have to wait fo
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-181897098
getTopPresentedViewController returns the view controller on the top, not
necessarily the mainViewController, the dialog has to be presented over
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-183218924
It's supposed to be recursive. If count > 1 it just stores it on the array
(line 100), then, once it's presented (line 230), removes
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/498#discussion_r52730725
--- Diff: www/docs/en/dev/guide/platforms/android/webview.md ---
@@ -29,106 +29,73 @@ components can communicate with each other, see
Application
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/498#discussion_r52730738
--- Diff: www/docs/en/dev/guide/platforms/android/webview.md ---
@@ -29,106 +29,73 @@ components can communicate with each other, see
Application
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/498#discussion_r52730740
--- Diff: www/docs/en/dev/guide/platforms/android/webview.md ---
@@ -29,106 +29,73 @@ components can communicate with each other, see
Application
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/498#discussion_r52730825
--- Diff: www/docs/en/dev/guide/platforms/android/webview.md ---
@@ -29,106 +29,73 @@ components can communicate with each other, see
Application
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/498#discussion_r52730788
--- Diff: www/docs/en/dev/guide/platforms/android/webview.md ---
@@ -29,106 +29,73 @@ components can communicate with each other, see
Application
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/498#discussion_r52730759
--- Diff: www/docs/en/dev/guide/platforms/android/webview.md ---
@@ -29,106 +29,73 @@ components can communicate with each other, see
Application
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/498#discussion_r52730771
--- Diff: www/docs/en/dev/guide/platforms/android/webview.md ---
@@ -29,106 +29,73 @@ components can communicate with each other, see
Application
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/498#discussion_r52730805
--- Diff: www/docs/en/dev/guide/platforms/android/webview.md ---
@@ -29,106 +29,73 @@ components can communicate with each other, see
Application
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/54#issuecomment-183466583
I've just send the PR.
https://github.com/phonegap/phonegap-plugin-barcodescanner/pull/170
---
If your project is set up for it, yo
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/150
Fixes CB-10607
When the device is in portrait upside down the toolbar appears at the
bottom. This fix set the origin to the 0,0 point
You can merge this pull request
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/82#issuecomment-184167577
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/44#issuecomment-184175201
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-docs/pull/498#issuecomment-185230674
I think this should be added too:
`@Override
public void onDestroy() {
if (this.webInterface!=null
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53225642
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -53,15 +48,13 @@ include all iPad® models, iPhone® 3GS and above, and
iPod® Touch
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/505#discussion_r53225665
--- Diff: www/docs/en/dev/guide/platforms/ios/index.md ---
@@ -53,15 +48,13 @@ include all iPad® models, iPhone® 3GS and above, and
iPod® Touch
1 - 100 of 354 matches
Mail list logo
