Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-152032481
Windows apps also have to deal with saving and restoring state like this in
at least some cases. See [MSDN - Guidelines for app suspend and
resume](https
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/144
Fix CB-9752: FileEntry.getDirectory fails with assets filesystem
Calls to FileEntry.getDirectory() on an asset entry would internally call
the AssetFileSystem.listAssets() method
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/145
CB-7253: requestFileSystem fails when no external storage is present
There were 2 issues behind this bug:
1) DirectoryManager.getFreeDiskSpace() used an incorrect way of
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/145#issuecomment-152657217
@infil00p or @riknoll can you review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/144#issuecomment-152657405
@infil00p or @riknoll can you review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/144#issuecomment-152661034
Oh, yeah "unit test" was probably not the right term.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-lib/pull/338
CB-9935: Cordova CLI silently fails on node.js v5
Cordova in a couple places was mis-using the Q.all() function from
the Q promises library. That function expects an array (of values or
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/338#issuecomment-153207374
@stevengill or @vladimir-kotikov can you review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/338#issuecomment-153210032
I forgot to mention: I searched the codebase for other calls to Q.all(),
and those 2 were the only places I found with this mistake; others are
correctly passing
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/146
Fix default persistent file location
The default Android persistent file location should be "internal", as
documented in the file plugin's README.md. The value was
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/146#issuecomment-153538034
@infil00p please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153920849
It looks like CB-9090 and CB-8257 are about exactly the same problem as
this CB-9887.
---
If your project is set up for it, you can reply to this email
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#discussion_r43965498
--- Diff: src/windows/FileProxy.js ---
@@ -168,6 +168,15 @@ WinFS.prototype.__format__ = function(fullPath) {
return 'cd
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/143#issuecomment-153923115
Sorry I mistyped... I meant to refer to CB-9020 not CB-9090.
I was thinking CB-8257 was referring to WP 8.1 (which uses the 'windows'
pl
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#discussion_r44084198
--- Diff: src/android/ContentFilesystem.java ---
@@ -18,22 +18,19 @@ Licensed to the Apache Software Foundation (ASF) under
one
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154226660
Looks good to me other than the minor style issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/135#discussion_r44093297
--- Diff: src/android/CameraLauncher.java ---
@@ -547,7 +547,7 @@ private String ouputModifiedBitmap(Bitmap bitmap, Uri
uri) throws
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/135#discussion_r44093710
--- Diff: src/android/CameraLauncher.java ---
@@ -547,7 +547,7 @@ private String ouputModifiedBitmap(Bitmap bitmap, Uri
uri) throws
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-154568849
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/147
CB-8497: Fix handling of file paths with # character
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jasongin/cordova-plugin-file
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/240#issuecomment-155854701
Does java.exe output compilation errors and warnings to stderr or stdout?
If they go to stderr then we should NOT redirect those.
---
If your project is set
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/239#discussion_r44561465
--- Diff: framework/src/org/apache/cordova/CordovaInterface.java ---
@@ -22,6 +22,7 @@ Licensed to the Apache Software Foundation (ASF) under one
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/239#discussion_r44562203
--- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java ---
@@ -147,6 +151,8 @@ public void onSaveInstanceState(Bundle outState
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/239#discussion_r44562494
--- Diff: framework/src/org/apache/cordova/CoreAndroid.java ---
@@ -113,6 +110,10 @@ else if (action.equals("ex
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/239#discussion_r44562734
--- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java ---
@@ -115,6 +115,10 @@ public boolean onActivityResult(int requestCode, int
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/239#discussion_r44563555
--- Diff: framework/src/org/apache/cordova/ResumeCallback.java ---
@@ -0,0 +1,71 @@
+/*
+ Licensed to the Apache Software Foundation
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/239#discussion_r44564318
--- Diff: framework/src/org/apache/cordova/ResumeCallback.java ---
@@ -0,0 +1,71 @@
+/*
+ Licensed to the Apache Software Foundation
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/240#discussion_r44567649
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +209,46 @@ module.exports = GradleBuilder;
function isAutoGenerated
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/148
CB-9891: Fix permission errors due to URI encoding inconsistency on Android
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/148#issuecomment-155954986
@riknoll please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/148#issuecomment-155969774
This also fixes CB-7024. CB-9891 is really a duplicate of that one.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jasongin closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/147
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/147#issuecomment-156501822
Closing this because I've decided to take a different approach now that I
understand file plugin URI encoding issues better. I'll submit a n
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/149
CB-8497 Fix handling of file paths with # character
Because # is a valid filename character, it must be encoded whenever it
is in a path that is part of a URI, to prevent part of
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/149#issuecomment-156509216
@riknoll please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/418#discussion_r44818344
--- Diff: www/contribute/issues.md ---
@@ -0,0 +1,32 @@
+---
+layout: contribute-help
+title: Apache Cordova Reporting Issues
--- End
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/418#discussion_r44818361
--- Diff: www/contribute/issues.md ---
@@ -0,0 +1,32 @@
+---
+layout: contribute-help
+title: Apache Cordova Reporting Issues
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/418#discussion_r44825174
--- Diff: www/contribute/contribute_guidelines.md ---
@@ -0,0 +1,77 @@
+---
+layout: contribute-help
+title: Apache Cordova Contribute
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/132#discussion_r44842471
--- Diff: bin/lib/check_reqs.js ---
@@ -209,7 +209,7 @@ function getInstalledPhoneSdks () {
}
})
.then(function
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-windows/pull/132#issuecomment-156579165
I looked through all of the PR and didn't find anything concerning other
than the one thing I commented on. But it's a lot of code in an area I
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/149#discussion_r44957285
--- Diff: src/windows/FileProxy.js ---
@@ -256,7 +256,7 @@ function pathFromURL(url) {
}
});
-return
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/240#discussion_r45385577
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +212,54 @@ module.exports = GradleBuilder;
function isAutoGenerated
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/240#discussion_r45385875
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +212,54 @@ module.exports = GradleBuilder;
function isAutoGenerated
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/240#discussion_r45386261
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +209,46 @@ module.exports = GradleBuilder;
function isAutoGenerated
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/240#discussion_r45386856
--- Diff: bin/templates/cordova/lib/builders/GradleBuilder.js ---
@@ -211,3 +212,54 @@ module.exports = GradleBuilder;
function isAutoGenerated
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-docs/pull/428#issuecomment-158571671
Looks good. Very well-written!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/239#issuecomment-161046740
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46445757
--- Diff: README.md ---
@@ -230,6 +230,10 @@ __Parameters__:
- Download requests is being cached by native implementation
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#discussion_r46446244
--- Diff: tests/tests.js ---
@@ -29,6 +29,7 @@ exports.defineAutoTests = function () {
// constants
var
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-lib/pull/351
CB-10125: Android build fails on read-only image files
Ensure image files are writeable before trying to delete them.
I considered an alternative: ensuring files are writeable after
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-lib/pull/351#issuecomment-161730103
@omefire It is called during the prepare phase when building android. See
more info including stack trace in the CB-10125 JIRA issue.
---
If your project is set
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/95#discussion_r46598691
--- Diff: src/android/ContactAccessorSdk5.java ---
@@ -1854,6 +1859,39 @@ public boolean remove(String id) {
return (result >
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/95#discussion_r46598813
--- Diff: src/android/ContactAccessorSdk5.java ---
@@ -1854,6 +1859,39 @@ public boolean remove(String id) {
return (result >
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/94#issuecomment-161811902
I agree the file path handling code probably should be centralized in the
platform lib for each platform. But it should be done as part of a broader
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/118#issuecomment-161817573
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-windows/pull/132#issuecomment-163355408
Refactoring logging into common sounds good, but we shouldn't block this
change on it.
---
If your project is set up for it, you can reply to this emai
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-windows/pull/133
CB-10292: Windows platform support for next version of VS/MSBuild
Reference the JIRA issue for more explanation.
The targets filter for 15.0 is currently the same as 14.0, but I
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-windows/pull/133#issuecomment-168763100
@vladimir-kotikov please review, and commit if it looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/133#discussion_r48873267
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -50,11 +50,11 @@ MSBuildTools.prototype.buildProject =
function(projFile, buildType
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-windows/pull/133#issuecomment-169083097
I updated a couple more places to support 15.0 in addition to 14.0. While
those changes weren't necessary to build a cordova project from VS in the
sce
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/145#issuecomment-169153798
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/151#discussion_r49497844
--- Diff: src/android/CameraLauncher.java ---
@@ -26,11 +26,14 @@ Licensed to the Apache Software Foundation (ASF) under
one
import
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/151#issuecomment-171018798
LGTM, aside from the one minor issue I commented about.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/66#issuecomment-171023399
The code looks good, I'm just a little concerned about testing.
@sgrebnov Since you've been working on the geolocation plugin re
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/100#issuecomment-171061834
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/155#issuecomment-171065505
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/97#issuecomment-171484812
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/167
CB-10577: Android resolveLocalFileSystemURL should detect directory
@rakatyal or @riknoll please review
There were two places in the Android file plugin code that didn'
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/168
CB-7862: FileReader reads large files in chunks with progress
I added support in FileReader for reading large files in chunks and
reporting progress for each chunk. Previously, the
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/168#issuecomment-194003277
@rakatyal or @riknoll please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55443750
--- Diff: tests/tests.js ---
@@ -2382,12 +2383,53 @@ exports.defineAutoTests = function () {
expect(true
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55456235
--- Diff: www/FileReader.js ---
@@ -96,6 +106,78 @@ function initRead(reader, file) {
}
/**
+ * Callback used by the
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/169
CB-10577: Windows resolveLocalFileSystemURL should omit trailing slash for
file
The FileEntry constructor should remove any trailing slash from its path.
This parallels the existing
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r55904187
--- Diff: src/android/FileUtils.java ---
@@ -75,6 +75,7 @@ Licensed to the Apache Software Foundation (ASF) under one
public
GitHub user jasongin opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/171
Fix file plugin test failure on WP 8.1
@riknoll please review
I dislike JavaScript number objects...
You can merge this pull request into a Git repository by running
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/196#discussion_r57250723
--- Diff: src/windows/CameraProxy.js ---
@@ -758,16 +759,31 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, args
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/196#discussion_r57255111
--- Diff: src/windows/CameraProxy.js ---
@@ -758,16 +759,31 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, args
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/133#discussion_r57474870
--- Diff: src/windows/FileTransferProxy.js ---
@@ -359,7 +359,13 @@ exec(win, fail, 'FileTransfer'
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/285#discussion_r57485105
--- Diff: framework/src/org/apache/cordova/CallbackMap.java ---
@@ -0,0 +1,65 @@
+/*
+ Licensed to the Apache Software Foundation (ASF
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/285#discussion_r57485286
--- Diff: framework/src/org/apache/cordova/CallbackMap.java ---
@@ -0,0 +1,65 @@
+/*
+ Licensed to the Apache Software Foundation (ASF
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/285#discussion_r57485883
--- Diff: framework/src/org/apache/cordova/CallbackMap.java ---
@@ -0,0 +1,65 @@
+/*
+ Licensed to the Apache Software Foundation (ASF
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/285#discussion_r57489412
--- Diff: framework/src/org/apache/cordova/CallbackMap.java ---
@@ -0,0 +1,65 @@
+/*
+ Licensed to the Apache Software Foundation (ASF
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-android/pull/285#issuecomment-201493604
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/133#issuecomment-202597643
The update to check for an empty toString() result (as discussed) looks
good.
---
If your project is set up for it, you can reply to this email
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/174#discussion_r57761716
--- Diff: src/android/FileUtils.java ---
@@ -1151,51 +1140,55 @@ private long truncateFile(String srcURLstr, long
size) throws
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58438965
--- Diff: README.md ---
@@ -36,7 +36,9 @@ Although most of the plugin code was written when an
earlier spec was current:
It also
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58439895
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named
"documents", which represents a
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58440889
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named
"documents", which represents a
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58441476
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named
"documents", which represents a
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58441628
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named
"documents", which represents a
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58442202
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named
"documents", which represents a
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58442531
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named
"documents", which represents a
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58442897
--- Diff: README.md ---
@@ -538,3 +540,263 @@ Android also supports a special filesystem named
"documents", which represents a
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/177#discussion_r58919879
--- Diff: www/FileWriter.js ---
@@ -107,8 +108,29 @@ FileWriter.prototype.write = function(data) {
var fileReader = new FileReader
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/177#discussion_r58922573
--- Diff: www/FileWriter.js ---
@@ -107,8 +108,29 @@ FileWriter.prototype.write = function(data) {
var fileReader = new FileReader
Github user jasongin commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/177#issuecomment-207042297
LGTM aside from the minor issues I commented on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58928048
--- Diff: README.md ---
@@ -671,89 +718,111 @@ window.requestFileSystem(window.TEMPORARY, 5 * 1024
* 1024, function (fs
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58928337
--- Diff: README.md ---
@@ -671,89 +718,111 @@ window.requestFileSystem(window.TEMPORARY, 5 * 1024
* 1024, function (fs
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58927585
--- Diff: README.md ---
@@ -36,9 +36,9 @@ Although most of the plugin code was written when an
earlier spec was current:
It also
Github user jasongin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r58928914
--- Diff: README.md ---
@@ -36,7 +36,9 @@ Although most of the plugin code was written when an
earlier spec was current:
It also
1 - 100 of 204 matches
Mail list logo
