Github user imhotep commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/67#discussion_r11004412
--- Diff: src/platforms/tizen.js ---
@@ -0,0 +1,14 @@
+var path = require('path')
+, xml_helpers = require('../u
Github user imhotep commented on the pull request:
https://github.com/apache/cordova-plugman/pull/67#issuecomment-38799304
@gabrielschulhof your PR is merged. However your tests don't reflect your
latest additions. source-file, etcneed to be tested. When you get a chance
p
Github user imhotep commented on the pull request:
https://github.com/apache/cordova-lib/pull/62#issuecomment-49804863
It seems like it already can't be merged cleanly because of recent commits
:-(
---
If your project is set up for it, you can reply to this email and have your
Github user imhotep commented on the pull request:
https://github.com/apache/cordova-android/pull/236#issuecomment-152031010
I believe iOS also has the same issue when transitioning from UIWebView to
other native views (although I don't believe app crashes) so I vote for havi
Github user imhotep commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113558490
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: https
Github user imhotep commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113567338
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url: https
Github user imhotep commented on the issue:
https://github.com/apache/cordova-lib/pull/568
I support this change. I believe it will make writing tests for new
features easier if each source file has a matching spec file and all
source/spec folders are mirrored.
---
If your project
Github user imhotep commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r123849628
--- Diff: bin/templates/cordova/lib/builders/GenericBuilder.js ---
@@ -53,43 +48,13 @@ GenericBuilder.prototype.findOutputApks =
function
Github user imhotep commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r123850098
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -148,6 +152,7 @@ module.exports.runClean = function(options) {
*/
module.exports.run
Github user imhotep commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r123850564
--- Diff: bin/templates/cordova/Api.js ---
@@ -343,6 +349,8 @@ Api.prototype.removePlugin = function (plugin,
uninstallOptions
Github user imhotep commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r123851340
--- Diff: bin/lib/create.js ---
@@ -259,41 +273,53 @@ exports.create = function(project_path, config,
options, events
GitHub user imhotep opened a pull request:
https://github.com/apache/cordova-lib/pull/490
Android studio
Adds Android Studio support
Adds some logging for when patformApi fails for weird reasons.
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user imhotep opened a pull request:
https://github.com/apache/cordova-android/pull/331
Android studio
Adds support for Android Studio plugin install/uninstall
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/imhotep/cordova
Github user imhotep closed the pull request at:
https://github.com/apache/cordova-android/pull/331
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user imhotep reopened a pull request:
https://github.com/apache/cordova-android/pull/331
Android studio
Adds support for Android Studio plugin install/uninstall
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/imhotep
Github user imhotep commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/490#discussion_r80154885
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -60,6 +60,8 @@ function getPlatformApi(platform, platformRootDir) {
events.emit
Github user imhotep commented on the pull request:
https://github.com/apache/cordova-lib/commit/99931eb03cc440e5fb5d7721abb92aa4938fe30e#commitcomment-19644659
@vladimir-kotikov I think you got that right. There should be an error
message when api is incompatible and a different
17 matches
Mail list logo
