[GitHub] cordova-plugin-file-transfer pull request: Reorganised and cleaned...

2014-12-04 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/55 Reorganised and cleaned up test suite. Audited all calls to done() to ensure correct async execution. Removed some redundant code. Removed depencency on mobile-spec: tests now

[GitHub] cordova-plugin-file-transfer pull request: CB-8125 Reorganised and...

2014-12-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/55#issuecomment-66211924 Some discussion on Jira: https://issues.apache.org/jira/browse/CB-8125. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2014-12-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/113#discussion_r21577291 --- Diff: cordova-plugin-mobilespec-tests/tests/localXHR.tests.js --- @@ -0,0 +1,206 @@ +/* +* +* Licensed to the Apache

[GitHub] cordova-plugin-file-transfer pull request: CB-8125 Reorganised and...

2014-12-15 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/55#issuecomment-67082272 Sorry in advance for the spam! Just bumping the thread. If anyone has time to review and/or merge this PR, would they please be able to take a look

[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2015-01-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/113#issuecomment-69891183 I currently get a `Missing semicolon.` error in `src/android/exec.js` when I run createmobilespec. This may be fixed in the latest version: please merge

[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2015-01-16 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/113#issuecomment-70349610 On OSX, everything is green. On Windows, everything except Whitelist is green. On Whitelist I'm seeing an error, `... encountered a declaration exce

[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2015-01-19 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/113#issuecomment-70544816 Ah, that makes sense. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2015-01-20 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/113#issuecomment-70712736 Oh, ok. Nice catch. Do you think we should submit a fix? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-medic pull request: [INFRA-8588] Fixed a bug for ASF Build...

2015-01-23 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/23 [INFRA-8588] Fixed a bug for ASF Buildbot, and a bug for Windows. Fixed a bug causing errors in Apache Buildbot. Improved cleanup method to work on Windows. You can merge this pull request

[GitHub] cordova-medic pull request: [INFRA-8588] Fixing build script bugs,...

2015-01-27 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/24 [INFRA-8588] Fixing build script bugs, with a focus on OS X. Adding install step for `cordova-js` and running `createmobilespec.js` directly with `node` instead of running it from command

[GitHub] cordova-medic pull request: [INFRA-8588] Fixed a bug for ASF Build...

2015-01-29 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/23#discussion_r23759837 --- Diff: cordova.conf --- @@ -110,6 +108,13 @@ from buildbot.config import BuilderConfig from buildbot.process.factory import BuildFactory

[GitHub] cordova-mobile-spec pull request: [CB-5183] Put the node executabl...

2015-02-02 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/116 [CB-5183] Put the node executable invocation in quotes. Fixing the problem with running `createmobilespec.js` when there are spaces in the path to `node`. You can merge this pull

[GitHub] cordova-mobile-spec pull request: [CB-5183] Put the node executabl...

2015-02-02 Thread dblotsky
Github user dblotsky closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-mobile-spec pull request: [CB-5183] Put the node executabl...

2015-02-02 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/117 [CB-5183] Put the node executable invocation in quotes. Fixing the problem with running `createmobilespec.js` when there are spaces in the path to `node`. You can merge this pull

[GitHub] cordova-medic pull request: [INFRA-8588] Stability improvements fo...

2015-02-04 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/25 [INFRA-8588] Stability improvements for medic and Linux slave config. Using local npm cache for npm install to avoid conflicts with other builders. Added Linux slave config. You can merge

[GitHub] cordova-medic pull request: [INFRA-8588] Medic stability improveme...

2015-02-09 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/29 [INFRA-8588] Medic stability improvements Using local npm cache for builds. Working around cordova entrypoint on iOS. Making medic just run 'cordova build' and 'cordova run

[GitHub] cordova-medic pull request: [INFRA-8588] Medic stability improveme...

2015-02-10 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/29#discussion_r24456808 --- Diff: src/build/makers/ios.js --- @@ -15,63 +15,44 @@ module.exports = function(output,lib_location,test_dir, sha, devices, entry_poin

[GitHub] cordova-medic pull request: [INFRA-8588] Medic stability improveme...

2015-02-10 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/29#issuecomment-73802589 Comments addressed in latest commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-medic pull request: [INFRA-8588] Medic stability improveme...

2015-02-11 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/29#discussion_r24480651 --- Diff: src/build/makers/ios.js --- @@ -15,63 +15,44 @@ module.exports = function(output,lib_location,test_dir, sha, devices, entry_poin

[GitHub] cordova-medic pull request: [INFRA-8588] Improving Medic config ro...

2015-02-17 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/31 [INFRA-8588] Improving Medic config robustness Enabling build cancellation. Serializing builds to mitigate resource conflicts (like meulators, or npm). You can merge this pull request into

[GitHub] cordova-plugin-file-transfer pull request: CB-8495 Fixed wp8 and w...

2015-02-19 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/64#issuecomment-75153737 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-mobile-spec pull request: Copy Mobilespec App Template Ins...

2015-03-06 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/121 Copy Mobilespec App Template Instead of Linking It Instead of symlinking the mobilespec app template when calling `createmobilespec`, copy the template's contents in

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-06 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/37 Medic Refactor Rewriting cordova.conf: factoring out common build code, parametrising builds with Buildbot Properties, and adding extra steps for cleanup. Removing unused plugin code

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26068369 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,326 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26068476 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,326 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26069991 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,326 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26077613 --- Diff: buildbot-conf/master.cfg --- @@ -17,37 +17,75 @@ # Absolute or relative path to buildbot per-project configureations. # For local

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26093496 --- Diff: bin/checkout.js --- @@ -0,0 +1,53 @@ +#!/usr/bin/env node + +// node dependencies +var fs = require(&#x

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26093518 --- Diff: bin/prepareapp.js --- @@ -0,0 +1,267 @@ +#!/usr/bin/env node + --- End diff -- Moved to another branch because this file

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26093534 --- Diff: buildbot-conf/cordova-repos.json --- @@ -0,0 +1,452 @@ +{ +"mobile-chrome-apps": { +"code

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26093547 --- Diff: buildbot-conf/cordova-repos.json --- @@ -0,0 +1,452 @@ +{ +"mobile-chrome-apps": { +"code

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26093662 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,326 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26093707 --- Diff: cordova-plugin-medic/www/jasmine-jsreporter.js --- @@ -1,214 +0,0 @@ -/* - This file is part of the Jasmine JSReporter project from

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26093874 --- Diff: README.md --- @@ -1,166 +1,173 @@ -Medic using BuildBot -=== - -> Tools for Automated Testing of Cord

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26093916 --- Diff: buildbot-conf/cordova-config.json.sample --- @@ -0,0 +1,45 @@ +{ +"couchdb": { +"uri": &q

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26093982 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,326 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-09 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26094031 --- Diff: buildbot-conf/private.py.sample --- @@ -0,0 +1,11 @@ +pbcsUser= 'password' +pbcsPwd = 'password' +web

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-10 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26149508 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,326 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-10 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26151823 --- Diff: bin/checkout.js --- @@ -0,0 +1,46 @@ +#!/usr/bin/env node + +// node dependencies +var fs = require(&#x

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-10 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26154261 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,326 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-10 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26157156 --- Diff: buildbot-conf/master.cfg --- @@ -17,37 +17,75 @@ # Absolute or relative path to buildbot per-project configureations. # For local

[GitHub] cordova-mobile-spec pull request: Copy Mobilespec App Template Ins...

2015-03-10 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/121#issuecomment-78153037 I put the change behind a flag called `--copywww`. By default `www` is linked, and if the flag is passed, then it is copied instead. --- If your project

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-11 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26227251 --- Diff: buildbot-conf/cordova-internal.conf --- @@ -0,0 +1,101 @@ +import os +import json + +from buildbot.changes.gitpoller import

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-11 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26227034 --- Diff: buildbot-conf/cordova-config.json.sample --- @@ -0,0 +1,43 @@ +{ +"couchdb": { +"uri": &q

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-11 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26227709 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,336 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-11 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26227988 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,336 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-11 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26228193 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,336 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-11 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26228450 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,336 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-11 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26228733 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,336 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-mobile-spec pull request: Createmobilespec Whitelist Fix

2015-03-11 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/122 Createmobilespec Whitelist Fix Searching for whitelist plugin in top dir instead of cordova-plugins. Also factoring out plugin installation into a function. This is change relates to

[GitHub] cordova-mobile-spec pull request: [CB-8652] Createmobilespec White...

2015-03-11 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/122#issuecomment-78388071 @agrieve could you please take a look if you have a convenient time? Thank you! --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-12 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26226876 --- Diff: buildbot-conf/cordova-config.json.sample --- @@ -0,0 +1,43 @@ +{ +"couchdb": { +"uri": &q

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-12 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/37#issuecomment-78122882 Also good catch with the clone step: I was running an older branch, and this didn't come up in my tests. Fixed the issue by adding an `exclude` paramet

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-12 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26154307 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,326 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-12 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26227510 --- Diff: buildbot-conf/cordova-internal.conf --- @@ -0,0 +1,101 @@ +import os +import json + +from buildbot.changes.gitpoller import

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-12 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26227126 --- Diff: buildbot-conf/cordova-config.json.sample --- @@ -0,0 +1,43 @@ +{ +"couchdb": { +"uri": &q

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-12 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26228485 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,336 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-12 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26228516 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,336 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-12 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26228578 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,336 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-12 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26228651 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,336 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26409576 --- Diff: buildbot-conf/cordova-internal.conf --- @@ -0,0 +1,101 @@ +import os +import json + +from buildbot.changes.gitpoller import

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26409868 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,336 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26409985 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,336 @@ +import os +import re +import json + +from buildbot.schedulers.basic

[GitHub] cordova-mobile-spec pull request: CB-8694 Replaced dependencies pl...

2015-03-17 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/123#issuecomment-82510437 This fails to get tests when `--plugins` is specified. Also, this is a major breaking change to any tool or person that depends on modifying the

[GitHub] cordova-mobile-spec pull request: CB-8694 Replaced dependencies pl...

2015-03-18 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/123#issuecomment-83116032 Tested on my end. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-medic pull request: [CB-8726] Fixing BlackBerry Build

2015-03-20 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/38 [CB-8726] Fixing BlackBerry Build Fixed naming issue for BlackBerry. Crudely made Blackberry report an error when no devices are specified. You can merge this pull request into a Git

[GitHub] cordova-medic pull request: CB-8734 add support for firefoxos

2015-03-23 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/39#discussion_r26997024 --- Diff: buildbot-conf/cordova.conf --- @@ -300,10 +300,13 @@ c['builders'].extend([ BuilderConfig(name='cordova-ios',

[GitHub] cordova-medic pull request: CB-8734 add support for firefoxos

2015-03-23 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/39#issuecomment-85295392 Please make sure that the build scripts run on their own. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-medic pull request: CB-8734 add support for firefoxos

2015-03-23 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/39#discussion_r26998809 --- Diff: src/build/makers/firefoxos.js --- @@ -0,0 +1,34 @@ +var shell= require('shelljs'), +path = req

[GitHub] cordova-medic pull request: CB-8734 add support for firefoxos

2015-03-23 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/39#discussion_r27003714 --- Diff: buildbot-conf/cordova.conf --- @@ -327,6 +330,7 @@ c['schedulers'].extend([ 'cordova-wp8',

[GitHub] cordova-medic pull request: CB-8734 add support for firefoxos

2015-03-23 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/39#issuecomment-85345795 Nope. Sorry, I didn't clarify. It's great that you have a medic installation running locally! However what I mean is this: you can run all the scripts i

[GitHub] cordova-medic pull request: CB-8734 add support for firefoxos

2015-03-24 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/39#issuecomment-85664065 Yep, that is expected. Unfortunately the new medic code still has some baggage from the old design that has not yet been refactored. Specifically, there is a

[GitHub] cordova-mobile-spec pull request: CB-8742 fixed XMLHttpRequest.spe...

2015-03-25 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/125#issuecomment-86120742 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-medic pull request: CB-8734 add support for firefoxos

2015-03-26 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/39#issuecomment-86654603 You need to follow the same steps that Medic follows to use the build scripts. That is: ```bash $ # make sure all the relevant repositories are

[GitHub] cordova-medic pull request: CB-8734 add support for firefoxos

2015-03-30 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/39#issuecomment-87918032 You need to call `createMedicJson`, defined [here](https://github.com/apache/cordova-medic/blob/master/src/utils/createMedicJson.js#L4), similarly to how the

[GitHub] cordova-medic pull request: CB-8734 add support for firefoxos

2015-04-06 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/39#issuecomment-90181969 Hey @marti1125, just checking up: have you managed to get the mobilespec device deploying on a FirefoxOS device with your most recent code? --- If your project

[GitHub] cordova-medic pull request: [CB-8803] Reduce the effect of intermi...

2015-04-06 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/40 [CB-8803] Reduce the effect of intermittent workspace cleanup failure Really simple workaround for now. In the future a more complex wrapper should be made to persistently delete until the

[GitHub] cordova-medic pull request: [CB-8805] Added ability to specify a c...

2015-04-06 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/41 [CB-8805] Added ability to specify a custom repos config file via forced builds. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cordova-plugin-splashscreen pull request: CB-8753 Maintain splash ...

2015-04-07 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/43#issuecomment-90766537 @AlexTalis please include a missing import on [this line](https://github.com/apache/cordova-plugin-splashscreen/commit

[GitHub] cordova-medic pull request: Short Slave Documentation Improvements

2015-04-07 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/42 Short Slave Documentation Improvements Mentioning how to avoid disk indexer thrashing in the docs. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-medic pull request: [CB-8805] Added ability to specify a c...

2015-04-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/41#discussion_r28000339 --- Diff: buildbot-conf/cordova.conf --- @@ -234,8 +245,15 @@ plugins_cleanup_steps = [ common_plugins_steps = plugins_cleanup_steps

[GitHub] cordova-medic pull request: [CB-8803] Reduce the effect of intermi...

2015-04-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/40#discussion_r28001029 --- Diff: buildbot-conf/cordova.conf --- @@ -229,6 +229,8 @@ plugins_cleanup_steps = [ NPMInstall(command=['shelljs'], wha

[GitHub] cordova-plugin-file pull request: CB-8819 Fixed FileReader's readA...

2015-04-13 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/108#issuecomment-92473706 Ran on my machine and verified that it works. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-medic pull request: [CB-8803] Reduce the effect of intermi...

2015-04-13 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/40#issuecomment-92532415 Ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-medic pull request: [CB-8853] Killing Android emulator bef...

2015-04-17 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/43 [CB-8853] Killing Android emulator before build. This works around the issue with the running emulator process preventing running builds. A full solution will come later with a deeper dive

[GitHub] cordova-medic pull request: [CB-8803] Properly fixing the intermit...

2015-04-17 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/44 [CB-8803] Properly fixing the intermittent cleanup issue. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-medic CB

[GitHub] cordova-medic pull request: [CB-8805] Added ability to specify a c...

2015-04-17 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/41#issuecomment-94092731 Ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-medic pull request: [CB-8803] Properly fixing the intermit...

2015-04-17 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/44#discussion_r28638999 --- Diff: bin/medic.js --- @@ -0,0 +1,110 @@ +#!/usr/bin/env node + +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-medic pull request: Syncing code from Apache Infra SVN.

2015-04-22 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/45 Syncing code from Apache Infra SVN. Adding IRC bot code that was added separately on the Apache Infra SVN version of `cordova.conf`. You can merge this pull request into a Git repository by

[GitHub] cordova-medic pull request: [CB-8910] Fixing growing temp director...

2015-04-24 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/46 [CB-8910] Fixing growing temp directory issue Specifying NPM temp folder to be in build directory instead of system temp folder so that it gets cleaned up during `medic.js clean`. You can

[GitHub] cordova-mobile-spec pull request: CB-8927 Add media to cspMeta and...

2015-04-28 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/127#discussion_r29300643 --- Diff: www/csp-incl.js --- @@ -49,7 +49,13 @@ if (!window._disableCSP) { switch (PLAT) { case 'an

[GitHub] cordova-medic pull request: [CB-8870] Consolidating medic code.

2015-04-29 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/47 [CB-8870] Consolidating medic code. Consolidating medic code as the following commands to `medic.js`: medic.js kill - kills emulators medic.js clean- cleans

[GitHub] cordova-medic pull request: [CB-8870] Consolidating medic code.

2015-04-29 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/47#issuecomment-97549951 Comment from myself: fix license headers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-medic pull request: [CB-8870] Consolidating medic code.

2015-04-29 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/47#discussion_r29374599 --- Diff: bin/lib/couchdb.js --- @@ -0,0 +1,151 @@ + +/* +Copyright (c) 2012 Adobe Systems Incorporated. All rights reserved

[GitHub] cordova-medic pull request: [CB-8870] Consolidating medic code.

2015-04-29 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/47#discussion_r29374675 --- Diff: bin/medic.js --- @@ -19,18 +19,44 @@ * under the License. */ -"use strict"; +/* jshint

[GitHub] cordova-medic pull request: INFRA-9518 Remove IRC bot config

2015-04-30 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/48 INFRA-9518 Remove IRC bot config Remove IRC bot from common medic config so we don't get a bot for every installation of medic. The actual IRC bot config will remain only in the SVN co

[GitHub] cordova-medic pull request: CB-8944 Added categories to builders.

2015-05-01 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/50 CB-8944 Added categories to builders. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-medic CB-8944 Alternatively

[GitHub] cordova-medic pull request: CB-8870 Medic test failure display and...

2015-05-01 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/51 CB-8870 Medic test failure display and some fixes Fixing windows debug script path. Making builds store the master's hostname. Adding test number display to build steps. Adding -

[GitHub] cordova-medic pull request: added Firefox OS

2015-05-01 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/49#discussion_r29528708 --- Diff: medic/medic-run.js --- @@ -333,6 +333,25 @@ function main() { var buildCommand = cli + " build " + platform + " -- &

[GitHub] cordova-plugin-file-transfer pull request: CB-8951 Fixed crash rel...

2015-05-05 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/82#issuecomment-99157052 Please make a JIRA or some other task to track the proper fix so we don't forget to do it. --- If your project is set up for it, you can rep

  1   2   3   4   5   6   7   8   9   >