[GitHub] cordova-plugin-inappbrowser pull request #215: CB-12560: (android) fix null ...

2017-03-09 Thread dblood
GitHub user dblood opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/215 CB-12560: (android) fix null pointer with callback when loading multi… ### Platforms affected Android ### What does this PR do? When multiple urls are

[GitHub] cordova-plugin-inappbrowser issue #215: CB-12560: (android) fix null pointer...

2017-04-24 Thread dblood
Github user dblood commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/215 Because the core issue behind this null pointer is threading, having a automated test that would work consistently 100% of the time isn't possible and a flaky test is a bad

[GitHub] cordova-plugin-inappbrowser issue #215: CB-12560: (android) fix null pointer...

2017-04-25 Thread dblood
Github user dblood commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/215 Of course. I will work on a test script. The library I was using is https://github.com/IdentityModel/oidc-client-js with type of "id_token token" and monitoring

[GitHub] cordova-plugin-inappbrowser issue #215: CB-12560: (android) fix null pointer...

2017-04-28 Thread dblood
Github user dblood commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/215 I've spent many hours trying to build a manual test in a "clean" environment. When I get to the office on Monday I can recreate it there and start pulling code o

[GitHub] cordova-plugin-inappbrowser issue #215: CB-12560: (android) fix null pointer...

2017-05-01 Thread dblood
Github user dblood commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/215 I dug through the code quite a bit and think I have found why this was so hard to reproduce for me. (restoring the version I had in my repo instantly caused the problem though