[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-08-06 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-lib/pull/55#issuecomment-51382634 Rebased to master and investigating issues with `uninstall-browserify.spec.js` now. `cordova.js` seems to be blocked inside fixture projects by `uninstall

[GitHub] cordova-plugin-inappbrowser pull request: Windows platform fixes

2014-10-14 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/69 Windows platform fixes Fixes the following Windows platform issues: https://issues.apache.org/jira/browse/CB-7688 https://issues.apache.org/jira/browse/CB-7692 https

[GitHub] cordova-windows pull request: CB-7985 windows platform does not bu...

2014-11-07 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/51 CB-7985 windows platform does not build with Visual Studio 14 CTP tools This fixes the bug - Microsoft.Common.props is loaded successfully thus defining all needed MSBuild variables. You

[GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...

2014-11-07 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/25 CB-7970 Add cordova-plugin-vibration support for Windows Phone 8.1 Added Windows Phone 8.1 support Updated documentation [JIRA issue](https://issues.apache.org/jira

[GitHub] cordova-plugin-battery-status pull request: CB-7971 Add cordova-pl...

2014-11-09 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/18 CB-7971 Add cordova-plugin-battery-status support for Windows Phone 8.1 Added Windows Phone 8.1 support Updated the documentation [JIRA issue](https

[GitHub] cordova-plugin-battery-status pull request: CB-7971 Add cordova-pl...

2014-11-10 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-battery-status pull request: CB-7971 Add cordova-pl...

2014-11-10 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/19 CB-7971 Add cordova-plugin-battery-status support for Windows Phone 8.1 Added Windows Phone 8.1 support Updated the documentation [Jira issue](https

[GitHub] cordova-plugin-statusbar pull request: CB-7986 Add cordova-plugin-...

2014-11-10 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/18 CB-7986 Add cordova-plugin-statusbar support for Windows Phone 8.1 Added Windows Phone 8.1 support Updated the documentation [JIRA issue](https://issues.apache.org/jira

[GitHub] cordova-windows pull request: CB-7985 Make windows platform suppor...

2014-11-10 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-windows/pull/51#issuecomment-62513685 Hello Jesse, Added the name, Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-docs pull request: CB-7970 Add cordova-plugin-vibration su...

2014-11-12 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/245 CB-7970 Add cordova-plugin-vibration support for Windows Phone 8.1 Updated the platforms support table [JIRA issue](https://issues.apache.org/jira/browse/CB-7970) [Related PR with

[GitHub] cordova-docs pull request: CB-7971 Add cordova-plugin-battery-stat...

2014-11-12 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/246 CB-7971 Add cordova-plugin-battery-status support for Windows Phone 8.1 Updated the platforms support table [JIRA issue](https://issues.apache.org/jira/browse/CB-7971) [Related PR

[GitHub] cordova-plugin-vibration pull request: CB-8018 Add vibrate(pattern...

2014-11-14 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/26 CB-8018 Add vibrate(pattern) fallback on vibrate for Windows Phone 8 Added vibrate(pattern) fallback on vibrate for Windows Phone 8 Added vibration cancelling support for

[GitHub] cordova-plugin-globalization pull request: CB-7972 Add cordova-plu...

2014-11-22 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/31 CB-7972 Add cordova-plugin-globalization support for Windows platform Added Windows platform support Moved and refactored wp8 implementation to common code Updated

[GitHub] cordova-docs pull request: CB-7972 Add cordova-plugin-globalizatio...

2014-11-23 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/247 CB-7972 Add cordova-plugin-globalization support for Windows platform Updated the platforms support table [JIRA issue](https://issues.apache.org/jira/browse/CB-7972) [Related PR

[GitHub] cordova-plugin-globalization pull request: CB-7972 Add cordova-plu...

2014-11-25 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/31#issuecomment-64323530 I'm fully agree that having a JS version would be much better, but those API are available in C# only unfortunately so we have to use winmd b

[GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...

2014-11-25 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/25#issuecomment-64471333 Hello Jesse, Thanks for the review, I will update the docs. By restructuring do you mean [using csproj instead of winmd](https://github.com

[GitHub] cordova-plugin-vibration pull request: CB-7970 Add cordova-plugin-...

2014-11-26 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/25#issuecomment-64683921 I have reviewed the WinJS Globalization API: ~60% of the methods are supported (additional quirks can appear though). I will also

[GitHub] cordova-plugin-globalization pull request: CB-7972 Add cordova-plu...

2014-11-26 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/31#issuecomment-64684076 I have reviewed the WinJS Globalization API: ~60% of the methods are supported (additional quirks can appear though). I will also

[GitHub] cordova-plugin-globalization pull request: CB-7972 Add cordova-plu...

2014-12-08 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-globalization/pull/31#discussion_r21478290 --- Diff: src/windows/GlobalizationProxy.js --- @@ -0,0 +1,294 @@ +/* + Licensed under the Apache License, Version 2.0

[GitHub] cordova-plugin-globalization pull request: CB-7972 Add cordova-plu...

2014-12-08 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/31#issuecomment-66176278 Hello Jesse, Could you please take a look at the changes? Thanks, Sergey. --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-globalization pull request: CB-7972 Add cordova-plu...

2014-12-08 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-globalization pull request: CB-7972 Add cordova-plu...

2014-12-08 Thread daserge
GitHub user daserge reopened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/31 CB-7972 Add cordova-plugin-globalization support for Windows platform Added Windows platform support Moved and refactored wp8 implementation to common code Updated

[GitHub] cordova-plugin-battery-status pull request: CB-7953 Add cordova-pl...

2014-12-10 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/20 CB-7953 Add cordova-plugin-battery-status support for browser platform Added browser support Updated the docs [JIRA item](https://issues.apache.org/jira/browse/CB

[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...

2014-12-11 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/46#issuecomment-66686970 Here is [the corresponding JIRA issue](https://issues.apache.org/jira/browse/CB-7955) --- If your project is set up for it, you can reply to this email

[GitHub] cordova-plugin-vibration pull request: android: respect silent aud...

2014-12-12 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/28#issuecomment-66780698 I think you just need to rebase your changes on the latest origin/master code. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-browser pull request: CB-8196 Browser platform `run` shoul...

2014-12-22 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-browser/pull/5 CB-8196 Browser platform `run` should default source file to index.html ... ...even if it's missing in the config.xml [JIRA issue](https://issues.apache.org/jira/browse/CB-8196)

[GitHub] cordova-plugin-globalization pull request: CB-7960 Add cordova-plu...

2015-01-15 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/33 CB-7960 Add cordova-plugin-globalization support for browser platform Added Browser platform support Updated the docs Implementation is based on [Intl (ECMA-402

[GitHub] cordova-plugin-inappbrowser pull request: CB-7961 Add cordova-plug...

2015-01-15 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/76 CB-7961 Add cordova-plugin-inappbrowser support for browser platform Added Browser platform support (Chrome, IE, Firefox) Updated the docs [Corresponding JIRA issue

[GitHub] cordova-lib pull request: CB-8223 Expose config.xml in the Browser...

2015-01-15 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-lib/pull/149 CB-8223 Expose config.xml in the Browser platform Added step for copying platform munged `config.xml` to platform `www` directory near the `index.html` [Corresponding JIRA issue

[GitHub] cordova-browser pull request: CB-8223 Expose config.xml in the Bro...

2015-01-15 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-browser/pull/7 CB-8223 Expose config.xml in the Browser platform Implemented `config.xml` wrapper via XHR [Corresponding JIRA issue](https://issues.apache.org/jira/browse/CB-8223) You can merge

[GitHub] cordova-plugin-splashscreen pull request: CB-7964 Add cordova-plug...

2015-01-15 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/34 CB-7964 Add cordova-plugin-splashscreen support for browser platform Added Browser platform support Using cordova/confighelper module to read parameter values from config.xml

[GitHub] cordova-windows pull request: CB-8321 Add supported orientations c...

2015-01-22 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/56 CB-8321 Add supported orientations config.xml preference handling for `windows` platform [Corresponding JIRA issue](https://issues.apache.org/jira/browse/CB-8321) You can merge this pull

[GitHub] cordova-plugin-battery-status pull request: CB-7953 Add cordova-pl...

2015-03-18 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-battery-status/pull/20#issuecomment-82827466 Hi @purplecabbage, rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-lib pull request: CB-9001 Set WMAppManifest.xml Author, De...

2015-05-28 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-lib/pull/229 CB-9001 Set WMAppManifest.xml Author, Description and Publisher attri… …butes based on config.xml Used getNodeTextSafe in ConfigParser' description getter [JIRA

[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...

2015-06-04 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-ios/pull/144 CB-9116 Ensure platform scripts are executable as the platform could be added on non-OSX environment Corresponding [Jira issue](https://issues.apache.org/jira/browse/CB-9116) You can merge

[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...

2015-06-04 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/144#discussion_r31719008 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -87,6 +87,13 @@ module.exports.run = function (argv) { } return

[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...

2015-06-04 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-ios/pull/144#issuecomment-108915724 @omefire I think that it is because git does not include exec permission for these files. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...

2015-06-04 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-ios/pull/144#issuecomment-108975191 @omefire I don't have Android environment on Mac now, but as far as I can see there are no shell scripts in Android platform. --- If your project is set up f

[GitHub] cordova-lib pull request: CB-9126 Fix ios pbxproj' resources paths...

2015-06-05 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-lib/pull/237 CB-9126 Fix ios pbxproj' resources paths when adding ios platform on non-OSX environment [Jira issue with details](https://issues.apache.org/jira/browse/CB-9126) You can merge this

[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...

2015-06-09 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-ios/pull/144 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request: CB-9116 Ensure platform scripts are exec...

2015-06-09 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-ios/pull/144#issuecomment-110401243 Closing this - decided to rewrite the scripts in node. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...

2015-06-11 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-ios/pull/146 CB-8197 Switch to nodejs for ios platform scripts Convert `copy-www-build-step.sh` to nodejs Adds `glob` module and `bundledDependencies` to `package.json` [Jira issue](https

[GitHub] cordova-ios pull request: CB-8197 Switch to nodejs for ios platfor...

2015-06-18 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/146#discussion_r32742742 --- Diff: bin/templates/project/__CLI__.xcodeproj/project.pbxproj --- @@ -374,7 +374,7

[GitHub] cordova-plugin-file pull request: CB-9215 Add cordova-plugin-file ...

2015-06-18 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file/pull/118 CB-9215 Add cordova-plugin-file manual test for windows platform [Jira issue](https://issues.apache.org/jira/browse/CB-9215) You can merge this pull request into a Git repository by

[GitHub] cordova-lib pull request: Fixed ios node-xcode related tests faili...

2015-06-26 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-lib/pull/253 Fixed ios node-xcode related tests failing on Windows according to version update You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cordova-plugin-file pull request: Added cdvfile protocol purpose d...

2015-06-29 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file/pull/120 Added cdvfile protocol purpose description and examples You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugin

[GitHub] cordova-plugin-media pull request: CB-9237 Add cdvfile:// support ...

2015-06-29 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-media/pull/57 CB-9237 Add cdvfile:// support to media plugin on windows platform Mentioned cdvfile support in the documentation [JIRA issue](https://issues.apache.org/jira/browse/CB-9237

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

2015-06-29 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-media/pull/58 CB-9238 Media plugin cannot record audio on windows Reworked Windows proxy to support ms-appdata file paths (temporaryFolder and localFolder) instead of app package' folders (ms

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

2015-06-29 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482032 --- Diff: src/windows/MediaProxy.js --- @@ -26,6 +26,15 @@ var MediaError = require('cordova-plugin-media.MediaError');

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

2015-06-29 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482303 --- Diff: src/windows/MediaProxy.js --- @@ -91,6 +106,8 @@ module.exports = { var thisM = Media.get(id); // if Media

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

2015-06-29 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482618 --- Diff: src/windows/MediaProxy.js --- @@ -203,20 +234,64 @@ module.exports = { var id = args[0]; var thisM

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

2015-06-29 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33482725 --- Diff: src/windows/MediaProxy.js --- @@ -226,6 +301,10 @@ module.exports = { try { if (thisM.node

[GitHub] cordova-plugin-media pull request: CB-9237 Add cdvfile:// support ...

2015-06-29 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/57#discussion_r33498946 --- Diff: src/windows/MediaProxy.js --- @@ -35,6 +46,8 @@ module.exports = { var src = args[1]; var thisM = Media.get

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

2015-07-06 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33950043 --- Diff: src/windows/MediaProxy.js --- @@ -33,8 +42,11 @@ module.exports = { create:function(win, lose, args) { var id

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

2015-07-06 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33950096 --- Diff: src/windows/MediaProxy.js --- @@ -33,8 +42,11 @@ module.exports = { create:function(win, lose, args) { var id

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

2015-07-06 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33950380 --- Diff: src/windows/MediaProxy.js --- @@ -159,7 +176,21 @@ module.exports = { var id = args[0]; var src = args[1

[GitHub] cordova-plugin-globalization pull request: CB-9336 Fix Globalizati...

2015-07-08 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/38 CB-9336 Fix Globalization plugin init on Windows 10 [Jira issue](https://issues.apache.org/jira/browse/CB-9336) You can merge this pull request into a Git repository by running

[GitHub] cordova-plugin-geolocation pull request: CB-9355 Fix Geolocation p...

2015-07-13 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/45 CB-9355 Fix Geolocation plugin start watch fail related to unset Move… …mentThreshold on Windows 10 [Jira issue](https://issues.apache.org/jira/browse/CB-9355) You

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

2015-07-15 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/58#issuecomment-121547583 @robpaveza, thanks for review, I have addressed your comments. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-file-transfer pull request: CB-9376 Fix FileTransfe...

2015-07-16 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/94 CB-9376 Fix FileTransfer plugin manual tests issue - 'undefined' in p… …aths [Jira issue](https://issues.apache.org/jira/browse/CB-9376) You can merge

[GitHub] cordova-plugin-inappbrowser pull request: CB-9378 Fix InAppBrowser...

2015-07-16 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/109 CB-9378 Fix InAppBrowser not taking whole screen on Windows You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech

[GitHub] cordova-ios pull request: CB-9273 "Copy www build phase" node is n...

2015-07-16 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-ios/pull/149 CB-9273 "Copy www build phase" node is not found [Jira issue](https://issues.apache.org/jira/browse/CB-9273) You can merge this pull request into a Git repository by running:

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

2015-08-03 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/58#issuecomment-127279861 @dblotsky, rebased and tested --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-media pull request: CB-9237 Add cdvfile:// support ...

2015-08-03 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/57#issuecomment-127279922 @dblotsky, rebased and tested --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios pull request: CB-9453 Updating to iOS@3.9.0 not buildi...

2015-08-05 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-ios/pull/150 CB-9453 Updating to iOS@3.9.0 not building [Jira issue](https://issues.apache.org/jira/browse/CB-9453) You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-plugin-splashscreen pull request: CB-9467 SplashScreen doe...

2015-08-07 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/54 CB-9467 SplashScreen does not show any image in hosted app on Windows 10 [Jira issue](https://issues.apache.org/jira/browse/CB-9467) You can merge this pull request into a Git

[GitHub] cordova-lib pull request: CB-8532 Adding Windows Plugin Failed wit...

2015-08-11 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-lib/pull/277 CB-8532 Adding Windows Plugin Failed with "Cannot read property 'text… …' of null" Updated elementtree API according 0.1.6 release [Jira issue](https://is

[GitHub] cordova-plugin-globalization pull request: CB-9336 Fix Globalizati...

2015-08-12 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-js pull request: CB-9342 Fix deviceReady event not fired o...

2015-08-12 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-js/pull/125 CB-9342 Fix deviceReady event not fired on Windows 10 in hosted envir… …onment [Jira issue](https://issues.apache.org/jira/browse/CB-9342) You can merge this pull request into a

[GitHub] cordova-labs pull request: Added CORS header

2015-08-13 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-labs/pull/7 Added CORS header Needed to avoid ``` org.apache.cordova.mobilespec.tests.localXHR.tests >> XMLHttpRequest XMLHttpRequest.spec.9 calls onload from successful http get Ex

[GitHub] cordova-plugin-file-transfer pull request: CB-9493 Fix file paths ...

2015-08-14 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/97 CB-9493 Fix file paths in file-transfer manual tests Also changes `toNativeURL` -> `toURL` because of deprecation. [Jira issue](https://issues.apache.org/jira/browse

[GitHub] cordova-labs pull request: Added CORS header

2015-08-14 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-labs/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-labs pull request: Added CORS header

2015-08-14 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-labs/pull/7#issuecomment-131140893 Thank you, @shazron --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios pull request: CB-9462 iOS 3.9.0 breaks npm link module...

2015-08-18 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-ios/pull/153 CB-9462 iOS 3.9.0 breaks npm link modules Using `shell.exec` as `shelljs` does not support symlinks dereferencing [yet](https://github.com/arturadib/shelljs/pull/164). [Jira issue

[GitHub] cordova-ios pull request: CB-9512 Cordova-ios build/run should fai...

2015-08-18 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-ios/pull/154 CB-9512 Cordova-ios build/run should fail on Windows with a more mean… …ingful message [Jira issue](https://issues.apache.org/jira/browse/CB-9512) You can merge this pull request

[GitHub] cordova-ios pull request: CB-9512 Cordova-ios build/run should fai...

2015-08-20 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/154#discussion_r37507514 --- Diff: bin/templates/scripts/cordova/run.bat --- @@ -15,11 +15,5 @@ :: specific language governing permissions and limitations :: under the

[GitHub] cordova-cli pull request: CB-9523 Show out of date message for old...

2015-08-20 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-cli/pull/219 CB-9523 Show out of date message for older cordova CLI Used [update-notifier](https://github.com/yeoman/update-notifier) module You can merge this pull request into a Git repository by running

[GitHub] cordova-cli pull request: CB-9523 Show out of date message for old...

2015-09-03 Thread daserge
GitHub user daserge reopened a pull request: https://github.com/apache/cordova-cli/pull/219 CB-9523 Show out of date message for older cordova CLI Used [update-notifier](https://github.com/yeoman/update-notifier) module You can merge this pull request into a Git repository by

[GitHub] cordova-cli pull request: CB-9523 Show out of date message for old...

2015-09-03 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-cli/pull/219#issuecomment-137405643 @stevengill, @nikhilkh, Verified (works OK) and documented the ways to disable updates check, please take a look. --- If your project is set up for it, you

[GitHub] cordova-cli pull request: CB-9523 Show out of date message for old...

2015-09-03 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-cli/pull/219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

2015-09-03 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/38 CB-9365 Add support for 'vibrateWithPattern' to Windows Phone 8.1 / W… …indows 10 [Jira issue](https://issues.apache.org/jira/browse/CB-9365) You can merge

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

2015-09-03 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-vibration/pull/38#discussion_r38724321 --- Diff: src/windows/VibrationProxy.js --- @@ -60,12 +61,43 @@ if (VibrationDevice) { fail(e

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

2015-09-04 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/38#issuecomment-137694325 @nikhilkh, @robpaveza thanks for review! Please take a look once more - I have addressed your comments. --- If your project is set up for it, you

[GitHub] cordova-ios pull request: CB-9512 Cordova-ios build/run should fai...

2015-09-04 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-ios/pull/154#issuecomment-137849262 Great, thanks, closing this in that case :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios pull request: CB-9512 Cordova-ios build/run should fai...

2015-09-04 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-ios/pull/154 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-8198 Unified console output logic for...

2015-09-10 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-lib/pull/306 CB-8198 Unified console output logic for core platforms Passed eventEmitter to PlatformApi poly for logging Extended CordovaError with code and context, added ErrorCodes, overrode toString

[GitHub] cordova-cli pull request: CB-8198 Unified console output logic for...

2015-09-10 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-cli/pull/222 CB-8198 Unified console output logic for core platforms Added advanced ansi-based logger Redirected events to logger [Corresponding Lib updates PR](https://github.com/apache

[GitHub] cordova-cli pull request: CB-8198 Unified console output logic for...

2015-09-10 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/222#discussion_r39181657 --- Diff: src/logger.js --- @@ -0,0 +1,112 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license

[GitHub] cordova-cli pull request: CB-8198 Unified console output logic for...

2015-09-10 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/222#discussion_r39182442 --- Diff: src/logger.js --- @@ -0,0 +1,112 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license

[GitHub] cordova-cli pull request: CB-8198 Unified console output logic for...

2015-09-10 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/222#discussion_r39182618 --- Diff: package.json --- @@ -29,10 +29,11 @@ "cli" ], "dependencies": { -"cordova-lib":

[GitHub] cordova-lib pull request: CB-9521 Do not pass removed platform to ...

2015-09-18 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/308#discussion_r39896066 --- Diff: cordova-lib/src/cordova/platform.js --- @@ -363,6 +363,7 @@ function remove(hooksRunner, projectRoot, targets, opts

[GitHub] cordova-android pull request: CB-9608 cordova-android no longer bu...

2015-09-23 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-android/pull/215 CB-9608 cordova-android no longer builds on Node 0.10 or below Replaced `path.isAbsolute` usage with `path.resolve`. [Jira issue](https://issues.apache.org/jira/browse/CB-9608

[GitHub] cordova-android pull request: CB-9080 Cordova CLI run for Android ...

2015-09-23 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-android/pull/216 CB-9080 Cordova CLI run for Android versions 4.1.1 and lower throws e… …rror [Jira issue](https://issues.apache.org/jira/browse/CB-9080) You can merge this pull request into a

[GitHub] cordova-android pull request: CB-9608 cordova-android no longer bu...

2015-09-23 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-android/pull/215 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request: CB-9608 cordova-android no longer bu...

2015-09-23 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-android/pull/215#issuecomment-142655973 Investigating path issues on a Mac, closing this for now. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-android pull request: CB-9608 cordova-android no longer bu...

2015-09-23 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-android/pull/217 CB-9608 cordova-android no longer builds on Node 0.10 or below Replaced `path.isAbsolute` usage with `path.resolve`. [Jira issue](https://issues.apache.org/jira/browse/CB-9608

[GitHub] cordova-android pull request: CB-9608 cordova-android no longer bu...

2015-09-23 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-android/pull/217#issuecomment-142671130 This should work on OSX now as well (`path.join('.', '/some/abs/path.tofile')` was turning path to relative in #215 ). --- If your proj

[GitHub] cordova-android pull request: Fixed CB-9697 Cordova emulate for An...

2015-09-24 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-android/pull/219#issuecomment-142867588 @mleoking thanks! It should be fixed in `device.js` as well. I believe this is a duplicate of #216 though. --- If your project is set up for it, you

[GitHub] cordova-ios pull request: CB-9698 Add rsync error handling in ios ...

2015-09-24 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-ios/pull/168 CB-9698 Add rsync error handling in ios copy-www-build-step.js [Jira issue](https://issues.apache.org/jira/browse/CB-9698) You can merge this pull request into a Git repository by running

[GitHub] cordova-android pull request: Fixed CB-9697 Cordova emulate for An...

2015-09-24 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-android/pull/219#issuecomment-142878060 @mleoking Thanks for the explanation! I think `-d` was also being removed in master before [this commit](https://github.com/apache/cordova-android/commit

  1   2   3   4   5   6   7   8   >