[GitHub] cordova-plugin-camera pull request: CB-9446 Fix real path returnin...

2015-08-04 Thread charlesverge
GitHub user charlesverge opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/112 CB-9446 Fix real path returning null pointer on some Samsung devices Fix for https://issues.apache.org/jira/browse/CB-9446 You can merge this pull request into a Git repository

[GitHub] cordova-plugin-camera pull request: CB-9446 Fix real path returnin...

2015-10-19 Thread charlesverge
Github user charlesverge commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-149220643 @riknoll The code in #93 is missing a null pointer check But the differences for the code which retrieves the url is #112

[GitHub] cordova-plugin-camera pull request: CB-9446 Fix real path returnin...

2015-10-19 Thread charlesverge
Github user charlesverge commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-149219346 @nikopolv This fix usually covered pre Kit Kat devices, does #93 execute properly with your Sony Aqua M2 ? Also, can you indicate the os version you

[GitHub] cordova-plugin-camera pull request: CB-9446 Fix real path returnin...

2015-10-26 Thread charlesverge
Github user charlesverge commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-151165724 @nikopolv Does the Sony Aqua M2 with 4.4 kitkat work with the branch issue #93 is based off of ? --- If your project is set up for it, you can

[GitHub] cordova-plugin-camera pull request: CB-9446 Fix real path returnin...

2015-11-10 Thread charlesverge
Github user charlesverge commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/112#issuecomment-155517946 @infil00p The method comes from a previous version of the plugin which was working for some devices. https://github.com/apache/cordova-plugin

[GitHub] cordova-plugin-camera pull request #268: CB-12873: Add customization options...

2017-05-31 Thread charlesverge
GitHub user charlesverge opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/268 CB-12873: Add customization options for caputre button, resizing of v… …ideo browser resize Reported issue https://issues.apache.org/jira/browse/CB-12873

[GitHub] cordova-plugin-camera issue #268: CB-12873: Add customization options for ca...

2017-07-08 Thread charlesverge
Github user charlesverge commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/268 Added a check to prevent error from null value being passed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If