Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/18#issuecomment-37331345
I don't see this error/warning using Xcode 5.0.2. What version do you see
this in?
---
If your project is set up for it, you can reply to
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-cli/pull/138#issuecomment-37417943
Thanks for the fix! I've merged it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-cli/pull/139#issuecomment-37418719
Thanks for tracking this down. I think a better fix is to just delete the
fail() clause. I tested that doing so shows the stacktrace, and so have gone
with that
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-docs/pull/149#issuecomment-38949437
I think the changes here look good. Not sure why it was never merged. Just
tried applying them though, and there were too many merge conflicts. Would you
be able
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11080008
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r1107
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11080035
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11080089
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11080227
--- Diff: src/info.js ---
@@ -30,105 +29,80 @@ var cordova_util = require('./util'),
Outputs to a file
*/
module.exports
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/152#discussion_r11080370
--- Diff: src/info-utils.js ---
@@ -0,0 +1,150 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/152#discussion_r11080438
--- Diff: src/info-utils.js ---
@@ -0,0 +1,150 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/146#discussion_r11080870
--- Diff: platforms.js ---
@@ -39,12 +41,14 @@ module.exports = {
version: '3.4.0'
},
'wp7' : {
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugman/pull/31#issuecomment-38963141
Going to close this given the work that's gone on since. Open a new one to
continue on.
---
If your project is set up for it, you can reply to this emai
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/146#discussion_r11128647
--- Diff: platforms.js ---
@@ -39,12 +41,14 @@ module.exports = {
version: '3.4.0'
},
'wp7' : {
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/155#discussion_r11130975
--- Diff: src/superspawn.js ---
@@ -60,11 +60,11 @@ exports.spawn = function(cmd, args, opts) {
var spawnOpts = {};
var d = Q.defer
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-docs/pull/149#issuecomment-39137390
I've merged this in now, thanks!
Not exactly sure how you went about rebasing, but normally a rebase
shouldn't result in an extra commit. &
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-cli/pull/155#issuecomment-39284881
Seems I accidentally pushed the commit in its previous state (whoops!).
Just played around and found that it was actually the
windowsVerbatimArguments flag
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11260150
--- Diff: src/info.js ---
@@ -16,123 +16,99 @@
specific language governing permissions and limitations
under the License
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11260194
--- Diff: src/info.js ---
@@ -16,123 +16,99 @@
specific language governing permissions and limitations
under the License
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11260238
--- Diff: src/info.js ---
@@ -16,123 +16,99 @@
specific language governing permissions and limitations
under the License
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11260290
--- Diff: src/info.js ---
@@ -16,123 +16,99 @@
specific language governing permissions and limitations
under the License
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11260263
--- Diff: src/info.js ---
@@ -16,123 +16,99 @@
specific language governing permissions and limitations
under the License
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11260409
--- Diff: src/info.js ---
@@ -16,123 +16,99 @@
specific language governing permissions and limitations
under the License
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11260484
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11260509
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11278577
--- Diff: src/info.js ---
@@ -16,123 +16,99 @@
specific language governing permissions and limitations
under the License
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/34#issuecomment-39528432
Seems like a simple expectation, but AFAIK, all UIWebViews have a shared
cache & cookie jar. We could probably clear them out for a white
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugman/pull/72#issuecomment-39983493
I did merge this in, but forgot to close it (@Josh, can you close it?).
Mark - sounds like that's a better approach. Could you make the change?
-
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/11#issuecomment-40600943
Thanks for the pull request. I've had a look at it and think it looks good.
Before we can merge it though, you need to sign Apache's Contribut
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-cli/pull/116#issuecomment-41177828
Support for this just landed! woohoo!
https://issues.apache.org/jira/browse/CB-5093
Will be out in the next release.
---
If your project is set up for
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-cli/pull/164#issuecomment-41180908
Thanks for the patch. I've created an issue for this:
https://issues.apache.org/jira/browse/CB-6501
---
If your project is set up for it, you can rep
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-cli/pull/151#issuecomment-41184231
Merged. I did a clean-up commit along with it that you can see here:
https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;a=blobdiff;f=src/info.js;h
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-cli/pull/151#issuecomment-41190420
Unless there are functions that will be used by other files as well, keep
it in one file.
---
If your project is set up for it, you can reply to this email and
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/99#issuecomment-41637291
LGTM! Thanks! I've merged it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12193116
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,124 @@
+/*
+ * Copyright (c) Microsoft Open Technologies, Inc.
--- End diff --
Don
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12193146
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,124 @@
+/*
+ * Copyright (c) Microsoft Open Technologies, Inc.
+ *
+ * Licensed under
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12193181
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,124 @@
+/*
+ * Copyright (c) Microsoft Open Technologies, Inc.
+ *
+ * Licensed under
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/74#discussion_r12193231
--- Diff: src/util/hooks.js ---
@@ -0,0 +1,124 @@
+/*
+ * Copyright (c) Microsoft Open Technologies, Inc.
+ *
+ * Licensed under
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-app-harness/pull/1#discussion_r13839802
--- Diff: www/cdvah/js/HarnessServer.js ---
@@ -272,15 +278,30 @@
app.updatingStatus = unzipPercentage
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-coho/pull/31#issuecomment-47266828
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/34#discussion_r14300639
--- Diff: plugin.xml ---
@@ -33,6 +33,9 @@
+
+
--- End diff --
As discussed on ML
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/14#discussion_r14304481
--- Diff: src/ios/CDVCamera.m ---
@@ -736,21 +736,4 @@ @implementation CDVCameraPicker
@synthesize webView;
@synthesize
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/23#issuecomment-47379219
Camera has a lot of technical debt and a lot of bugs in it. I think you'd
actually be better off forking the plugin rather than extending it. Even b
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/30#issuecomment-47379940
Patch looks good, but wondering if this fixes a bug?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-47380724
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/10#issuecomment-47380981
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/21#issuecomment-47381981
Closing for now, please file new pull request with not adding a js-module
to the main plugin.xml
---
If your project is set up for it, you can reply to
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/14#issuecomment-47382247
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/15#issuecomment-47383450
Closing pull request since this file has been deleted. Plugin now just
defers to browser's geolocation implementation.
---
If your project is s
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/12#issuecomment-47383772
Code looks awesome, but adding test code to the plugin is a show-stopper.
Going to close PR for now, but please re-open with one of the work-arounds
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/34#issuecomment-47384221
bump - what's the state of this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/42#issuecomment-47384434
@shazron - should this be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/49#issuecomment-47384868
Dupe of pull #45, (which I just merged). Thanks anyways :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/21#issuecomment-47384949
Dupe of #45, which i just merged. Thanks anyways.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/30#issuecomment-47385079
Dupe of #45, which i just merged. Thanks anyway :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/15#issuecomment-47385186
Looks like this change has now been made. Closing pull request. Thanks
anyways! :)
---
If your project is set up for it, you can reply to this
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/18#issuecomment-47385693
Sounds like a neat feature, but according to:
https://developer.apple.com/library/ios/documentation/EventHandling/Conceptual/EventHandlingiPhoneOS
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/6#issuecomment-47385929
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/12#issuecomment-47385999
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/19#issuecomment-47386709
Looks good, but as per the ML discussion we don't want tests to be included
in the release version of the plugin. Please create a new PR wit
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/18#issuecomment-47387136
Looks like this was fixed with #20, which i just merged. Thanks anyways!
---
If your project is set up for it, you can reply to this email and have
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/13#issuecomment-47387215
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/11#issuecomment-47387288
Please open a new PR with not added to main plugin.xml.
---
If your project is set up for it, you can reply to this email and have your
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/19#issuecomment-47387715
Thanks for the fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/17#issuecomment-47387800
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-47388513
Definitely a good bug to have fixed. Could you clarify for me why the need
for swizzling? Instead of just setting shouldAutorotate directly
---
If
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/13#issuecomment-47388601
Assuming this is merged and closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/10#issuecomment-47388724
Thanks for the fix. Looks like it was fixed on master recently though.
---
If your project is set up for it, you can reply to this email and have your
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/7#issuecomment-47388832
PR needs rebasing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-47389170
Change looks good to me. @phaitour - have you signed the Apache ICLA (can
be done online):
http://www.apache.org/licenses/#clas
@shazron
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-47830696
Ah, I gotcha, It's because the shouldAutorotate selector has no setter in
CDVViewController.
@shazron - any opinion on this? with swiz
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-docs/pull/209#issuecomment-48177418
Looks like this was merged. (hash=91a52859) Please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/105#issuecomment-48687118
I believe this issue is fixed on master. Have a look at the commit here:
https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=445ddd8
And
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/97#issuecomment-48938359
Change needs to be rebased & I need to you confirm you've signed Apache's
ICLA http://www.apache.org/licenses/#clas
---
If your project is set
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/97#discussion_r14897935
--- Diff: CordovaLib/Classes/CDVCommandDelegateImpl.m ---
@@ -107,6 +107,10 @@ - (BOOL)isValidCallbackId:(NSString *)callbackId
return NO
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/57#issuecomment-48948290
Looks like this change was made as a part of another commit. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/97#issuecomment-48985460
Sounds like maybe we abandon this PR.
Plugins have an initialize() method that you can override to do extra
constructor-time logic.
I've tweaked th
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-cli/pull/184#issuecomment-49819230
What is this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/55#issuecomment-51811935
+1 for the "or even" clause there. I'd like to be able to write:
var cordovaProject = cordova_lib.loadProject(rootDir)
cordovaProje
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/105#issuecomment-52079190
The fix was not in 3.5.1, you'll still need to try it from master or apply
the patch to your copy to get the fix.
---
If your project is set up for it, yo
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-52326500
@shazron bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/63#issuecomment-52344620
Just getting back to this. Code looks good!
Before we can merge it though, you need to sign Apache's Contributor
License Agreement (can be done online):
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/114#issuecomment-52784679
Thanks for this. The original intention of changing to ant-build is to
prevent a conflict with Eclipse's build. So, it was meant to apply to all
sub-pro
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-cli/pull/131#issuecomment-52787065
Closing this since it no longer works (code was moved into the
"cordova-lib" repo.
That said, it I think the feature is still useful. Shouldn
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/17#issuecomment-52787753
Is this still valid?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/16#issuecomment-52787803
still valid?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/7#issuecomment-52792885
bump
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-docs/pull/220#issuecomment-52796022
Merging this. It's a clear improvement over what was there. If there's more
tweaks to be made, please send more PRs :)
---
If your project is set up f
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/114#issuecomment-54914245
aha, that makes sense.
Unfortunately, the renaming needs to happen for all sub-projects (plugins
can include subprojects as well), not just for
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/125#discussion_r18396839
--- Diff: framework/src/org/apache/cordova/NativeToJsMessageQueue.java ---
@@ -419,53 +419,43 @@ private void initReflection
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/125#discussion_r18396901
--- Diff: framework/src/org/apache/cordova/NativeToJsMessageQueue.java ---
@@ -419,53 +419,43 @@ private void initReflection
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/125#discussion_r18396932
--- Diff: framework/src/org/apache/cordova/NativeToJsMessageQueue.java ---
@@ -419,53 +419,43 @@ private void initReflection
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/125#discussion_r18397007
--- Diff: framework/src/org/apache/cordova/PluginResult.java ---
@@ -80,6 +83,12 @@ public PluginResult(Status status, byte[] data, boolean
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/90#discussion_r18538787
--- Diff: cordova-lib/package.json ---
@@ -36,7 +36,8 @@
"underscore": "1.4.4",
"xcode": "0.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/16#issuecomment-58239875
Looks like this patch adds error messages into the "npm test" output:
```
.mkdir: path already exists:
/var/folders/00/0_32r000h01000cxqpys
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/47#discussion_r18540893
--- Diff: cordova-lib/src/cordova/platforms.js ---
@@ -22,6 +22,11 @@
*/
module.exports = {
+'tizen' : {
+
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/16#issuecomment-58240303
Seems this PR is superseded by https://github.com/apache/cordova-lib/pull/47
---
If your project is set up for it, you can reply to this email and have your
reply
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/14#issuecomment-58241032
This still seems like a useful feature, but doesn't cleanly merge. @jpetso
- if you want to rebase, let me know and I (or @jsoref) can merge it in.
---
If
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/19#issuecomment-58241205
Is this still valid?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-coho/pull/49#issuecomment-58243962
Note for the passer-by: this PR is on hold until we figure out if we want
to use a private staging npm repo instead (I believe)
---
If your project is set up for
1 - 100 of 336 matches
Mail list logo