[GitHub] cordova-lib pull request: CB-5696 find ios project directory using...

GitHub user Mitko-Kerezov opened a pull request: https://github.com/apache/cordova-lib/pull/151 CB-5696 find ios project directory using the xcode project file Add unit tests for future reassurance Fix incorrect name "ChildApp" in .pbxproj files to "SampleApp&

[GitHub] cordova-lib pull request: CB-5696 find ios project directory using...

Github user Mitko-Kerezov commented on the pull request: https://github.com/apache/cordova-lib/pull/151#issuecomment-71607363 Hey @shazron can you take a look at this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-ios pull request: CB-8084 conform AppDelegate.m with provi...

GitHub user Mitko-Kerezov opened a pull request: https://github.com/apache/cordova-ios/pull/127 CB-8084 conform AppDelegate.m with provisioning profile Hide the two methods in AppDelegate.m for push notifications when provisioning profile doesn't include the push notifica

[GitHub] cordova-ios pull request: CB-8084 conform AppDelegate.m with provi...

Github user Mitko-Kerezov closed the pull request at: https://github.com/apache/cordova-ios/pull/127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ios pull request: CB-8084 conform AppDelegate.m with provi...

GitHub user Mitko-Kerezov opened a pull request: https://github.com/apache/cordova-ios/pull/128 CB-8084 conform AppDelegate.m with provisioning profile Hide the two methods in AppDelegate.m for push notifications when provisioning profile doesn't include the push notifica

[GitHub] cordova-ios pull request: CB-8084 conform AppDelegate.m with provi...

Github user Mitko-Kerezov commented on the pull request: https://github.com/apache/cordova-ios/pull/128#issuecomment-73229125 Thanks, @ligaz - comments addressed. Hey @shazron or @agrieve could someone please take a look at this --- If your project is set up for it, you can reply

[GitHub] cordova-ios pull request: CB-8084 conform AppDelegate.m with provi...

Github user Mitko-Kerezov commented on the pull request: https://github.com/apache/cordova-ios/pull/128#issuecomment-75227834 Issue was fixed with https://github.com/apache/cordova-ios/commit/8dcc9dd626c523e6e217dd7e8ce43d0af849fa3a So I'm closing this now --- If your proje

[GitHub] cordova-ios pull request: CB-8084 conform AppDelegate.m with provi...

Github user Mitko-Kerezov closed the pull request at: https://github.com/apache/cordova-ios/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request: Parse options correctly

Github user Mitko-Kerezov commented on the pull request: https://github.com/apache/cordova-android/pull/248#issuecomment-169372671 Ping @vladimir-kotikov --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-android pull request: Parse options correctly

GitHub user Mitko-Kerezov opened a pull request: https://github.com/apache/cordova-android/pull/248 Parse options correctly Fix 1 Options have already passed through `nopt` module in the build file. Nopt successfully parses all options which results in `argv.remain` being an

[GitHub] cordova-android pull request: Parse options correctly

Github user Mitko-Kerezov commented on the pull request: https://github.com/apache/cordova-android/pull/248#issuecomment-169964965 Ping @infil00p for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-android pull request: Parse options correctly

Github user Mitko-Kerezov commented on the pull request: https://github.com/apache/cordova-android/pull/248#issuecomment-175496415 @nikhilkh I've already filed the ICLA some time in 2015 and have already contributed to cordova. (Can't find the email though but I have m

[GitHub] cordova-android pull request: Parse options correctly

Github user Mitko-Kerezov commented on the pull request: https://github.com/apache/cordova-android/pull/248#issuecomment-176044525 @vladimir-kotikov I've restructured the fixes and have separated them in two commits. Regarding the options I've considered your word

[GitHub] cordova-ios pull request #281: Hard link instead of soft linking

GitHub user Mitko-Kerezov opened a pull request: https://github.com/apache/cordova-ios/pull/281 Hard link instead of soft linking Softlinking resource files (.wav files [for example](https://github.com/apache/cordova-plugin-dialogs/tree/master/src/ios/CDVNotification.bundle

[GitHub] cordova-ios issue #281: Hard link instead of soft linking

Github user Mitko-Kerezov commented on the issue: https://github.com/apache/cordova-ios/pull/281 Note: I've tested this with `cordova-android` and it doesn't seem to reproduce - for one reason or another `gradle` seems to follow symlinks when zipping up the `.apk` file, s

[GitHub] cordova-ios issue #281: CB-12247: Hard link instead of soft linking

Github user Mitko-Kerezov commented on the issue: https://github.com/apache/cordova-ios/pull/281 Sure thing @kerrishotts --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled