[GitHub] cordova-plugin-inappbrowser issue #201: (Android) Implement Download Files f...

2017-03-23 Thread MeirBon
Github user MeirBon commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/201 @Gorebar #ivanrb I had the same issue this week and merged both changes into a new branch 'download-permissions': https://github.com/MeirBon/cordova-plugin-inappbr

[GitHub] cordova-plugin-inappbrowser issue #201: (Android) Implement Download Files f...

2017-04-25 Thread MeirBon
Github user MeirBon commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/201 @jonasof Your implementation looks indeed better. About the storage permissions, I think there is no other option than to include it in the manifest (we had it automatically

[GitHub] cordova-plugin-inappbrowser pull request #221: CB-12834: (android) Fix bug w...

2017-05-19 Thread MeirBon
GitHub user MeirBon opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/221 CB-12834: (android) Fix bug when opening a download link ### Platforms affected Android ### What does this PR do? It adds a dialog to request permissions when a

[GitHub] cordova-plugin-inappbrowser issue #201: (Android) Implement Download Files f...

2017-05-19 Thread MeirBon
Github user MeirBon commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/201 I have created a new [pull request](https://github.com/apache/cordova-plugin-inappbrowser/pull/221), because this one didn't follow the guidelines. I have also created an

[GitHub] cordova-plugin-inappbrowser issue #221: CB-12834: (android) Fix bug when ope...

2017-08-09 Thread MeirBon
Github user MeirBon commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/221 @RafaelKr Don't have the time right now to work on this. Feel free to make a pull request to my fork and I will take a look when I have time. --- If your project is set u