Re: 2.7 for Adobe Max?

2013-04-18 Thread Joe Bowser
>>> wrote: >>> >>>> +1 >>>> >>>> On 4/16/13 7:52 PM, "Filip Maj" wrote: >>>> >>>> >+1. >>>> > >>>> >So, how do we feel about starting an RC soon? >>>> > >>&g

Rules about Cherry-Picking

2013-04-19 Thread Joe Bowser
Hey I know that we're only supposed to put in regression fixes into the release branches, but Benn just finished a bunch of script work that was slated to go into 2.7.0 after we did the RC1 tag. Is it cool to cherrypick this in after RC1? Or are we being super strict about this? Joe

[Android] HTTP Authentication and WebKit: WTF?

2013-04-19 Thread Joe Bowser
Hey I'm looking at CB-2962, and I'm not sure how we can resolve this one. Should we intercept any XHR requests with a Basic Auth token, and set it on the browser? I noticed that CordovaWebViewClient does have some code to deal with this, but I'm confused as to how this works. Any ideas? Joe

Re: Re-tag Cordova Js?

2013-04-19 Thread Joe Bowser
Getting merge conflicts! Seriously, WTF? On Fri, Apr 19, 2013 at 5:44 PM, Tim Kim wrote: > Oh turns out I just didn't push up the 2.7.x changes :) > > Thought something crazier was going on. OK - I think it should be good now! > > *crosses fingers* > > > > On 19 April 2013 17:37, Tim Kim wrote:

Re: Re-tag Cordova Js?

2013-04-19 Thread Joe Bowser
I've re-tagged Android with the new JS. WORST RELEASE PROCESS EVER! On Fri, Apr 19, 2013 at 5:54 PM, Jesse wrote: > Okay, so are we good with 360bd3e65c33ce4f01e2efb82d641a565ef3c333 ? > I have tagged WP7+8 > > @purplecabbage > risingj.com > > > On Fri, Apr 19

[Android/iOS] CB-2459: Is this Syntax correct?

2013-04-22 Thread Joe Bowser
Hey I saw this old ticket that I left open, and after re-reading this and thinking about it, and this just looks weird. I'm wondering what other people think of this syntax on window.open before I close this one. Joe

Re: RC version numbers

2013-04-25 Thread Joe Bowser
OK, even though it won't go into 2.7.0rc1, I added the correct version anyway. I do think we need to cut an RC2 before we do a final release, and I'll start up a separate thread for that. On Thu, Apr 25, 2013 at 10:18 AM, Joe Bowser wrote: > That's an accident! The VERSI

RC2

2013-04-25 Thread Joe Bowser
Hey The RC1 release was kind of done too fast, and the versioning broke. Because of this, I think we should really have an RC2 release before we do a 2.7.0 final release. Perhaps we should start an RC2 today for this? Thoughts? Joe

Re: RC version numbers

2013-04-25 Thread Joe Bowser
That's an accident! The VERSION files should be 2.7.0rc1 On Thu, Apr 25, 2013 at 10:15 AM, Andrew Grieve wrote: > For the JS, we set VERSION = 2.7.0rc1 > For Android's Device.java, we set VERSION = 2.7.0 (no rc1). > > Perhaps not a huge deal, but I just want to get clear on this before > automa

Re: RC version numbers

2013-04-25 Thread Joe Bowser
That's exactly what I did. The VERSION was set to 2.7.0, not 2.7.0rc1. On Thu, Apr 25, 2013 at 10:22 AM, Simon MacDonald wrote: > It should be in there. If you change the VERSION file in the Android repo > then run the ant script it will update the VERSION in all the files that > are required. T

Re: RC2

2013-04-25 Thread Joe Bowser
ect fields. (And yes, I'm also at fault for doing this). On Thu, Apr 25, 2013 at 10:27 AM, Filip Maj wrote: > What broke? > > On 4/25/13 10:22 AM, "Joe Bowser" wrote: > >>Hey >> >>The RC1 release was kind of done too fast, and the versioning broke.

Re: RC2

2013-04-25 Thread Joe Bowser
Actually, let's just do a release. On Thu, Apr 25, 2013 at 10:30 AM, Joe Bowser wrote: > Android versioning wasn't done right. In fact, none of the versioning > was done right, and I kind of feel that we rushed the release a bit. > That being said, I'm not totally op

Re: RC2

2013-04-25 Thread Joe Bowser
: > >> +1 >> >> >> On Thu, Apr 25, 2013 at 11:20 AM, Joe Bowser wrote: >> >> > Actually, let's just do a release. >> > >> > On Thu, Apr 25, 2013 at 10:30 AM, Joe Bowser wrote: >> > > Android versioning wasn't done right

Re: [Android] The Deprecation of Froyo

2013-04-26 Thread Joe Bowser
>> >>>> >> >>>>> +1 for dropping >> >>>>> >> >>>>> Steve found a Nexus One in his filing cabinet last week, wonder what >> >>>> that >> >>>>> was running ... >> >>>>> >> >>>&g

Re: [Android] The Deprecation of Froyo

2013-04-26 Thread Joe Bowser
be done by 3.0? > > Or is that not official yet? > > > On Fri, Apr 26, 2013 at 12:48 PM, Joe Bowser wrote: > >> I haven't added the tickets yet. Do we want to deprecate by 3.0 or >> follow the six month deprecation policy? >> >> On Fri, Apr 26, 20

Are we supposed to include okhttp source in Cordova-Android?

2013-04-29 Thread Joe Bowser
Hey I saw that okhttp was added, but I don't know if including the source and as such re-distributing it this way is correct or not. Is there someone around to clarify whether it's OK for us to use the library in this way in the project or not, or whether we have to do what we do with commons-cod

Re: Are we supposed to include okhttp source in Cordova-Android?

2013-04-29 Thread Joe Bowser
to embed it for distribution. > > There's probably someone in Apache who is far more qualified than I to say > what we can and should do, though. > > > On Mon, Apr 29, 2013 at 1:49 PM, Joe Bowser wrote: > >> Hey >> >> I saw that okhttp was added, but I don

[Android] Including okHttp as source might not be such a good idea

2013-04-29 Thread Joe Bowser
Hey I'm currently working with Master and I'm noticing that Eclipse really hates all these @Override Annotations put in the code. Since everyone's Eclipse will probably work slightly different in this regard, and I have no idea how fix this other than by deleting all the annotations, I propose th

Re: [Android] Including okHttp as source might not be such a good idea

2013-04-29 Thread Joe Bowser
On Mon, Apr 29, 2013 at 7:53 PM, Ian Clelland wrote: > Lets not try to force all developers to change their settings; that sounds > like a world of pain. > Honestly, it took me an afternoon to change my Eclipse to use Java 1.6 instead of Java 1.5, and it's probably a good idea for people to do it

Conference Season and Holidays

2013-05-01 Thread Joe Bowser
Hey Since it's May 1, that means that we're getting close to vacation season. If everyone can post their vacation and conf stuff on this thread, it'd be awesome. I'll start: * May 14-18: In SF for Google IO. * May 27-June 1: In Florida for JSConf. * June 24-July 7: On Vacation I think that

Re: [iOS] XmlHttpRequest and 401 Unauthorized

2013-05-02 Thread Joe Bowser
I think this is a webkit thing, since Android has the same problem. We have some authorization code, but I'm pretty certain that it doesn't do the right thing. That being said, I have no idea what the right thing is. On Thu, May 2, 2013 at 4:52 PM, Shazron wrote: > To summarize, this is an iOS t

Re: [iOS] XmlHttpRequest and 401 Unauthorized

2013-05-02 Thread Joe Bowser
Applicable Android counterpart: https://issues.apache.org/jira/browse/CB-2962 On Thu, May 2, 2013 at 4:54 PM, Joe Bowser wrote: > I think this is a webkit thing, since Android has the same problem. > We have some authorization code, but I'm pretty certain that it > doesn't

Pull requests need issues attached to them.

2013-05-03 Thread Joe Bowser
Hey I just reverted someone's pull request because it broke the nine-patch splashscreens on Cordova 2.7. Whenever we accept a pull request, we should do the following: * Make sure that it's actually fixing a bug, and not scratching a developer's itch * Make sure that there's a JIRA issue so th

[Android] Can rename DroidGap to CordovaActivity?

2013-05-06 Thread Joe Bowser
Hey I think it's a secret to no one that I despise the DroidGap class and that I would like to see it refactored into non-existance. However, given the fact that we don't have the time for that right now, can we at least rename it to CordovaActivity and create an empty DroidGap class derived from

Re: [Android] Can rename DroidGap to CordovaActivity?

2013-05-06 Thread Joe Bowser
than to satisfy a >> programmer itch? >> >> >> On Mon, May 6, 2013 at 1:30 PM, Joe Bowser wrote: >> >> > Hey >> > >> > I think it's a secret to no one that I despise the DroidGap class and >> > that I would like to s

Re: [Android] Can rename DroidGap to CordovaActivity?

2013-05-07 Thread Joe Bowser
19 AM, Simon MacDonald > wrote: > >> SGTM2 >> >> Simon Mac Donald >> http://hi.im/simonmacdonald >> >> >> On Mon, May 6, 2013 at 4:30 PM, Joe Bowser wrote: >> >> > Hey >> > >> > I think it's a secret to no one th

[Android] CB-2627: Should we implement this before or after 3.0?

2013-05-09 Thread Joe Bowser
Hey I'm looking at this issue right now, and it seems that this is actually implementing a Capture API more than it's implementing the File URI. Should this be broken out into a plugin, or brought into core, and is adopting a chunk of the Android Browser something that we want to be doing? Here'

Re: Changes to config.xml

2013-05-11 Thread Joe Bowser
Does this break the plugin or plugman? It shouldn't break the plugin if the class is properly specified. On Fri, May 10, 2013 at 6:30 PM, Steven Gill wrote: > Hey All, > > I noticed Andrew made some config.xml changes to help bring it up to widget > spec [1]. I wanted to make sure this was brough

[Android] Deprecate HTC 2.3 Android console.log support in 3.0

2013-05-13 Thread Joe Bowser
Hey There's a known bug in HTC's WebView that suppressed console.log on old Gingerbread devices. This is only on devices that run HTC Sense, and not devices like the Nexus One. How do people feel about deprecating console.log in 3.0. I know that Simon hated this particular chunk of code, and wa

[Android] What is DataResource and how does it work?

2013-05-13 Thread Joe Bowser
Hey I was currently looking at CB-2391, and I noticed that there were a lot of code changes made here such that I have no idea where the code that handles params actually is now. It appears to be in this DataResource API. That being said, I have no idea how this is supposed to work, since it jus

Re: [Android] Deprecate HTC 2.3 Android console.log support in 3.0

2013-05-13 Thread Joe Bowser
the DebugConsole plugin, and clobber >> > window.console as well as navigator.console. >> > >> > modulemapper.clobbers('cordova/plugin/windowsphone/console', >> > 'navigator.console'); >> > modulemapper.clobbers('cordova/plugin/

Re: Removal of from config.xml

2013-05-16 Thread Joe Bowser
I'm irritated by this change but not enough to -1 it. This has gone through our deprecation timeline and it's not like we decided on the new XML yesterday. I don't understand why we can't meet our own deadlines. Will this be gone by 3.0? If not, why not. On May 16, 2013 2:30 PM, "Filip Maj" wrote

Re: request: authority to own items in JIRA

2013-05-23 Thread Joe Bowser
Hey Thanks for adding yourself to the JIRA. I think we can probably set you up to have some tickets, but there's some housekeeping that we're going to have to do as well. 1. Have you signed the ICLA? This isn't required, but is probably a good idea if you're going to become a contributor. Please

Why does deviceready take a second to load on Android?

2013-05-23 Thread Joe Bowser
Hey I just tested Cordova with the latest JS on Android and I'm noticing a pretty solid lag in how long it takes for things like the platform name, version and UUID appear. Was there a recent change to deviceReady that causes it to be noticeably slower than it used to be? I'd figure that asking

Mobile-Spec media tests failing

2013-05-23 Thread Joe Bowser
Hey I'm noticing that the media tests are currently failing with the latest cordova.js that was added. Is anyone else noticing this on the latest tagged 2.8.0rc1? I'm testing on the Samsung Galaxy S4. Joe

Android Media is Borked

2013-05-24 Thread Joe Bowser
Hey It seems that the Android Media Playback/Record functionality no longer works. I can't figure out why, since there hasn't been a change in the past six months. Does anyone remember doing anything that would affect the functionality. Furthermore, I want to see this whole thing refactored. I

Android Audio isn't broken, the URIs being fed into the audio are

2013-05-24 Thread Joe Bowser
Hey After looking into the bug further, for some reason URIs such as http://cordova.apache.org/downloads/BlueZedEx.mp3 are losing slashes after the protocol. (i.e. http:/cordova.apache.org/downloads/BlueZedEx.mp3). This is causing Android to epic fail the media tests and I suspect that it would c

Re: Android Audio isn't broken, the URIs being fed into the audio are

2013-05-24 Thread Joe Bowser
ce dataResource = DataResource.initiateNewDataRequestForUri(url, this.webView.pluginManager, cordova, source); return dataResource.getRealFile().getPath(); } If it's an web URI, we shouldn't screw with it. Seriously! Joe On Fri, May 24, 2013 at 10:36 AM, Joe Bowser wrote: > Hey > > After look

Re: Android Audio isn't broken, the URIs being fed into the audio are

2013-05-24 Thread Joe Bowser
and people should run the tests now, since about half of the issues that come through JIRA could be tested with mobile-spec. On Fri, May 24, 2013 at 10:59 AM, Joe Bowser wrote: > OK, I was wrong. It turns out the DataResource code that was added in > doesn't have support for streaming a

Re: Android Audio isn't broken, the URIs being fed into the audio are

2013-05-24 Thread Joe Bowser
I'm going to revert the changes that he made to AudioHandler.java, and we > can try the media tests again. > > > > > On Fri, May 24, 2013 at 1:59 PM, Joe Bowser wrote: > >> OK, I was wrong. It turns out the DataResource code that was added in >> doesn't ha

Please fix or delete DataResource

2013-05-24 Thread Joe Bowser
Hey There's another issue with Cordova and DataResource. This time, the issue has to do with the fact that DataResource intercepts all requests in the IceCreamCordovaWebViewClient and that this is not letting the resources get rendered properly. This is excaberated by the fact that we're FileNot

CB-3512: Having trouble reproducing the issue

2013-05-24 Thread Joe Bowser
Hey After trying to track down the problem for the past hour, and going through the commits, I can't seem to find where the ICS rendering problem is happening, and I can't reproduce it with the code from master or the 2.8.x code. Given that we haven't tagged on Android, and given that I can't rep

Changes in Mobile-Spec are breaking Cordova on Android 4.0.3 ICS

2013-05-26 Thread Joe Bowser
Hey While I was setting up my environment on the Chromebook for JSConf, I noticed that I ran into the Android 4.0.3 bug again. It seems that when I was testing 4.0.3 last, I was using an old mobile-spec. After going through the project, it seems that the changes that were made to mobile-spec bre

Re: Please fix or delete DataResource

2013-05-27 Thread Joe Bowser
moving it today. > > > On Fri, May 24, 2013 at 6:29 PM, Joe Bowser wrote: > >> Hey >> >> There's another issue with Cordova and DataResource. This time, the >> issue has to do with the fact that DataResource intercepts all >> requests in the IceCre

Re: CB-3512: Having trouble reproducing the issue

2013-05-27 Thread Joe Bowser
> > Max - does it still happen on your device? > > > On Fri, May 24, 2013 at 8:03 PM, Joe Bowser wrote: > >> Hey >> >> After trying to track down the problem for the past hour, and going >> through the commits, I can't seem to find where the ICS rendering

Re: CB-3512: Having trouble reproducing the issue

2013-05-27 Thread Joe Bowser
BTW: I'm using my S2, not the S3. Also, I've confirmed it on the S2 and the Amazon Kindle Fire so far. I brought the S2 with me to help debug this. On Mon, May 27, 2013 at 10:48 AM, Joe Bowser wrote: > I actually can only reproduce this issue with the latest version of > Mobile

Re: Changes in Mobile-Spec are breaking Cordova on Android 4.0.3 ICS

2013-05-27 Thread Joe Bowser
's just revert it? Not sure why it was made in the first place? > > > On Sun, May 26, 2013 at 7:55 PM, Joe Bowser wrote: > >> Hey >> >> While I was setting up my environment on the Chromebook for JSConf, I >> noticed that I ran into the Android 4.0.3 bug agai

Re: Android Audio isn't broken, the URIs being fed into the audio are

2013-05-27 Thread Joe Bowser
sts? I'm still getting them on > twelve of those tests. Just want to make sure it's something on my end. > > On Fri, May 24, 2013 at 2:44 PM, Joe Bowser wrote: > > > I've already fixed this bug! We should be all good now! > > > > On Fri, May 24, 2013 a

Re: Android Audio isn't broken, the URIs being fed into the audio are

2013-05-27 Thread Joe Bowser
it in the automatic tests. If you saw it fixed in the automatic > tests then I probably just need to figure out what's wrong on my end. > > > On Mon, May 27, 2013 at 2:58 PM, Joe Bowser wrote: > >> I meant to test the manual tests. If you're still seeing NPObject, &g

Re: 2.8 release candidate

2013-05-29 Thread Joe Bowser
Are you doing the ant debug on the generated project? If so, then it sounds like the create scripts on Windows aren't creating the JAR and copying it over to the project. On Wed, May 29, 2013 at 2:25 PM, Benn Mapes wrote: > Has anyone else tried to build the latest (2.8.x branch) of cordova-andro

Re: 2.8.0

2013-05-30 Thread Joe Bowser
It doesn't help that I'm at JSConf. I'll tag Android if this helps moves things along. On May 30, 2013 1:15 PM, "Braden Shepherdson" wrote: > I think part of the delay here is because Andrew, who's been driving a > large part of the release process, is at the hospital having a baby today. > > We

Re: 2.8.0

2013-05-30 Thread Joe Bowser
gt;> > iOS >>>> > docs >>>> > CLI >>>> > Mobile Spec >>>> > >>>> > I talked with Shaz on tuesday, there are no blockers on iOS. He's at >>>> > fluent today, but I would imagine he could easily get

Re: Baby Grieve

2013-05-31 Thread Joe Bowser
Congrats! On Fri, May 31, 2013 at 10:09 AM, Gord Tanner wrote: > Congrats! > > > On Fri, May 31, 2013 at 10:05 AM, Bryan Higgins wrote: > >> Congrats!!! >> >> >> On Fri, May 31, 2013 at 10:03 AM, Steven Gill > >wrote: >> >> > Congrats Andrew!!! >> > >> > >> > On Fri, May 31, 2013 at 7:00 AM, Andr

Re: Widening the window (was: The Deprecation of Froyo)

2013-05-31 Thread Joe Bowser
On Fri, May 31, 2013 at 2:43 PM, Marcel Kinard wrote: > Starting off, specifically, I'm asking if we can keep Android 2.2 in Cordova > head. For how long? Until the OS usage in these markets drops into the > "doesn't matter" threshold. I suspect that will not be just a few months. And > does th

Re: [VOTE] Release Apache Cordova 2.8.0

2013-05-31 Thread Joe Bowser
+1 On Fri, May 31, 2013 at 3:19 PM, Shazron wrote: > +1 > > > On Fri, May 31, 2013 at 12:12 PM, Steven Gill wrote: > >> Hey, >> >> A release candidate for 2.8.0 is available at: >> >> https://dist.apache.org/repos/dist/release/cordova/ >> >> Please vote on releasing this package as Apache Cordova

Re: [VOTE] Release Apache Cordova 2.8.0

2013-06-04 Thread Joe Bowser
I only have 8 failures on my auto tests on Mobile spec with the HTC One runing 4.1.2. I think it is your contacts on your phone. BTW: Testing with your own contacts is not awesome. I've dialed Dooney Evans a couple of times. On Tue, Jun 4, 2013 at 11:28 AM, Filip Maj wrote: > Tested out latest

Cordova-JS Jake Tests Failing

2013-06-04 Thread Joe Bowser
Hey I'm not sure what happened, but now I'm getting 6 test failures on cordova-js when I try to build the 2.8.x branch. accelerometer it encountered a declaration exception module cordova/plugin/accelerometer not found builder it includes the module into the target Error: Expected undefi

Re: Cordova-JS Jake Tests Failing

2013-06-04 Thread Joe Bowser
Nevermind, I did a clean pull and it was all good. JS is tagged! On Tue, Jun 4, 2013 at 1:29 PM, Joe Bowser wrote: > Hey > > I'm not sure what happened, but now I'm getting 6 test failures on > cordova-js when I try to build the 2.8.x branch. > > accelerometer >

Re: chromeview

2013-06-05 Thread Joe Bowser
The last time we tested this approach, it was 16 MB, not 30 MB and many apps are upwards of that now anyway. I don't think 30 MB is a barrier if your app doesn't suck. Also, who got stuck being substitute Andrew? I need someone other than me to tag Android for 2.9.0, since I'll be on vacation th

[Android] Why is DataResource still in master?

2013-06-05 Thread Joe Bowser
Hey Why is DataResouce still in master? I don't want this code to go into 2.9.0 or 3.0.0, since I have no idea what this is trying to accomplish. I'm going to start ripping it out of master tomorrow if someone doesn't tell me why it should still be here. Seriously, WTF?

Re: Cordova vs Company workflow

2013-06-05 Thread Joe Bowser
The thing is that people don't start out as committers. It has to be earned over time. Committership is with an individual, not a company. On Jun 5, 2013 4:32 PM, "Filip Maj" wrote: > Agree with Lorin, if you are a committer, go ahead and push your changes > but please for the love of god test e

Re: [Android] Why is DataResource still in master?

2013-06-05 Thread Joe Bowser
it in isn't harmful, but perhaps leaving it > in unfixed in isn't helpful either. Lets see what Max/Braden say. > > > On Wed, Jun 5, 2013 at 4:54 PM, Joe Bowser wrote: > >> Hey >> >> Why is DataResouce still in master? I don't want this code to g

Re: [Android] Why is DataResource still in master?

2013-06-06 Thread Joe Bowser
t can > wait until Andrew is back. It isn't vital to the app harness, though it > prevents some things from working like app harness-hosted apps accessing > gallery URLs. > > Braden > > > On Wed, Jun 5, 2013 at 11:37 PM, Joe Bowser wrote: > > > The reverts were

Re: [Android] Why is DataResource still in master?

2013-06-06 Thread Joe Bowser
u give me some test cases where it's failing? Is there a bug? I > don't have a clear sense of the cases where it crashes or does the wrong > thing. > > Braden > > > On Thu, Jun 6, 2013 at 1:45 PM, Joe Bowser wrote: > >> I'm OK with it staying in there

Re: [Android] Why is DataResource still in master?

2013-06-06 Thread Joe Bowser
n Thu, Jun 6, 2013 at 11:01 AM, Joe Bowser wrote: > I created a new bug, but yeah, it's the Media AutoTests in MobileSpec. > Debugging shows that they're being fed a URI that is missing a / > > https://issues.apache.org/jira/browse/CB-3628 > > On Thu, Jun 6, 2013 at 10:57

Re: Android Network Plugin Breakout

2013-06-06 Thread Joe Bowser
How is this not a problem for the rest of the platforms? That's the first thing that I'm wondering right now. On Thu, Jun 6, 2013 at 2:37 PM, Tim Kim wrote: > Hey gang, > > So I'm trying to rip out the android network plugin, but it appears the > android exec relies on the network plugin for onl

Re: Android Network Plugin Breakout

2013-06-06 Thread Joe Bowser
ry, I don't have any easy answers for this one. On Thu, Jun 6, 2013 at 2:41 PM, Joe Bowser wrote: > How is this not a problem for the rest of the platforms? That's the > first thing that I'm wondering right now. > > On Thu, Jun 6, 2013 at 2:37 PM, Tim Kim wrote: >> He

Re: Android Network Plugin Breakout

2013-06-06 Thread Joe Bowser
e/pause/resume and other > events of the app lifecycle to be plausibly core for all platforms. > > On Thu, Jun 6, 2013 at 4:44 PM, Joe Bowser wrote: >> Actually, online/offline has to be core, because it's part of the >> bridge. We can't rip that out because some pla

Re: Android Network Plugin Breakout

2013-06-06 Thread Joe Bowser
Oh yeah, Test 2.3, 4.0 and 4.1. On Thu, Jun 6, 2013 at 3:19 PM, Joe Bowser wrote: > The thing is that this may be for the browser, and not for our plugin. > The event is being hijacked and used to trigger the JS to check the > queue to see whether or not it should be firing a JS event o

Re: Android Network Plugin Breakout

2013-06-06 Thread Joe Bowser
Wait, aren't all the plugins already broken out on Android now? I don't remember this code being dependent on the plugin itself, just the online/offline event. On Thu, Jun 6, 2013 at 3:30 PM, Brian LeRoux wrote: > sgtm > > On Thu, Jun 6, 2013 at 5:19 PM, Joe Bowser wrote: &

Re: android commit: CB-3736: Cleaning up code so that this makes more sense. Variables are OK

2013-06-08 Thread Joe Bowser
t;http://git-wip-us.apache.org/repos/asf/cordova-android/commit/e52d4fc0 > >Tree: > http://git-wip-us.apache.org/repos/asf/cordova-android/tree/e52d4fc0 > >Diff: > http://git-wip-us.apache.org/repos/asf/cordova-android/diff/e52d4fc0 > > > >Branch: refs/heads/master > >

Re: 2.9.0 + RC objectives

2013-06-10 Thread Joe Bowser
Agreed! Do we have to have DataResouce in 2.9? I would prefer to not have it until after 3.0, given how badly it broke 2.8.0rc1. On Mon, Jun 10, 2013 at 1:40 PM, Brian LeRoux wrote: > I'm down for all this. Lets make 2.9 as much about hardening as > possible. The only 'new' stuff I'd like to soc

Plugin and CordovaPlugin

2013-06-10 Thread Joe Bowser
Hey I know that we have recently deprecated Plugin in favour for CordovaPlugin, but it seems that we really screwed up the deprecation and now one of the flagship apps that use PhoneGap no longer has a valid upgrade path. I think that this is a major problem that is biting us in the ass, so I wou

Re: Plugin and CordovaPlugin

2013-06-10 Thread Joe Bowser
7;t even write. So the empirical evidence is the >> users are not ready for this change. >> >> Simon Mac Donald >> http://hi.im/simonmacdonald >> >> >> On Mon, Jun 10, 2013 at 7:19 PM, Joe Bowser wrote: >>> Hey >>> >>> I kn

Re: Plugin and CordovaPlugin

2013-06-10 Thread Joe Bowser
my iPhone5 > > On Jun 10, 2013, at 8:26 PM, Joe Bowser wrote: > > OK, if we bring it back, how long should we bring it back for? We > can't keep it around forever. The only reason that I want to bring it > back is because I feel that it was unfair to the users to have this &

Re: Plugin and CordovaPlugin

2013-06-10 Thread Joe Bowser
PM, "Steven Gill" wrote: > >>2.8.1? >> >> >>On Mon, Jun 10, 2013 at 9:13 PM, Joe Bowser wrote: >> >>> This just affects Android. >>> >>> On Mon, Jun 10, 2013 at 8:56 PM, Jesse MacFadyen >>> wrote: >>> > Can

Re: Plugin and CordovaPlugin

2013-06-11 Thread Joe Bowser
On Tue, Jun 11, 2013 at 5:18 AM, Lucas Holmquist wrote: > This is sort of a tough one i think, how long has this deprecation notice > been in the code? Does it matter if the deprecation is in code? Our users don't read code, which is painfully obvious. The fact is that this was deprecated in c

Re: Plugin and CordovaPlugin

2013-06-11 Thread Joe Bowser
On Tue, Jun 11, 2013 at 6:56 AM, Braden Shepherdson wrote: > I'm indifferent about adding this back. > > What I do want to comment on is that this seems like a good precursor of > the furor that 3.0 is likely to create. Lots of things are going to change, > and all of these old plugins are going t

Re: Plugin and CordovaPlugin

2013-06-11 Thread Joe Bowser
nds like a good idea, but we want to make sure > any announcement of 3.0 is accompanied by our deprecation plan for 2.x. > > Braden > > > On Tue, Jun 11, 2013 at 10:12 AM, Joe Bowser wrote: > >> On Tue, Jun 11, 2013 at 6:56 AM, Braden Shepherdson >> wrote: >&g

Re: Plugin and CordovaPlugin

2013-06-11 Thread Joe Bowser
critical bug fixes? > > > Simon Mac Donald > http://hi.im/simonmacdonald > > > On Tue, Jun 11, 2013 at 1:53 PM, Joe Bowser wrote: > >> OK, We actually did deprecate this properly. I don't know how I >> missed this edit Simon did on the Wiki: >> >> h

Re: Any problem with making DirectoryManager.getTempDirectoryPath public

2013-06-11 Thread Joe Bowser
It's a part of plugin breakout. The main question is whether DirectoryManager should be a public API by documenting it, since a plugin needs it to function, not should we make it public. But yeah, make it public Steve! On Tue, Jun 11, 2013 at 12:48 PM, Simon MacDonald wrote: > Huh, you shouldn'

We need better contributions from new people

2013-06-11 Thread Joe Bowser
Hey I decided to check my e-mail and respond to an issue. It turns out that we're not properly testing or even checking the pull requests that we're getting into the project. The bug in question is CB-3766, which was caused by a patch accepted to fix CB-2458. The error isn't totally obvious, and

Re: We need better contributions from new people

2013-06-12 Thread Joe Bowser
The problem with this approach is that we shouldn't rely on just mobile-spec for our testing. In this example, I wasn't able to fully reproduce what he was doing because the person who filed it refused to provide me with a project. That being said, I was able to find that I was getting weird TIMEO

2.9.0rc1 this coming monday??

2013-06-12 Thread Joe Bowser
Hey I know this is pretty soon, but how does a 2.9.0rc1 on Monday sound? Since this is supposed to be a hardening release anyway, I don't see why we shouldn't start with the RCs. Any thoughts? Joe

Re: We need better contributions from new people

2013-06-13 Thread Joe Bowser
n the people writing the code will follow it (myself included). All I'm asking for is some testing, not all the tests to be run. Going from one extreme to another isn't going to be helpful. On Jun 13, 2013 8:02 AM, "Marcel Kinard" wrote: > On Jun 12, 2013, at 6:10 PM,

Re: Any problem with making DirectoryManager.getTempDirectoryPath public

2013-06-13 Thread Joe Bowser
nes in question: >> >> testFileExists >> >> getFreeDiskSpace >> >> testSaveLocationExists >> >> >> >> Looking like we should definitely make DirectoryManager as a public api >> >> now. >> >> >> >> >> >>

Re: 2.9.0rc1 this coming monday??

2013-06-17 Thread Joe Bowser
hasn't been any with me being away at WWDC this week, but if >> >> that's >> >> > > where the wind blows I am but a feather. Will try to get more issues >> >> > > resolved by rc2. >> >> > > >> >> > > >>

Re: Baby Grieve

2013-06-17 Thread Joe Bowser
Good to have you back! On Mon, Jun 17, 2013 at 10:36 AM, Filip Maj wrote: > Welcome back Andrew! > > On 6/17/13 10:35 AM, "Andrew Grieve" wrote: > >>Thanks everyone! >> >>I'm back this week! I still have 2 more weeks of paternity to take at some >>point in the future though. At this point, it is

Re: Android: Use source files instead of .jar file

2013-06-17 Thread Joe Bowser
-1 This only caters to a minority of our users. Most of our users can't debug Cordova, since they can't write Java (or even Javascript) well. I think this will have far more things break and we'll have a huge backlash from our mainstream users, just like when we deprecated plugins. On Jun 17, 201

Re: 2.9.0rc1 this coming monday??

2013-06-17 Thread Joe Bowser
> >> >> >>>> > >> Maybe this Untappd issue: >> >>>> https://issues.apache.org/jira/browse/CB-3574 >> >>>> > >> >> >>>> > >> >> >>>>

Re: Android: Use source files instead of .jar file

2013-06-17 Thread Joe Bowser
have, as well as getting more people looking at the code and >>understanding it better. >> >>If users don't want to look at the source at all they can just treat the >>cordovaLib folder like it's a .jar and not touch it. >> >> >>On Mon, Jun 17, 20

Whitelist and Wildcards

2013-06-17 Thread Joe Bowser
Hey I just answered a question on StackOverflow about the whitelist and wildcards. Currently, on Android, doing this: doesn't work for accessing subdomains, and you have to specify subdomains=true. This seems counterintutive to me. I'm wondering if this is the case on other platforms, and i

Bugs for 2.9.x

2013-06-18 Thread Joe Bowser
Hey I'm going through the process for RC1, and I notice that for Android, there's only one bug marked to be fixed for 2.9.x. If you have anything that you want to get into 2.9.x, please add the fix version for 2.9.x so we can get an idea of what's broken on this release, and whether we can get it

Re: Cordova Blog

2013-06-20 Thread Joe Bowser
Currently, PhoneGap aggregates the blog posts of many committers at phonegap.com/blog. The downside of this is that it's an Adobe blog, and it's not Apache Cordova. Apache Cordova should probably have its own blog, but I see a lot of the same content being in two different places. If someone wan

Re: Review Request: Fixing exec bug.

2013-06-21 Thread Joe Bowser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12013/#review22286 --- Ship it! Ship It! - Joe Bowser On June 21, 2013, 5:21 p.m

Re: Review Request: Fixing exec bug.

2013-06-21 Thread Joe Bowser
> On June 21, 2013, 11:47 p.m., Joe Bowser wrote: > > Ship It! I really just wanted to push the "Ship it!" button, but yeah, this looks good. - Joe --- This is an automatically generated e-mail. To

Re: Android - Removing the .api namespace

2013-06-24 Thread Joe Bowser
Can we do this post-3.0? This change seems a bit last minute. On Jun 24, 2013 7:57 AM, "Andrew Grieve" wrote: > On the Java side of things, there are a few files in the > org.apache.cordova.api namespace. > > I'd like to remove this namespace and put all Cordova classes under > org.apache.cordova

Re: Android - Removing the .api namespace

2013-06-24 Thread Joe Bowser
gt; > Doesn't feel that last minute to me... we haven't even shipped 2.9 yet. > > > > > On Mon, Jun 24, 2013 at 11:00 AM, Joe Bowser wrote: > >> Can we do this post-3.0? This change seems a bit last minute. >> On Jun 24, 2013 7:57 AM, "Andrew Gr

Re: Cordova 2.9.0 Final

2013-06-24 Thread Joe Bowser
So, we're using coho for tagging everything now? That seems like a major process change. On Mon, Jun 24, 2013 at 7:10 AM, Andrew Grieve wrote: > Created Release bug: https://issues.apache.org/jira/browse/CB-3981 > > Please update the subtasks if I've missed any steps. > > > On Fri, Jun 21, 2013

Re: Cordova 2.9.0 Final

2013-06-25 Thread Joe Bowser
e in process, but it does automate some steps of > the existing process. > > > On Mon, Jun 24, 2013 at 6:51 PM, Brian LeRoux wrote: > >> Yes. The idea would be, as it always has been, the platform >> maintainers tag as their "vote". That tag says, 'hey

  1   2   3   4   5   6   7   8   9   10   >