Re: [PR] report: June 2024 [cordova-apache-board-reports]

2024-06-12 Thread via GitHub
erisu merged PR #22: URL: https://github.com/apache/cordova-apache-board-reports/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...

Re: [PR] Cordova iOS 8 proposal [cordova-discuss]

2024-06-12 Thread via GitHub
dpogue commented on PR #113: URL: https://github.com/apache/cordova-discuss/pull/113#issuecomment-2162477595 > I'm not saying we should go to 15 or anything, but requiring iOS 14+ for `WKScriptMessageHandlerWithReply` I don't think is a problem. But maintaining backwards compatibility with

Re: [VOTE] cordova-plugin-device 3.0.0 Release

2024-06-12 Thread Norman Breau
I vote +1: - NPM Audit is green - NPM test passes - Android Paramedic Test passes - Verified Archive - Verified Tags On 2024-06-11 22:49, Bryan Ellis wrote: Please review and vote on this cordova-plugin-device Release v3.0.0 by replying to this email (and keep discussion on the DISCUSS thread)

Re: [PR] Cordova iOS 8 proposal [cordova-discuss]

2024-06-12 Thread via GitHub
jcesarmobile commented on PR #113: URL: https://github.com/apache/cordova-discuss/pull/113#issuecomment-2163606990 A problem with moving to Swift templates is that it will break all push plugins since they rely on an Objective-C category on the AppDelegate for adding the method that gets th

Re: [PR] Cordova iOS 8 proposal [cordova-discuss]

2024-06-12 Thread via GitHub
dpogue commented on PR #113: URL: https://github.com/apache/cordova-discuss/pull/113#issuecomment-2163618052 It should still be possible to use Objective-C categories to add the methods for handling push token events, but it would need to extend the `CDVAppDelegate` base class rather than t