Re: [External] Re: [VOTE] cordova-plugin-splashscreen release 6.0.1 patch release

2022-04-05 Thread Brust, Tim
I vote +1, thanks for the release, Niklas! * Changes look good * Coho verify archive * Coho verify tags -- Tim Brust, Senior Product Engineer tim.br...@sinnerschrader.com SinnerSchrader Deutschland GmbH Part of Accenture Interactive Völckersstra

Re: [External] [DISCUSS] cordova-plugin-splashscreen release 6.0.1

2022-04-05 Thread Brust, Tim
One minor nit that can be changed in a follow up commit: In the RELEASENOTES.md file a space is missing after the [GH-xxx] link and the short text. -- Tim Brust, Senior Product Engineer tim.br...@sinnerschrader.com SinnerSchrader Deutschland GmbH Part of Acc

Re: [External] [DISCUSS] cordova-plugin-splashscreen release 6.0.1

2022-04-05 Thread Niklas Merz
Thanks Tim. I think most users read the the releasnotes on GitHub and the blog. I fixed it there. Therefore I also think this not a reason to do the release again. On April 5, 2022, Tim Brust wrote: > One minor nit that can be changed in a follow up commit: > In the RELEASENOTES.md file a space i

[DISCUSS] cordova-plugin-device 2.1.0 Release

2022-04-05 Thread Bryan Ellis
Does anyone have any reason to delay a cordova-plugin-device release (2.1.0)? Any additional outstanding changes to land? If not, I will start the release process shortly. Change Log https://github.com/apache/cordova-plugin-device/compare/rel/2.0.3...master