Re: [External] Cordova Plugin InAppBrowser minor release

2020-11-17 Thread Brust, Tim
Hi Niklas, thanks for taking the initiative to make the release. I’d like to review and merge PR 817 [1], it’s a really small change for the typings – I aim to review it in the next hour(s), at a first glimpse the code already looks good. Thanks, Tim [1] - https://github.com/apache/cordova-plu

[GitHub] [cordova-discuss] timbru31 commented on issue #57: cordova-android 6.0.0 (installed by cordova-cli 6.4.0) drops result with u2028/u2029

2020-11-17 Thread GitBox
timbru31 commented on issue #57: URL: https://github.com/apache/cordova-discuss/issues/57#issuecomment-728810659 I'm closing this stale issue, I bet this already has been solved. This is an automated message from the Apache G

[GitHub] [cordova-discuss] timbru31 closed issue #57: cordova-android 6.0.0 (installed by cordova-cli 6.4.0) drops result with u2028/u2029

2020-11-17 Thread GitBox
timbru31 closed issue #57: URL: https://github.com/apache/cordova-discuss/issues/57 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [DISCUSS] Cordova Plugin InAppBrowser minor release

2020-11-17 Thread Niklas Merz
Hi everyone, Thanks Tim. I just merged the other PR and did some final tests. If nothing comes up I can start the release in about an hour . Looking forward for your votes :-) November 17, 2020 9:55 AM, "Brust, Tim" wrote: > Hi Niklas, > > thanks for taking the initiative to make the releas

[VOTE] Cordova Plugin InAppBrowser 4.1.0 Release

2020-11-17 Thread Niklas Merz
Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/cordova-plugin-inappbrowser-4.1.0/ The packages were published from their

Re: [External] Re: [VOTE] Geolocation Plugin Release

2020-11-17 Thread Norman Breau
I vote +1 * Confirmed archive * Confirmed tags * No flagged licenses. * audit licenses On Nov 16 2020, at 11:39 am, Brust, Tim wrote: > I vote +1: > > > * coho verify-archive passes > * coho verify-tags passes > * npm audit passes > * npm test passes > * re-reviewed changes, they make sense > --

Re: [VOTE] Cordova Plugin InAppBrowser 4.1.0 Release

2020-11-17 Thread Norman Breau
I vote +1: * Audit licenses * Ran check-license * Verified tags * Verified archive On Nov 17 2020, at 2:31 pm, Niklas Merz wrote: > Please review and vote on the release of this plugins release > by replying to this email (and keep discussion on the DISCUSS thread) > > The plugins have been publ