Re: [DISCUSS] Cordova-Common 3.2.1 Release

2019-10-31 Thread Mike Murkovic
Very hopeful for this because of CB-14108 (seen on https://github.com/apache/cordova-common/pull/89) Currently dialing up to the nightly build of cordova-cli. On 2019/10/15 12:09:40, Tim Brust wrote: > Friendly reminder- are you still working on this? :)> > > On Thu, Sep 19, 2019 at 3:52 AM Brya

Nightly build #1219 for cordova has succeeded!

2019-10-31 Thread Apache Jenkins Server
Nightly build #1219 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/1219/consoleFull - Jenkins for Apache Cordova ---

Re: [VOTE] Cordova-Common 3.2.1 Release

2019-10-31 Thread Bryan Ellis
**Bump** If anyone has time, can you please take a look and vote on this cordova-common release patch? The main purpose of this patch release is to revert a PR that causes `plugin install` to not set permissions to the `AndroidManifest.xml` when `config.xml` and `plugin.xml` defines the same elem

Re: [DISCUSS] Cordova-Common 3.2.1 Release

2019-10-31 Thread Chris Brody
I took a quick look at the VOTE thread, unfortunately I did not have much time to understand what is going on with the reverted PR in the past. Unfortunately I do not really understand too well what is going on with both the forward change and the backward change. >From a quick look, my understand

Re: [VOTE] Cordova-Common 3.2.1 Release

2019-10-31 Thread Ken Naito
+1 * coho verify-archive OK * coho verify-tags OK * The commit https://github.com/apache/cordova-common/commit/bd32d6c12b43e4e93b33cf4c39121cac5000e1d8 is green On 2019/10/28 19:13, Bryan Ellis wrote: Please review and vote on this Cordova Common Patch Release v3.2.1 by replying to this em

Re: [DISCUSS] Cordova-Common 3.2.1 Release

2019-10-31 Thread Bryan Ellis
@Brody The removal of those test cases is expected because the original PR introduced them to validate the changes that were to resolve the incorrect config munging count. Because of the incorrect count, when uninstalling plugin, it can be seen that the recovery process of the AndroidManifest and