Re: [Proposal] Supporting Proper DATA_URL for Camera plugin

2019-03-01 Thread Oliver Salzburg
What is the downside of just introducing new options and not creating a breaking change? And what is the positive impact of this change that it necessitates that every consumer of the existing API change their code? IMHO that has not been made clear enough. On 01/03/2019 02:17, Hazem Saleh wro

Re: [Proposal] Supporting Proper DATA_URL for Camera plugin

2019-03-01 Thread Jesse
The downside would be that it would add yet another quirky implementation, while this about not dragging along the existing quirky non-standard implementation. Existing users who don't want to change their code don't need to change anything. I expect usage of this api is quite low already ( anecdo

Re: [Proposal] Supporting Proper DATA_URL for Camera plugin

2019-03-01 Thread Hazem Saleh
I agree with Jesse. IMHO regarding the positive impact of this change is that it simply fixes a bug that exists for a long time ago, and will make the code that consumes this API more cleaner, the user will not have hard code a DATA url prefix every-time before the returned base64 string. On Fri,

Nightly build #1017 for cordova has succeeded!

2019-03-01 Thread Apache Jenkins Server
Nightly build #1017 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/1017/consoleFull - Jenkins for Apache Cordova ---