We are now down to the following:
* https://github.com/apache/cordova-android/pull/655 for which I just
limited the scope as discussed on GitHub
* https://github.com/apache/cordova-android/issues/666 where I listed
some alternative solutions
The easy solution to bug 666 would be to revert PR 664,
On Tue, Feb 12, 2019 at 2:47 PM Chris Brody wrote:
> [...]
> The easy solution to bug 666 would be to revert PR 664, which would
> consequently reintroduce cordova-android bug 629. I would favor
> resolving it by reading the default targetSdkVersion value from
> project.properties, as briefly disc
my bad, thanks for the feedback
On Mon, Feb 11, 2019 at 8:22 PM Shazron wrote:
>
> IMO I would generally avoid this type of thing unless it was a really
> significant change (the change seems trivial).
>
>
> On Tue, Feb 12, 2019 at 4:09 AM Chris Brody wrote:
>
> > I listed you as a co-author sin
I would definitely agree that we should do it right and get rid of
project.properties, along with the other Eclipse artifacts. I already
raised issues on GitHub to get rid of project.properties and other
artifacts from Eclipse.
I think none of us have the extra time to go through the needed
cleanu
I also agree.
Since it seems everyone has limited time, I recommend that we revert the
breaking change and merge in the PR that has the limited scope change and
resolves the main issues that most people face.
Just test to make sure that the other WIP change is OK.
After release, we can return
I will revert the breaking change from PR #664 and finish PR #665 then.
On Tue, Feb 12, 2019 at 6:50 PM Bryan Ellis wrote:
>
> I also agree.
>
> Since it seems everyone has limited time, I recommend that we revert the
> breaking change and merge in the PR that has the limited scope change and
>
A couple followup items:
* I suspect we should update the documentation as well
* I think it would be good if we could deprecate
android-targetSdkVersion, android-maxSdkVersion, and maybe some
related items in config.xml, as I had loosely implied on GitHub. I
wonder if we want to add the deprecatio
Nightly build #1000 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g
cordova@nightly'
For details check build console at
https://builds.apache.org/job/cordova-nightly/1000/consoleFull
-
Jenkins for Apache Cordova
---
Thank you, Brody, for your investigation into the build configuration and quick
fixes to get the repo releasable.
For the follow-up items.
* Documentation is not a blocker for the cordova-android repo release as the
docs are in cordova-docs. It is though recommended to be updated so we can
quic
