[DISCUSS][DOCS] Revert a change

2017-09-13 Thread Shazron
This relates solely to instructions on how to *build* the site, and not the contents of the site itself. Bringing this up here for discussion since a committer wants to revert a change by another committer, and there is potential for disagreement. The pull request to revert is here: https://githu

[DOCS] Removing the last remnants of React

2017-09-13 Thread Shazron
Thanks to Tommy, one of Cordova's committers, for this! https://github.com/apache/cordova-docs/pull/728 This removes our only use of React, in plugins.cordova.io This removal is required by Apache Legal: https://issues.apache.org/jira/browse/CB-13025

Re: [DISCUSS][DOCS] Revert a change

2017-09-13 Thread Jan Piotrowski
I am actually surprised deploying is a manual process at all. Having read the steps, I understand why of course. As a person that jumps in on all kinds of projects, I absolutely prefer docs that list each and every little step needed (including all the `cd` etc). The need for manual steps or chec

[GitHub] cordova-plugin-console issue #25: CB-13170 - final changes and release of po...

2017-09-13 Thread janpio
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-console/pull/25 Nice. Does this mean that the 2.0.0 of the console plugin can be installed on `cordova-ios` 4.5.0 without causing the build problems? --- ---

[GitHub] cordova-plugin-inappbrowser issue #210: CB-12367: Modernize styling of iOS I...

2017-09-13 Thread artyom-dorokhov
Github user artyom-dorokhov commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/210 i'd love to have it merged. current version of inappbrowser with its styling looks like from 90's --- --

[GitHub] cordova-plugin-inappbrowser issue #210: CB-12367: Modernize styling of iOS I...

2017-09-13 Thread timbru31
Github user timbru31 commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/210 @artyom-dorokhov you might want to check out https://github.com/EddyVerbruggen/cordova-plugin-safariviewcontroller ---

[GitHub] cordova-plugin-inappbrowser issue #210: CB-12367: Modernize styling of iOS I...

2017-09-13 Thread artyom-dorokhov
Github user artyom-dorokhov commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/210 @timbru31 thanks for the tip, but inappbrowser can inject js/css on a third-party page and it's the main point of using it. ---

Re: [DISCUSS][DOCS] Revert a change

2017-09-13 Thread Dmitry Blotsky
Yes, ideally our deployment process should be automated. Also, it should *not* be an SVN commit. It should be an rsync or an scp command. I would support any initiatives to move to either one of those. If we had automated deployment, this discussion would be moot. How much would it cost us to j

Re: [DISCUSS][DOCS] Revert a change

2017-09-13 Thread Filip Maj
We have an issue posted to make docs publishing automatic: https://issues.apache.org/jira/browse/CB-13162 Not to derail the topic, but there is a longer wishlist in that issue, and I do think achieving the goals in that issue would require reworking the docs repository quite a bit. We can discuss

[GitHub] cordova-docs issue #729: Fixed up 'deployment' docs in README.md.

2017-09-13 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-docs/pull/729 LGTM. I personally prefer `npm run serve` over `node_modules/.bin/gulp build --prod` but can deal with it. --- ---

Re: [DISCUSS][DOCS] Revert a change

2017-09-13 Thread Steven Gill
PR looks fine to me. Keep the svn commit stuff. Lets merge and move on On Wed, Sep 13, 2017 at 10:08 AM, Filip Maj wrote: > We have an issue posted to make docs publishing automatic: > https://issues.apache.org/jira/browse/CB-13162 > > Not to derail the topic, but there is a longer wishlist in t

Re: [DISCUSS][DOCS] Revert a change

2017-09-13 Thread Dmitry Blotsky
@fil: why is reworking the docs repo needed for automatic deployment? @steve: could you merge it then? I'm far too rusty on my Cordova-ing to remember how to set up my remotes to push to the ASF repo, sorry. :( Kindly, Dmitry > On Sep 13, 2017, at 1:08 PM, Filip Maj wrote: > > We have an issu

Re: [DISCUSS][DOCS] Revert a change

2017-09-13 Thread Filip Maj
To be clear, we don't need to redesign anything to automate docs deployment. It is in the realm of possibility to simply automate what we have today. I just feel like what we have today is a design where translations are an afterthought, which I think is a bad tradeoff, especially given the popular

Re: [DISCUSS][DOCS] Revert a change

2017-09-13 Thread Dmitry Blotsky
So, translations were always a semi-manual process. In that sense, they're as much an "afterthought" as they ever were. However the current design permits automation of translation within its build process pretty cleanly. It's just a matter of implementing it. It's not trivial, but it's about as

[BUILD STATUS] 3 status.cordova.io failures

2017-09-13 Thread Shazron
Looks like the redirect didn't work since the move to Github Apache Org for cordova-status, fixed. 3 components have build failures: 1. cordova-paramedic (Travis fail, AppVeyor fail) 2. cordova-fetch (Travis pass, AppVeyor fail) 3. cordova-android (Travis - something wrong with the bui

[GitHub] cordova-docs pull request #729: Fixed up 'deployment' docs in README.md.

2017-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/729 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

Nightly build #484 for cordova has succeeded!

2017-09-13 Thread Apache Jenkins Server
Nightly build #484 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/484/consoleFull - Jenkins for Apache Cordova -