[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

2017-07-14 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-windows/pull/237 Cb 12636 Fix check_reqs to properly find VS 2017 ### Platforms affected this one! ### What does this PR do? Teaches `cordova-windows` to properly recognize VS 2017 install

[GitHub] cordova-windows pull request #238: CB-13022 Correct a VS installation warnin...

2017-07-14 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-windows/pull/238 CB-13022 Correct a VS installation warning during check_reqs ### Platforms affected this one! ### What does this PR do? Corrects a warning message that asks a user to inst

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

2017-07-14 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/237#discussion_r127481238 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -171,6 +182,54 @@ function getAvailableUAPVersions() { }); retu

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

2017-07-14 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/237#discussion_r127480919 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -171,6 +182,54 @@ function getAvailableUAPVersions() { }); retu

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

2017-07-14 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/237#discussion_r127480213 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -171,6 +182,54 @@ function getAvailableUAPVersions() { }); retu

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

2017-07-14 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/237#discussion_r127480714 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -171,6 +182,54 @@ function getAvailableUAPVersions() { }); retu

[GitHub] cordova-windows pull request #237: Cb 12636 Fix check_reqs to properly find ...

2017-07-14 Thread matrosov-nikita
Github user matrosov-nikita commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/237#discussion_r127481484 --- Diff: template/cordova/lib/MSBuildTools.js --- @@ -171,6 +182,54 @@ function getAvailableUAPVersions() { }); retu

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-07-14 Thread karlachavez
Github user karlachavez commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 Your suggest works fine. The splashscreen is not displayed on the device we had the problem, but on the rest of devices. We are going to take this workaround until an officia

[GitHub] cordova-android pull request #395: CB-12423: make explicit JDK 1.8 or greate...

2017-07-14 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-android/pull/395 CB-12423: make explicit JDK 1.8 or greater is needed in the README. Lining it up with https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#installing-the-requirements

[GitHub] cordova-browser pull request #37: CB-12895 : replaced jshint with eslint

2017-07-14 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-browser/pull/37 CB-12895 : replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing has been done on thi

[GitHub] cordova-android issue #395: CB-12423: make explicit JDK 1.8 or greater is ne...

2017-07-14 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/395 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr&el=h1) Report > Merging [#395](https://codecov.io/gh/apache/cordova-android/pull/395?src=pr&el=desc) into [

[GitHub] cordova-android issue #395: CB-12423: make explicit JDK 1.8 or greater is ne...

2017-07-14 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/395 You cool with this change @infil00p ? Just making sure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cordova-docs pull request #715: CB-12735: AllowInlineMediaPlayback preferenc...

2017-07-14 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-docs/pull/715 CB-12735: AllowInlineMediaPlayback preference requires different https://issues.apache.org/jira/browse/CB-12735 As of iOS 10, the attribute name to add to elements to support inline media

[GitHub] cordova-docs pull request #715: CB-12735: AllowInlineMediaPlayback preferenc...

2017-07-14 Thread filmaj
Github user filmaj closed the pull request at: https://github.com/apache/cordova-docs/pull/715 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-camera pull request #280: (browser) automatically click on fi...

2017-07-14 Thread MaxXx1313
GitHub user MaxXx1313 opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/280 (browser) automatically click on file input field ### Platforms affected Browser ### What does this PR do? Skip the step to load an image from file system

[GitHub] cordova-android issue #395: CB-12423: make explicit JDK 1.8 or greater is ne...

2017-07-14 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/395 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-file-transfer pull request #185: CB-7995: document that `File...

2017-07-14 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/185 CB-7995: document that `FileTransferError.exception` on iOS is never used https://issues.apache.org/jira/browse/CB-7995 You can merge this pull request into a Git reposito

[GitHub] cordova-android pull request #395: CB-12423: make explicit JDK 1.8 or greate...

2017-07-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/395 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-android issue #393: Fix for Jira issue CB-12981

2017-07-14 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/393 This somehow broke the project creation test. Can you figure out what happened with your PR that caused this to break? --- If your project is set up for it, you can reply to this email an

[GitHub] cordova-android issue #393: Fix for Jira issue CB-12981

2017-07-14 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/393 I think if the PR author rebases w/ latest master, they will find that test no longer exists / no longer applicable. I bet it was Travis VM being too slow / our timeout for the create

[GitHub] cordova-android issue #310: [CB-10916] Support display name for Android

2017-07-14 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/310 This appears to have fell by the wayside. Why hasn't this been pulled into cordova-android? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-android issue #310: [CB-10916] Support display name for Android

2017-07-14 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-android/pull/310 Sorry, been on vacation the past few weeks, but it looks like we've already bundled in the required version of cordova-common, so this is good to go! --- If your project is set up for it, yo

[GitHub] cordova-android pull request #310: [CB-10916] Support display name for Andro...

2017-07-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/310 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-plugin-file-transfer pull request #185: CB-7995: document that `File...

2017-07-14 Thread filmaj
Github user filmaj closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/185 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugman pull request #90: CB-12895 : setup eslint and removed jshint

2017-07-14 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugman/pull/90 CB-12895 : setup eslint and removed jshint ### Platforms affected ### What does this PR do? Setup eslint and removed jshint ### What testing has bee

[GitHub] cordova-plugin-wkwebview-engine issue #38: Dynamic Swipe Preference

2017-07-14 Thread ccorcos
Github user ccorcos commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/38 @shazron does this PR have any chance of making it in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-camera pull request #281: CB-12895 : replaced jshint with esl...

2017-07-14 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/281 CB-12895 : replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing has been done

[GitHub] cordova-osx pull request #38: CB-12895 : replaced jshint with eslint

2017-07-14 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-osx/pull/38 CB-12895 : replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing has been done on th

[GitHub] cordova-plugman pull request #90: CB-12895 : setup eslint and removed jshint

2017-07-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugman/pull/90 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request #236: CB -12895 : updated files to use eslint i...

2017-07-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/236 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-osx pull request #38: CB-12895 : replaced jshint with eslint

2017-07-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios pull request #327: CB-12895: replaced jshint with eslint

2017-07-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/327 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Nightly build #429 for cordova has succeeded!

2017-07-14 Thread Apache Jenkins Server
Nightly build #429 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/429/consoleFull - Jenkins for Apache Cordova -

[GitHub] cordova-plugin-splashscreen issue #109: CB-11602: (android) Fix bug AutoHide...

2017-07-14 Thread alanhg
Github user alanhg commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/109 if AutoHideSplashScreen works for android. how to use if i want to hide splashscreen manually --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-07-14 Thread stalniy
Github user stalniy commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 @filmaj any news on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat