[GitHub] cordova-ios pull request #228: [CB-10916] Support display name for iOS

2017-06-07 Thread dpogue
GitHub user dpogue reopened a pull request: https://github.com/apache/cordova-ios/pull/228 [CB-10916] Support display name for iOS This is the iOS Platform API support side of https://github.com/apache/cordova-lib/pull/453. You can merge this pull request into a Git repository by

[GitHub] cordova-ios pull request #228: [CB-10916] Support display name for iOS

2017-06-07 Thread dpogue
Github user dpogue closed the pull request at: https://github.com/apache/cordova-ios/pull/228 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS

2017-06-07 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/228 @shazron All good now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-06-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/150/commits/eaabd8e84e08ef0090d67f32b5

[GitHub] cordova-plugin-media pull request #140: Fixed the link to report issues

2017-06-07 Thread dellagustin
Github user dellagustin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/140#discussion_r120577449 --- Diff: README.md --- @@ -46,7 +46,7 @@ function onDeviceReady() { } ``` -Report issues with this plugin on the [Apac

[GitHub] cordova-plugin-media-capture pull request #79: CB-12882: (ios): adds support...

2017-06-07 Thread stalniy
Github user stalniy commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120596224 --- Diff: src/ios/CDVCapture.m --- @@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath forCallbackId:(NSString*)

[GitHub] cordova-plugin-media-capture issue #79: CB-12882: (ios): adds support for pe...

2017-06-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media-capture/pull/79 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-media-capture/pull/79/commits/d19be5be1fa5dfbc30fbd997f5e

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

2017-06-07 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 @filmaj, no, the same pr was merged into DefinitelyTyped repo (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14138) --- If your project is set up for it, you c

[GitHub] cordova-plugin-statusbar pull request #79: Browser: Check callback exists be...

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/79 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-statusbar issue #79: Browser: Check callback exists before ca...

2017-06-07 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/79 Thank you for the PR and the quick responses! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

2017-06-07 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/34 @filmaj, @infil00p, do I need to do something else on this issue? --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cordova-plugin-camera pull request #262: fix(error): changes error message f...

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera issue #262: fix(error): changes error message for ios ...

2017-06-07 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/262 Thanks for the PR and the quick responses! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-file-transfer issue #150: CB-11534 This plugin should support...

2017-06-07 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/150 Thanks. I will need to test this manually as the file-transfer CI is super broken. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

2017-06-07 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 @matrosov-nikita go for it, then. You have committer rights, yes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

2017-06-07 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/34 @matrosov-nikita as long as you tested this on one of the real devices affected by the issue, and confirmed the fix, I am good to have this merged. --- If your project is se

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

2017-06-07 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 @filmaj, I don't have committer rights. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

Re: [NOTICE] Intent on moving to Github

2017-06-07 Thread Filip Maj
That's really helpful Carlos, thanks! On Wed, Jun 7, 2017 at 12:47 AM, Steven Gill wrote: > Thanks Carlos! Very useful information! > > On Tue, Jun 6, 2017 at 5:28 PM, Carlos Santana wrote: > >> ASF will allow it, other projects already showed interest and at ApacheCon >> they made it public tha

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

2017-06-07 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 Huh, strange. Perhaps we should nominate you :) I will merge this in, then. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

2017-06-07 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/34 Just realized you don't have committer rights - I will merge this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

2017-06-07 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/34 @matrosov-nikita can you rebase with latest master first, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

2017-06-07 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 Same thing - can you rebase with latest master here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

2017-06-07 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/34 @filmaj, done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] cordova-plugin-test-framework pull request #25: CB-12847: added `bugs` entry...

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

2017-06-07 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 @filmaj, done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] cordova-plugin-device-orientation pull request #34: CB-12667 android: Added ...

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-orientation/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-inappbrowser pull request #212: Add 'hide' method in typing d...

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-windows pull request #233: CB-12847: fixed `bugs` entry in package.j...

2017-06-07 Thread filmaj
Github user filmaj closed the pull request at: https://github.com/apache/cordova-windows/pull/233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-plugin-whitelist pull request #25: CB-12847: added `bugs` entry to p...

2017-06-07 Thread filmaj
Github user filmaj closed the pull request at: https://github.com/apache/cordova-plugin-whitelist/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-inappbrowser issue #212: Add 'hide' method in typing definiti...

2017-06-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/212 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/212/commits/b6ed0bbaca9c3dfde83e0322e4e

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

2017-06-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-device-orientation/pull/34 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-device-orientation/pull/34/commits/a77b4fa0a410d22a0

[GitHub] cordova-android pull request #383: CB-12762 : pointed package.json repo item...

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/383 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-windows pull request #230: CB-12617 Removed node 0.x

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/230 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-windows pull request #229: Allow build when using --bundle and multi...

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-windows pull request #175: Fix build result when using --bundle and ...

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/175 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-windows pull request #231: Fix broken headings in Markdown files

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-plugin-media pull request #140: Fixed the link to report issues

2017-06-07 Thread dellagustin
Github user dellagustin closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-media pull request #141: Fixed link to issue tracker

2017-06-07 Thread dellagustin
GitHub user dellagustin opened a pull request: https://github.com/apache/cordova-plugin-media/pull/141 Fixed link to issue tracker ### Platforms affected none ### What does this PR do? Fix the link to the issue tracker. The component Plugin Media was be

[GitHub] cordova-plugin-media issue #141: Fixed link to issue tracker

2017-06-07 Thread dellagustin
Github user dellagustin commented on the issue: https://github.com/apache/cordova-plugin-media/pull/141 This pull request replaces https://github.com/apache/cordova-plugin-media/pull/140/commits/5e6cfb628f7a2e9d1a867ea223dfd7fd6212734f I had some mess with the commits of that

[GitHub] cordova-plugin-media issue #141: Fixed link to issue tracker

2017-06-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/141 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/141/commits/b05c66c51f29cd31fda0f2ca58a04ea47da9af7c)

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-06-07 Thread karlachavez
Github user karlachavez commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 We can reproduce this issue on a Samsung S6 with the following tech specs: http://www.samsung.com/ca/business/business-products/smartphones/smartphones/SM-G920WZWABMC

[GitHub] cordova-plugin-media pull request #130: CB-8098 & CB-7810:(android) Added me...

2017-06-07 Thread dellagustin
Github user dellagustin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/130#discussion_r120745011 --- Diff: src/android/AudioPlayer.java --- @@ -532,6 +532,27 @@ public void setVolume(float volume) { } } +

[GitHub] cordova-plugin-media pull request #130: CB-8098 & CB-7810:(android) Added me...

2017-06-07 Thread dellagustin
Github user dellagustin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/130#discussion_r119812195 --- Diff: www/Media.js --- @@ -173,7 +173,9 @@ Media.prototype.setRate = function(rate) { if (cordova.platformId === 'ios'){ -

[GitHub] cordova-plugin-media pull request #130: CB-8098 & CB-7810:(android) Added me...

2017-06-07 Thread dellagustin
Github user dellagustin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/130#discussion_r120737624 --- Diff: src/android/AudioPlayer.java --- @@ -271,7 +272,6 @@ public void stopRecording(boolean stop) { this.move

[GitHub] cordova-plugin-media pull request #141: Fixed link to issue tracker

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-plugin-media issue #141: Fixed link to issue tracker

2017-06-07 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/141 Thanks for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-plugin-media pull request #142: documentation: setRate method

2017-06-07 Thread dellagustin
GitHub user dellagustin opened a pull request: https://github.com/apache/cordova-plugin-media/pull/142 documentation: setRate method ### Platforms affected iOS ### What does this PR do? Adds documentation for the setRate method ### What testing has

[GitHub] cordova-plugin-media issue #130: CB-8098 & CB-7810:(android) Added media rat...

2017-06-07 Thread dellagustin
Github user dellagustin commented on the issue: https://github.com/apache/cordova-plugin-media/pull/130 @filmaj @AshishMehra I created pull request https://github.com/apache/cordova-plugin-media/pull/142 to document the existing setRate method for iOS platform. --- If your project i

[GitHub] cordova-plugin-media issue #130: CB-8098 & CB-7810:(android) Added media rat...

2017-06-07 Thread dellagustin
Github user dellagustin commented on the issue: https://github.com/apache/cordova-plugin-media/pull/130 @ghenry22, I'm interested on using this feature as well in android, but I think some adaptations on the code are needed, can you take a look a my comments? --- If your project is

[GitHub] cordova-plugin-media issue #142: documentation: setRate method

2017-06-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/142 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/142/commits/0ff223093044d3e6d993b6eee36af2e92b40f90b)

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

2017-06-07 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15/commits/56df01a38843445eb8c83c

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-06-07 Thread Lazza
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @karlachavez > we have to remove the splashscreen of our app In the meantime: cordova plugins remove cordova-plugin-splashscreen cordova plugi

Nightly build #368 for cordova has failed

2017-06-07 Thread Apache Jenkins Server
Nightly build #368 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/368/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/368/consoleFull - Jenkins for Apache Cordova