GitHub user dpogue reopened a pull request:
https://github.com/apache/cordova-ios/pull/228
[CB-10916] Support display name for iOS
This is the iOS Platform API support side of
https://github.com/apache/cordova-lib/pull/453.
You can merge this pull request into a Git repository by
Github user dpogue closed the pull request at:
https://github.com/apache/cordova-ios/pull/228
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dpogue commented on the issue:
https://github.com/apache/cordova-ios/pull/228
@shazron All good now :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wis
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/150
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-file-transfer/pull/150/commits/eaabd8e84e08ef0090d67f32b5
Github user dellagustin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/140#discussion_r120577449
--- Diff: README.md ---
@@ -46,7 +46,7 @@ function onDeviceReady() {
}
```
-Report issues with this plugin on the [Apac
Github user stalniy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120596224
--- Diff: src/ios/CDVCapture.m ---
@@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath
forCallbackId:(NSString*)
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/79
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-media-capture/pull/79/commits/d19be5be1fa5dfbc30fbd997f5e
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/212
@filmaj, no, the same pr was merged into DefinitelyTyped repo
(https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14138)
---
If your project is set up for it, you c
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/79
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/79
Thank you for the PR and the quick responses!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
@filmaj, @infil00p, do I need to do something else on this issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/262
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/262
Thanks for the PR and the quick responses!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/150
Thanks. I will need to test this manually as the file-transfer CI is super
broken.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/212
@matrosov-nikita go for it, then. You have committer rights, yes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
@matrosov-nikita as long as you tested this on one of the real devices
affected by the issue, and confirmed the fix, I am good to have this merged.
---
If your project is se
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/212
@filmaj, I don't have committer rights.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
That's really helpful Carlos, thanks!
On Wed, Jun 7, 2017 at 12:47 AM, Steven Gill wrote:
> Thanks Carlos! Very useful information!
>
> On Tue, Jun 6, 2017 at 5:28 PM, Carlos Santana wrote:
>
>> ASF will allow it, other projects already showed interest and at ApacheCon
>> they made it public tha
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/212
Huh, strange. Perhaps we should nominate you :)
I will merge this in, then.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
Just realized you don't have committer rights - I will merge this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
@matrosov-nikita can you rebase with latest master first, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/212
Same thing - can you rebase with latest master here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
@filmaj, done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-test-framework/pull/25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/212
@filmaj, done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/212
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user filmaj closed the pull request at:
https://github.com/apache/cordova-windows/pull/233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user filmaj closed the pull request at:
https://github.com/apache/cordova-plugin-whitelist/pull/25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/212
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/212/commits/b6ed0bbaca9c3dfde83e0322e4e
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-device-orientation/pull/34/commits/a77b4fa0a410d22a0
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/383
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/230
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/229
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/175
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/231
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user dellagustin closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user dellagustin opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/141
Fixed link to issue tracker
### Platforms affected
none
### What does this PR do?
Fix the link to the issue tracker.
The component Plugin Media was be
Github user dellagustin commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/141
This pull request replaces
https://github.com/apache/cordova-plugin-media/pull/140/commits/5e6cfb628f7a2e9d1a867ea223dfd7fd6212734f
I had some mess with the commits of that
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/141
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-media/pull/141/commits/b05c66c51f29cd31fda0f2ca58a04ea47da9af7c)
Github user karlachavez commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
We can reproduce this issue on a Samsung S6 with the following tech specs:
http://www.samsung.com/ca/business/business-products/smartphones/smartphones/SM-G920WZWABMC
Github user dellagustin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/130#discussion_r120745011
--- Diff: src/android/AudioPlayer.java ---
@@ -532,6 +532,27 @@ public void setVolume(float volume) {
}
}
+
Github user dellagustin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/130#discussion_r119812195
--- Diff: www/Media.js ---
@@ -173,7 +173,9 @@ Media.prototype.setRate = function(rate) {
if (cordova.platformId === 'ios'){
-
Github user dellagustin commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/130#discussion_r120737624
--- Diff: src/android/AudioPlayer.java ---
@@ -271,7 +272,6 @@ public void stopRecording(boolean stop) {
this.move
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/141
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/141
Thanks for the PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user dellagustin opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/142
documentation: setRate method
### Platforms affected
iOS
### What does this PR do?
Adds documentation for the setRate method
### What testing has
Github user dellagustin commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/130
@filmaj @AshishMehra I created pull request
https://github.com/apache/cordova-plugin-media/pull/142 to document the
existing setRate method for iOS platform.
---
If your project i
Github user dellagustin commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/130
@ghenry22, I'm interested on using this feature as well in android, but I
think some adaptations on the code are needed, can you take a look a my
comments?
---
If your project is
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/142
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-media/pull/142/commits/0ff223093044d3e6d993b6eee36af2e92b40f90b)
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15/commits/56df01a38843445eb8c83c
Github user Lazza commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
@karlachavez
> we have to remove the splashscreen of our app
In the meantime:
cordova plugins remove cordova-plugin-splashscreen
cordova plugi
Nightly build #368 for cordova has failed.
Please check failure details on build details page at
https://builds.apache.org/job/cordova-nightly/368/
You can also take a look at build console:
https://builds.apache.org/job/cordova-nightly/368/consoleFull
-
Jenkins for Apache Cordova
53 matches
Mail list logo