Github user darylldawn commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/65
Hi, is this already merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user maxpaj commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/65
Check out my branch here:
https://github.com/maxpaj/cordova-plugin-media-capture
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user darylldawn commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/65
@maxpaj works perfectly! thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user romedius commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/137
Let there be tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user romedius commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/137
(hopefully this triggers the CI)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/137
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-media/pull/137/commits/e5a5e6fc4c8b54caab5e72b9ae10c7437c2f95f3)
GitHub user dananos opened a pull request:
https://github.com/apache/cordova-docs/pull/707
Missing bracket
There is a missing bracket in the code example. I've just added it.
Thanks.
You can merge this pull request into a Git repository by running:
$ git pull https:/
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/382
Adjusted based on comments. Thanks y'all! Once tests pass I will merge in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/382
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/380
@infil00p so what's the plan here? Are these changes to readme/JDK
requirements unfounded? Close this?
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/380
I think this should be discussed on the list. There's upsides and
downsides to this, and it could attract more developers to adopt JDK 7 and
newer Java features.
---
If your project is s
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/561
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr&el=h1)
Report
> Merging
[#561](https://codecov.io/gh/apache/cordova-lib/pull/561?src=pr&el=desc) into
[master](https:
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/137
Sweet, I'm down with merging this in. Small nit: if you could rebase w/
latest master and combine the commits into one that'd be fantastic!
@infil00p any concerns from you on thi
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-globalization/pull/57
Thanks for the pull request @ihadeed! Merging in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-globalization/pull/57
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/79
LGTM. Can you rebase w/ latest master? I'll merge in then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/140#discussion_r120494584
--- Diff: README.md ---
@@ -46,7 +46,7 @@ function onDeviceReady() {
}
```
-Report issues with this plugin on the [Apache Co
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/706
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/318
CB-12887 - cordova run --list does not show virtual devices in iOS 11
### Platforms affected
self
### What does this PR do?
Fix 'cordova run --list' not showing any vi
Github user filmaj commented on the issue:
https://github.com/apache/cordova-docs/pull/706
Thanks for the PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/262
@stalniy I'm happy to merge this in, but can you rebase your branch with
latest master first? Thanks!
---
If your project is set up for it, you can reply to this email and have your
re
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/317
Thanks! One small thing to enable auto GH->JIRA tracking -- can you prefix
the PR title with "CB-12883"? Thanks! I would do it myself but I don't have the
karma (none of us committers do directl
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120496658
--- Diff: src/ios/CDVCapture.m ---
@@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath
forCallbackId:(NSString*)c
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120496517
--- Diff: src/ios/CDVCapture.m ---
@@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath
forCallbackId:(NSString*)c
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/150#discussion_r120497208
--- Diff: plugin.xml ---
@@ -30,6 +30,8 @@
https://issues.apache.org/jira/browse/CB/component/12320650
+
My one comment is OMG YISS!
On Mon, Jun 5, 2017 at 6:41 PM, Shazron wrote:
> The Apache Cordova Project Management Committee (PMC) has consensus that we
> should move primary development of Apache Cordova to Github, from Apache's
> servers (role would be reversed, Apache would then be the mirror
Friendly reminder that we will have to update the CI scripts to handle
this now. I believe we are mid-transition away from cloudapp Jenkins
to Travis/AppVeyor now (ping Alex Sorokin).
On Tue, Jun 6, 2017 at 1:03 AM, Steven Gill wrote:
> I've started moving cordova-common, cordova-fetch and cordov
Yay! Hope ASF allows us to finally do this!
On Tue, Jun 6, 2017 at 3:28 PM, Filip Maj wrote:
> My one comment is OMG YISS!
>
> On Mon, Jun 5, 2017 at 6:41 PM, Shazron wrote:
> > The Apache Cordova Project Management Committee (PMC) has consensus that
> we
> > should move primary development of
Github user rafael-chavez commented on the issue:
https://github.com/apache/cordova-ios/pull/317
Done! @shazron
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
no one make any commits to common, fetch or serve (in cordova-lib) until
i'm done ripping it out please
On Tue, Jun 6, 2017 at 3:29 PM, Filip Maj wrote:
> Friendly reminder that we will have to update the CI scripts to handle
> this now. I believe we are mid-transition away from cloudapp Jenkins
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120506321
--- Diff: src/ios/CDVCapture.m ---
@@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath
forCallbackId:(NSString*)
ASF will allow it, other projects already showed interest and at ApacheCon
they made it public that they will allow it to any project
My incubator project OpenWhisk is the first one to work out all the kinks
For now let know everyone that wants write access, specially those that are
repo owners a
Nightly build #367 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g
cordova@nightly'
For details check build console at
https://builds.apache.org/job/cordova-nightly/367/consoleFull
-
Jenkins for Apache Cordova
-
Github user stalniy commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/262
@filmaj done! Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user stalniy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120533184
--- Diff: src/ios/CDVCapture.m ---
@@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath
forCallbackId:(NSString*)
Github user stalniy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120533655
--- Diff: src/ios/CDVCapture.m ---
@@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath
forCallbackId:(NSString*)
Github user stalniy commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120534419
--- Diff: src/ios/CDVCapture.m ---
@@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath
forCallbackId:(NSString*)
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/79
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-media-capture/pull/79/commits/ba868e27f3ab2bae523a6170094
Github user imgx64 commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/79
@filmaj Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/79
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/79/commits/92fff60cc7e52f4be876ae559bde2b980ed
Thanks Carlos! Very useful information!
On Tue, Jun 6, 2017 at 5:28 PM, Carlos Santana wrote:
> ASF will allow it, other projects already showed interest and at ApacheCon
> they made it public that they will allow it to any project
>
> My incubator project OpenWhisk is the first one to work out
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/262
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-camera/pull/262/commits/c3d7e55ad428bd154fa6bf5bcd38ee53b152
Github user homen commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/150
@filmaj All my editors showing correct alignment. Anyhow I fixed this with
five commits :)
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/228
@dpogue bah, same timeout error. Please do the close and re-open PR dance
again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
I have lifted the code freeze. Feel free to commit again in cordova-lib.
The modules have officially been broken out. cordova-lib has been moved to
top level in its existing git repo.
coho repo-clone -r common -r fetch -r serve will clone the modules from
their new repo
Still have a bit of CI fla
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/150
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-file-transfer/pull/150/commits/4be0f089431427aad2aa6c4214
I will have to prep a new coho release as well.
Can we add coho as a nightly as well or is that too much work?
On Tue, Jun 6, 2017 at 11:16 PM, Steven Gill wrote:
> I have lifted the code freeze. Feel free to commit again in cordova-lib.
> The modules have officially been broken out. cordova-lib
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/150
Cordova CI Build has one or more failures.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-file-transfer/pull/150/commits/f4669ec2f5b20dfeb9aaba3cc3
48 matches
Mail list logo