[GitHub] cordova-lib pull request #533: CB-12250 CB-12409 iOS: Fix bug with escaping ...

2017-03-29 Thread matrosov-nikita
GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-lib/pull/533 CB-12250 CB-12409 iOS: Fix bug with escaping properties from plist file ### Platforms affected iOS ### What does this PR do? This PR fixes some bugs with remov

RE: [Vote] 6.2.0 Android Release

2017-03-29 Thread Alexander Sorokin (Akvelon)
I vote +1. * Verified archives via `coho verify-archive` * Verified tags manually * Verified that blank app creates correctly with platform * Verified that blank app can successfully build and run * Verified that platform can be updated from previous version * Verified compatibility with core plug

RE: [Vote] 6.2.0 Android Release

2017-03-29 Thread alsorokin
Whoops, re-sending from the apache mailbox to avoid hitting spam-filters. -Original Message- From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com.INVALID] Sent: Wednesday, March 29, 2017 6:59 PM To: dev@cordova.apache.org Subject: RE: [Vote] 6.2.0 Android Release I vote +1.

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

2017-03-29 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r108737235 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -64,7 +64,25 @@ function installPlatformsFromConfigXML(platforms, opts) { //

[GitHub] cordova-lib pull request #521: CB-12425 : Auto-create package.json if it doe...

2017-03-29 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/521#discussion_r108751887 --- Diff: cordova-lib/src/cordova/restore-util.js --- @@ -64,7 +64,25 @@ function installPlatformsFromConfigXML(platforms, opts) { // C

[GitHub] cordova-lib issue #533: CB-12250 CB-12409 iOS: Fix bug with escaping propert...

2017-03-29 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/533 CI failure is unrelated to this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request #689: CB-12591 : Updating cordova docs to reflect ...

2017-03-29 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/689#discussion_r108813703 --- Diff: www/docs/en/dev/platform_plugin_versioning_ref/index.md --- @@ -27,7 +27,7 @@ From version 4.3.0 onwards, Cordova provides the ability to sa

Nightly build #297 for cordova has succeeded!

2017-03-29 Thread Apache Jenkins Server
Nightly build #297 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/297/consoleFull - Jenkins for Apache Cordova -

[GitHub] cordova-lib issue #532: CB-12612 : removing amazon-fireos code

2017-03-29 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-lib/pull/532 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-lib issue #399: CB-10034 Addresses Embedded/Linked/Signed Custom Fra...

2017-03-29 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/399 I need to get the `embed` attribute feature out and thus will send out a new PR by just enabling: ``` embed: isStrTrue(el.attrib.embed), ``` in `cordova-common/src/PluginInfo/Plug