[GitHub] cordova-lib pull request #529: CB-11346 Remove known platforms check

2017-03-16 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/529 CB-11346 Remove known platforms check Building on top of the work by @purplecabbage and @shazron. Still need to fix failing tests + add some new tests. Also, need to run thr

[GitHub] cordova-cli pull request #270: CB-11346 Remove known platforms check

2017-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/270 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli issue #266: CB-12008 : made autosave the default for platform an...

2017-03-16 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-cli/pull/266 Your cordova-cli PRs are ready to rebase now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cordova-plugin-geolocation issue #85: Android: handle location service is of...

2017-03-16 Thread Menardi
Github user Menardi commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/85 @stevengill Is there anything else that needs to be done to get this merged? It seems like quite a key feature to me! --- If your project is set up for it, you can reply to this e

[GitHub] cordova-android issue #369: Updated CLI scripts to support Android SDK Tools...

2017-03-16 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/369 @dpogue thanks for checking! So I think `android_sdk_version` failing in this case is kind of expected, as that script, historically, did not do any environment checking, and I tried keeping

[GitHub] cordova-android issue #369: Updated CLI scripts to support Android SDK Tools...

2017-03-16 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/369 Oh yes, and ping @alsorokin - not sure if the changes to the android CLI scripts affect the CI in any way? But in any case, probably worth getting your eyes on this change too :) --- If you

[GitHub] cordova-android issue #369: Updated CLI scripts to support Android SDK Tools...

2017-03-16 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-android/pull/369 I'll create a test job that uses this code when our slaves are back up (some Microsoft infra permutations are underway ATM). --- If your project is set up for it, you can reply to this em

[GitHub] cordova-plugin-inappbrowser pull request #216: Update README.md

2017-03-16 Thread murphy85
GitHub user murphy85 opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/216 Update README.md Changed options description from string to object ### Platforms affected ### What does this PR do? ### What testi

[GitHub] cordova-plugin-geolocation issue #86: Add required=false to the uses-feature

2017-03-16 Thread patrickbussmann
Github user patrickbussmann commented on the issue: https://github.com/apache/cordova-plugin-geolocation/pull/86 You can add this line to your `config.xml`. With this content. #!/usr/bin/env node module.exports = function (context) {

[GitHub] cordova-cli issue #266: CB-12008 : made autosave the default for platform an...

2017-03-16 Thread audreyso
Github user audreyso commented on the issue: https://github.com/apache/cordova-cli/pull/266 Thanks! @stevengill ...Rebased cli PR's! Let me know if I need to make any additional changes! --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: Saving file with cordova-plugin-file(file-transfer) on device

2017-03-16 Thread Andrew Kucheruk
Hello. I`m developer. Right know i trying to download file and make it visible in device gallery. With first step all good i download it in cordova.file.externalRootDirectory and I can see it with file manager but in gallery i don`t see it. Help me with that. How Can i make that video file visible

[GitHub] cordova-plugin-media issue #134: CB-12542: (ios) Fix wav file recording, add...

2017-03-16 Thread LoneyGG
Github user LoneyGG commented on the issue: https://github.com/apache/cordova-plugin-media/pull/134 Why this hasn't been merged yet? its a pain to apply the fix manually and remove this plugin from the gitignore in order to share my code with my partners. --- If your project is set

[GitHub] cordova-android issue #369: Updated CLI scripts to support Android SDK Tools...

2017-03-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-android/pull/369 I have the same results as @dpogue. Tested macOS Sierra with Android SDK 25.3.1 and Windows 10 with Android SDK 25.3.1. For `android_sdk_version` on Windows I got this error: ```

[GitHub] cordova-android issue #369: Updated CLI scripts to support Android SDK Tools...

2017-03-16 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/369 @shazron I think that's expected and will happen if you also try it with the `master` branch. It is because `android_sdk_version` does not leverage `check_reqs`, which will modify your `PATH`

[GitHub] cordova-android issue #369: Updated CLI scripts to support Android SDK Tools...

2017-03-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-android/pull/369 @filmaj as usual, perhaps we need to keep it around, and set a deprecation period of three releases (we had a discussion in dev@) --- If your project is set up for it, you can reply to this

[GitHub] cordova-ios pull request #296: CB-12571 - Podfile gets overwritten and some ...

2017-03-16 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-ios/pull/296 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-ios pull request #296: CB-12571 - Podfile gets overwritten and some ...

2017-03-16 Thread shazron
GitHub user shazron reopened a pull request: https://github.com/apache/cordova-ios/pull/296 CB-12571 - Podfile gets overwritten and some dependencies disappear. ### Platforms affected self ### What does this PR do? Fix reading of pods with non-alphanumeric

[GitHub] cordova-ios issue #296: CB-12571 - Podfile gets overwritten and some depende...

2017-03-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/296 Looks like another case of simulator not starting. Closing and re-opening for CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-ios issue #296: CB-12571 - Podfile gets overwritten and some depende...

2017-03-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/296 For reference, it passed on my personal repo here: https://travis-ci.org/shazron/cordova-ios/builds/211143535 --- If your project is set up for it, you can reply to this email and have your rep

[DISCUSS] Remove cordova-android's `android_sdk_version` script

2017-03-16 Thread Filip Maj
I recently issued a pull request to update the cordova-android CLI scripts to work with Android SDK Tools 25.3.1 [1]. As part of the discussion in there, it came up that, in particular cases where one's environment was not set up with proper environment variables, running `./bin/android_sdk_version

[GitHub] cordova-ios issue #297: CB-12050 ios: Create shared scheme for framework tar...

2017-03-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/297 Good stuff, tested it, it works as you described. Two issues related to using module import using `@import Cordova;` which I will address in a separate PR though: ![screen shot 2017-03-16

[GitHub] cordova-ios pull request #297: CB-12050 ios: Create shared scheme for framew...

2017-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/297 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios issue #297: CB-12050 ios: Create shared scheme for framework tar...

2017-03-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/297 Posted #298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-ios pull request #298: CB-12577 - Fix module import warnings when us...

2017-03-16 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/298 CB-12577 - Fix module import warnings when using Cordova.framework (Carthage) ### Platforms affected self ### What does this PR do? Remove warnings related to incompl

Re: [VOTE] plugin release : cordova-plugin-screen-orientation

2017-03-16 Thread Jesse
I am closing this vote. It has come to my attention (thanks @alsorokin) that the archive does not include the tests ( because of a .npmignore ) I have retagged, updated, re-archived the release, and will be starting a new vote thread momentarily. Thanks for your patience! @purplecabbage risingj.

[GitHub] cordova-docs pull request #686: CB-12559: documentation updates for new Andr...

2017-03-16 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-docs/pull/686 CB-12559: documentation updates for new Android SDK Tools Ping @infil00p, @shazron, @dpogue, @purplecabbage for review, please and thank you. Please do not merge this until a

[VOTE] plugin release : cordova-plugin-screen-orientation (attempt 2)

2017-03-16 Thread Jesse
Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-12568 The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-12568/

[GitHub] cordova-lib issue #529: CB-11346 Remove known platforms check

2017-03-16 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/529 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=h1) Report > Merging [#529](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=desc) into [master](https:

[GitHub] cordova-lib issue #529: CB-11346 Remove known platforms check

2017-03-16 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/529 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=h1) Report > Merging [#529](https://codecov.io/gh/apache/cordova-lib/pull/529?src=pr&el=desc) into [master](https:

[GitHub] cordova-docs pull request #686: CB-12559: documentation updates for new Andr...

2017-03-16 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/686#discussion_r106557529 --- Diff: www/docs/en/dev/guide/platforms/android/index.md --- @@ -62,19 +63,20 @@ they dip below 5% on Google's ### Java Development Kit (JDK

Re: Saving file with cordova-plugin-file(file-transfer) on device

2017-03-16 Thread Jesse
Moved dev list to bcc Hi Andrew, This list is for development of the cordova framework itself, and not really for user support. That said, I will attempt to help you, or steer you in the right direction. What platform are you seeing the issue in, and are you using the camera api? If you are attem

[GitHub] cordova-ios issue #298: CB-12577 - Fix module import warnings when using Cor...

2017-03-16 Thread khawkins
Github user khawkins commented on the issue: https://github.com/apache/cordova-ios/pull/298 Thanks @shazron . I could have sworn those were in there initially, but I guess not? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-ios pull request #296: CB-12571 - Podfile gets overwritten and some ...

2017-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/296 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Nightly build #284 for cordova has failed

2017-03-16 Thread Apache Jenkins Server
Nightly build #284 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/284/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/284/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-lib issue #529: CB-11346 Remove known platforms check

2017-03-16 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/529 Now to add tests! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] cordova-ios pull request #298: CB-12577 - Fix module import warnings when us...

2017-03-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is