Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/122
@ghenry22 I'm the last one to comment on an Android patch. perhaps
@infil00p can chime in on reviewing this? I can merge if its approved
---
If your project is set up for it, you can r
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/254
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/176
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/176
Cordova CI Build has completed successfully.
Please note that a lot of tests are currently disabled on CI. To make sure
everything works, please run tests locally via
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-plugin-screen-orientation/commit/70dfab7f9b10e6fae0ada9b461b40934e2a1042d#commitcomment-20992434
Hey @purplecabbage it's also needed in Android, take a look at this build:
http://cordova-ci.clou
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-screen-orientation/commit/70dfab7f9b10e6fae0ada9b461b40934e2a1042d#commitcomment-20992671
Can we update that the tests to hit 4.4.4? 4.4 was the last android release
without it.
---
If
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-plugin-screen-orientation/commit/70dfab7f9b10e6fae0ada9b461b40934e2a1042d#commitcomment-20992698
Of course, but... does it mean that we don't support Android 4.4 anymore?
---
If your project is set
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-screen-orientation/commit/70dfab7f9b10e6fae0ada9b461b40934e2a1042d#commitcomment-20992860
Yeah bigger question ...
I'll add it back in for android tomorrow.
---
If your project is s
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-plugin-screen-orientation/commit/70dfab7f9b10e6fae0ada9b461b40934e2a1042d#commitcomment-20992886
Thanks a lot Jesse!
---
If your project is set up for it, you can reply to this email and have your
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-screen-orientation/commit/70dfab7f9b10e6fae0ada9b461b40934e2a1042d#commitcomment-20992979
Thanks for catching my error!
---
If your project is set up for it, you can reply to this email
Github user kbeaugrand commented on the issue:
https://github.com/apache/cordova-plugin-vibration/pull/48
Hi,
Sorry but it was a long time ago...
I think thati I had to remove the csproj because when building my
solution, cordova tries to build this csproj and fail
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-android/pull/362
CB-12453: Remove unnecessary double quotes from .bat files which are the
causes of crash if project path contains spaces
### Platforms affected
self
###
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/149
CB-11038 (Android) Search only among visible contacts
### Platforms affected
Android
### What does this PR do?
Makes search() look only through visible contacts, e
Github user yamane-dsys closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/58
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/149
Cordova CI Build has completed successfully.
**Commit** -
[Link](https://github.com/apache/cordova-plugin-contacts/pull/149/commits/fdaeabdfeca32b6ac5bc111be5a68fe619c
Hello,
I'm creating a Cordova config file for a project that uses Cordova v 6.5.0.
I'm wondering if anything has changed in the structure for Android or iOS with
v 6.5.0? Also, has the archive folder or archive name changed for Andriod or
iOS with v 6.5.0?
Thank you,
Nicole Collichio
::
Github user bhariharan commented on the issue:
https://github.com/apache/cordova-android/pull/361
@infil00p @stevengill Any feedback on this PR? I was hoping to switch my
plugin to consume `Cordova` from `jCenter` soon :-)
---
If your project is set up for it, you can reply to this e
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugins/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugins/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugins/pull/25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugins/pull/22
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user stevengill commented on the issue:
https://github.com/apache/cordova-android/pull/361
Yes! Sorry I promise to test it locally today and merge it in if all goes
well!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bhariharan commented on the issue:
https://github.com/apache/cordova-android/pull/361
Thanks @stevengill! Let me know if it needs any tweaks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugins/pull/28#discussion_r102574864
--- Diff: local-webserver/src/ios/CDVLocalWebServer.m ---
@@ -52,6 +53,12 @@ - (void) pluginInitialize {
if (startPageUrl != nil) {
Github user shazron commented on a diff in the pull request:
https://github.com/apache/cordova-plugins/pull/28#discussion_r102574949
--- Diff: local-webserver/src/ios/CDVLocalWebServer.m ---
@@ -52,6 +53,12 @@ - (void) pluginInitialize {
if (startPageUrl != nil) {
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugins/pull/28
FYI, the `local-webserver` code has been moved to a
[branch](https://github.com/apache/cordova-plugins/tree/local-webserver), see
the README in the root of this repo.
Don't worry abo
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-android/pull/363
CB-12465: Rewrite of the Unit Tests
### Platforms affected
Android
### What does this PR do?
Re-writes the Unit Tests so that we have some unit tests.
##
Hey
So, this would have happened sooner, but I have the new format with most of
the tests migrated. Due to permission issues, I deleted the Cordova
Resource API integration test, but if someone wants to figure out how to
get that working, feel free.
https://github.com/apache/cordova-android/pull
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/520
CB-11977 : removed support for node 0.x
### Platforms affected
### What does this PR do?
Removed support for node 0.x. Node 4 and 6 still supported.
##
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/20
@boboldehampsink what settings, can you clarify?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/20
@jumplee I'll re-test with location.href and report back
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/129
@TommiKetola #122 should catch most scenarios that would cause this one to
occur. However, there is no validation that a value is passed in to the method
that this PR patches either s
Github user ghenry22 commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/122
@shazron thanks, sorry to bug you just figured you were kind of the
gatekeeper here.
@infil00p I have been running with this PR (and the other null point PR
that was recently
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/146
It _does_ look like [iOS returns label
information](https://github.com/apache/cordova-plugin-contacts/blob/master/src/ios/CDVContact.h#L92)
in contacts, so there is precedent to enhan
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/142
It looks like a JIRA issue is filed for this already:
https://issues.apache.org/jira/browse/CB-10496
---
If your project is set up for it, you can reply to this email and have your
r
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/20
Ok, for location.href (say in a button tag onclick handler), it's
definitely a bug when using wkwebview-engine (UIWebView is fine). For the
CDVIntentAndNavigationFilter, we ar
Github user stevengill commented on the issue:
https://github.com/apache/cordova-android/pull/361
So it doesn't seem to be uploading for me but the output isn't helping.
I managed to add `gradlew` into cordova-android/framework by importing it
into android studio. Then I run
Github user bhariharan commented on the issue:
https://github.com/apache/cordova-android/pull/361
@stevengill Once `BINTRAY_USER` and `BINTRAY_KEY` are set, try this:
```
./gradlew :framework:bintrayUpload
```
instead of:
```
./gradlew bintrayUpload
```
---
Github user stevengill commented on the issue:
https://github.com/apache/cordova-android/pull/361
I did but looks like i added it incorrectly. I added them straight to my
terminal so echo $BINTRAY_USER and key worked but when i logged it in
build.gradle, it did not. I added them prope
Github user bhariharan commented on the issue:
https://github.com/apache/cordova-android/pull/361
Interesting! That means it didn't accept your auth key.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/32
CB-12497 - location.href links are silently disallowed
### Platforms affected
iOS WKWebView
### What does this PR do?
Fixes the bug where javascript
Github user stevengill commented on the issue:
https://github.com/apache/cordova-android/pull/361
Yup. I think i'm using the wrong BINTRAY_USER value. Using my email login.
Looks like I need to use my account name? https://bintray.com/docs/api/
---
If your project is set up for it, y
Github user bhariharan commented on the issue:
https://github.com/apache/cordova-android/pull/361
Yeah - use your `Bintray` username. Mine's `bhariharan` for instance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user stevengill commented on the issue:
https://github.com/apache/cordova-android/pull/361
Woo! https://bintray.com/cordova/maven/cordova-android/6.1.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user stevengill commented on the issue:
https://github.com/apache/cordova-android/pull/361
Thanks @bhariharan!! I'll merge this up and add it to the release process!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/361
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user bhariharan commented on the issue:
https://github.com/apache/cordova-android/pull/361
Right on! Awesome @stevengill! Thanks! I've got some other ideas for other
`Cordova` improvements as a heavy `Cordova` platform user. I'll reach out to
you on `JIRA`.
---
If your projec
Github user stevengill commented on the issue:
https://github.com/apache/cordova-android/pull/361
Sweet! Feel free to ping me on the cordova slack too. slack.cordova.io to
signup.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Nightly build #262 for cordova has failed.
Please check failure details on build details page at
https://builds.apache.org/job/cordova-nightly/262/
You can also take a look at build console:
https://builds.apache.org/job/cordova-nightly/262/consoleFull
-
Jenkins for Apache Cordova
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-contacts/pull/142
Confirmed that this fixes the photo issue - tested on an Android 5.1
emulator.
@infil00p any qualms with merging this in?
---
If your project is set up for it, you can reply
Github user fujunwei commented on the issue:
https://github.com/apache/cordova-android/pull/363
It hangs on running unit tests with `./gradlew connectedAndroidTest`, the
output logs:
> org.apache.cordova.unittests E/AndroidProtocolHandler: Unable to open
asset URL: file:///android
Github user boboldehampsink commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/20
@shazron these settings:
```xml
mailto:*"; />
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/363
@fujunwei I don't think the test should hang, but that's technically a
failure of the test and not a problem with the test itself.
---
If your project is set up for it, you can reply to th
Github user fujunwei commented on the issue:
https://github.com/apache/cordova-android/pull/363
Do you mean the failed test will be continue to fix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/363
@fujunwei Well, when you debug the test, it's clear that it's not
redirecting to the error page that the intent defines, and instead it's going
to some other page or showing a dialog window
55 matches
Mail list logo
