[GitHub] cordova-plugin-wkwebview-engine issue #30: Allow XHR to file:// and allow lo...

2017-02-20 Thread rubenstolk
Github user rubenstolk commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/30 Hey, looks great. Still didn't get time to convert this into a plugin... --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cordova-plugin-camera pull request #254: CB-12469 (ios) Appium tests can now...

2017-02-20 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/254 CB-12469 (ios) Appium tests can now run on iOS 10 ### Platforms affected iOS ### What does this PR do? https://issues.apache.org/jira/browse/CB-12469 Updates the

[GitHub] cordova-plugin-camera issue #254: CB-12469 (ios) Appium tests can now run on...

2017-02-20 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/254 Here's a sample build on both iOS 9 and 10: http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-TEST/37/ --- If your project is set up for it, you can reply to this ema

[GitHub] cordova-plugin-camera issue #254: CB-12469 (ios) Appium tests can now run on...

2017-02-20 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/254 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-camera/pull/254/commits/7f616d16f175fd33514e8dda14ea9ebe7953334

[GitHub] cordova-plugin-camera issue #254: CB-12469 (ios) Appium tests can now run on...

2017-02-20 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/254 @filmaj take a look if you'd like 🙂 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-camera pull request #254: CB-12469 (ios) Appium tests can now...

2017-02-20 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/254#discussion_r102069422 --- Diff: appium-tests/ios/ios.spec.js --- @@ -82,11 +86,43 @@ describe('Camera tests iOS.', function () { .elementByXPath('//

Re: Anyone can help me about add new platform to cordova?

2017-02-20 Thread Steven Gill
You only need to support Api.js. Cordova has a bunch of built in checks for our core platforms. We want to remove them so if you have a compatible platform, it should work. On Feb 19, 2017 10:19 PM, "李广镇" wrote: > Hi all, > I'm trying to add a new platform for cordova. > I have analyzed a

[GitHub] cordova-lib pull request #518: CB-12021 : --fetch should use dependency vers...

2017-02-20 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/518#discussion_r102099272 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -412,15 +412,26 @@ function determinePluginTarget(projectRoot, cfg, target, fetchOptions) {

Re: Anyone can help me about add new platform to cordova?

2017-02-20 Thread Shazron
Also check out https://issues.apache.org/jira/browse/CB-11000 which depends on https://issues.apache.org/jira/browse/CB-11346 On Mon, Feb 20, 2017 at 10:25 AM, Steven Gill wrote: > You only need to support Api.js. > > Cordova has a bunch of built in checks for our core platforms. We want to > re

[GitHub] cordova-lib pull request #519: CB-11346 - Remove known platforms check for P...

2017-02-20 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-lib/pull/519 CB-11346 - Remove known platforms check for Platform API ### Platforms affected CLI ### What does this PR do? Removes platforms check. Right now only known platforms a

[DISCUSS] Remove known platforms check for Platform API

2017-02-20 Thread Shazron
https://issues.apache.org/jira/browse/CB-11346 https://github.com/apache/cordova-lib/pull/519 Any objections? I sent a PR for this, and I will update it to include unit tests. If there are no objections, by the end of the week I will merge the PR in (once tests are in).

回复:Anyone can help me about add new platform to cordova?

2017-02-20 Thread 李广镇
Thanks @Shazron @Steven GillGot it, I will have a try :-) Br.Guangzhen --发件人:Shazron 发送时间:2017年2月21日(星期二) 09:41收件人:dev@cordova.apache.org 抄 送:李广镇(广镇) 主 题:Re: Anyone can help me about add new platform to cordova? Also check out https

Nightly build #260 for cordova has failed

2017-02-20 Thread Apache Jenkins Server
Nightly build #260 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/260/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/260/consoleFull - Jenkins for Apache Cordova

Re: [DISCUSS] Remove known platforms check for Platform API

2017-02-20 Thread Steven Gill
No issues from me. On Mon, Feb 20, 2017 at 5:49 PM, Shazron wrote: > https://issues.apache.org/jira/browse/CB-11346 > https://github.com/apache/cordova-lib/pull/519 > > Any objections? I sent a PR for this, and I will update it to include unit > tests. If there are no objections, by the end of t