[GitHub] cordova-plugin-contacts issue #145: CB-12300: fix tests failure when running...

2016-12-27 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/145 Hey @meirotstein thanks for your contribution! Could you please clarify the way you are running tests using `jasmine-node` so I could test your patch? --- If your projec

[GitHub] cordova-plugin-contacts issue #145: CB-12300: fix tests failure when running...

2016-12-27 Thread meirotstein
Github user meirotstein commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/145 Hi @alsorokin I have wrapped the defineAutoTests method with my own 'describe' and executed jasmine-node via command line - you can see how I use it here (depending

[GitHub] cordova-plugin-contacts issue #145: CB-12300: fix tests failure when running...

2016-12-27 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/145 Oh, I see. Please add Jira issue number to the commit message as follows: `CB-12300: fix tests failure when running it using jasmine-node`, then it will be good to merge. ---

[GitHub] cordova-plugin-contacts pull request #145: CB-12300: fix tests failure when ...

2016-12-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/145 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] cordova-plugin-contacts issue #145: CB-12300: fix tests failure when running...

2016-12-27 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/145 Thanks you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] cordova-plugin-contacts issue #145: CB-12300: fix tests failure when running...

2016-12-27 Thread meirotstein
Github user meirotstein commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/145 My pleasure 😃 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] cordova-plugin-contacts issue #145: CB-12300: fix tests failure when running...

2016-12-27 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/145 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-contacts/pull/145/commits/88192bf17fe0dc790ae705a7a4f14d016b4

[GitHub] cordova-plugin-globalization issue #53: CB-11154: (Android, iOS) Add IANA ti...

2016-12-27 Thread kosssi
Github user kosssi commented on the issue: https://github.com/apache/cordova-plugin-globalization/pull/53 Hello @shazron, @stevengill Can you review this PR? You can see more documentation for IANA Timezone (naming convention for time zones): - https://en.wikipedi

[GitHub] cordova-android issue #352: Include armeabi, arm64-v8a and x86_64 libs

2016-12-27 Thread mbektchiev
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-android/pull/352 After some more thinking about this issue, I think it will be better to provide 3 more flavors: for `arm`, `arm64` and `x86_64` architectures. I will change the PR accordingly. --- If y

[GitHub] cordova-android pull request #354: CB-12099 (android) SplashScreen Screen Fl...

2016-12-27 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-android/pull/354 CB-12099 (android) SplashScreen Screen Flicker ### Platforms affected Android ### What does this PR do? Introduced new SplashScreenBackgroundColor preference.

[GitHub] cordova-plugin-splashscreen pull request #121: CB-12099 (android) SplashScre...

2016-12-27 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/121 CB-12099 (android) SplashScreen Screen Flicker ### Platforms affected Android ### What does this PR do? Documented new SplashScreenBackgroundColor pref

[GitHub] cordova-android issue #354: CB-12099 (android) SplashScreen Screen Flicker

2016-12-27 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/354 ## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/354?src=pr) is 35.58% (diff: 100%) > Merging [#354](https://codecov.io/gh/apache/cordova-android/pull/354?src=

[GitHub] cordova-plugin-splashscreen issue #121: CB-12099 (android) SplashScreen Scre...

2016-12-27 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/121 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-splashscreen/pull/121/commits/ab12462b4186d77099c5eb20d7f

Re: CB-12099 (android) SplashScreen Screen Flicker

2016-12-27 Thread Sergey Shakhnazarov
Hi Joe, guys, happy holidays everyone! Regarding "this is not a problem unique to PhoneGap/Cordova" - I've attached short videos to the Jira [1] with the flicker issue clearly visible for a blank Cordova app (build with latest published versions of cordova, cordova-android and cordova-plugin-splas

[GitHub] cordova-docs pull request #672: CB-12099 [Android] Documented SplashScreenBa...

2016-12-27 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/672 CB-12099 [Android] Documented SplashScreenBackgroundColor ### Platforms affected Android ### What does this PR do? Documented SplashScreenBackgroundColor ###

[GitHub] cordova-plugin-battery-status issue #28: Add battery temperature to Android

2016-12-27 Thread Spiritdude
Github user Spiritdude commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/28 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] cordova-plugin-statusbar pull request #74: CB-12196 (iOS) fix Status Bar Not...

2016-12-27 Thread jcesarmobile
GitHub user jcesarmobile opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/74 CB-12196 (iOS) fix Status Bar Not Hiding ### Platforms affected iOS ### What does this PR do? Fix the statusbar not hiding when overlaysWebView is fal

[GitHub] cordova-plugin-statusbar issue #74: CB-12196 (iOS) fix Status Bar Not Hiding

2016-12-27 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/74 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-statusbar/pull/74/commits/90507a8cd092980cadca1030977b1e1cf2c

[GitHub] cordova-plugin-camera issue #235: CB-11625: Fixes Camera issue w.r.t. conten...

2016-12-27 Thread mkim871
Github user mkim871 commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/235 @samuelt1 I don't really get the comments. How am I supposed to resolve this issue? Do I need to install `BuildHelper`? --- If your project is set up for it, you can reply to this ema